Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1368

SMB : Offer letter CR changes(Date : 8th May 2019)

    Details

    • Type: New Feature
    • Status: Done
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Enhancements - Fall
    • Labels:
      None

      Description

       

      Hi All,

      Can you please update DMS API to address recent UI changes we got?

      1) Create Offer Letter and Offer Letter Preview API - add new field

      "timeOffCompensation": "string",

      2) Offer letter template - render "timeOffCompensation" field instead of current normalized implementation.

       

      Line below should be replaced with timeOffCompensation field

       

      Time off compensation after 10 days, you will be eligible for 20 days of Paid Time Off (PTO) which must be approved by your manager

        

       

        Attachments

        1. AffectedFiles_DMS-1368.txt
          0.7 kB
        2. DEV-1368.xls
          17 kB
        3. Preview-OfferLetter_SMB.pdf
          203 kB
        4. SMBOffer Letter.jpg
          SMBOffer Letter.jpg
          225 kB
        5. TimeOfCompesation.jpg
          TimeOfCompesation.jpg
          219 kB

          Activity

          Descending order - Click to sort in ascending order
          Hide
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Verified on Preproduction.
          Verified through UI-> Admin login and API

          Verified attached testcases.
          PFA - DEV-1368.xls

          All the testcases are passed.

          So closing this ticket

          Thanks,
          Jayshree

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Verified on Preproduction. Verified through UI-> Admin login and API Verified attached testcases. PFA - DEV-1368.xls All the testcases are passed. So closing this ticket Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande
          Hide
          Permalink
          sonali.farakate Sonali Farakate (Inactive) added a comment -

          Hi Priya Dhamande,

          FYI,
          We have done the pdf mapping related changes on production and templateid is 400.

          Thanks,
          Sonali Farakate

          CC : Ramya Tantry

          Show
          sonali.farakate Sonali Farakate (Inactive) added a comment - Hi Priya Dhamande , FYI, We have done the pdf mapping related changes on production and templateid is 400. Thanks, Sonali Farakate CC : Ramya Tantry
          Hide
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited

          Hi Sonali Farakate,

          we have verified this fix for attached SMB offer letter.
          This fix is verified through UI and API .
          Environment : Preproduction
          Login : Admin

          • Time OFF compensation issue related to document and field populating in system field is resolved.

          Refer below issue for UI :
          1.Review and Sign > on click of signature > Signature component is not populating
          PFA :

          Verified through API :
          PFA :
          Link : https://dmsstage.workterra.net/viewer?Token=9a30b7ef5c564bc59c47ecba5c03e9ae&key=05d80bf14f1432ac1720d8ddad02eeb5ef02fd9b943f872e5d99c80c60025dc1

          Can you please look into signature this issue

          Thanks,
          Jayshree

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya Samir

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited Hi Sonali Farakate , we have verified this fix for attached SMB offer letter. This fix is verified through UI and API . Environment : Preproduction Login : Admin Time OFF compensation issue related to document and field populating in system field is resolved. Refer below issue for UI : 1.Review and Sign > on click of signature > Signature component is not populating PFA : Verified through API : PFA : Link : https://dmsstage.workterra.net/viewer?Token=9a30b7ef5c564bc59c47ecba5c03e9ae&key=05d80bf14f1432ac1720d8ddad02eeb5ef02fd9b943f872e5d99c80c60025dc1 Can you please look into signature this issue Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya Samir
          Hide
          Permalink
          sonali.farakate Sonali Farakate (Inactive) added a comment - - edited

          Tasks:
          1. Analysis(5h)

          • Task identification
          • Debugging for understanding functions and flow - POST method,Create method
          • Understanding 'Assignment' table structure from database

          2. Database changes (4h)

          •  Update column name and type of column (CompensationDays) from table Assignment
          •  Delete column EligiblePTODays from table Assignment

          3.Code changes(4h)

          • Changes in function "UpsertAssignmentData"
          • Changes in Class OfferLetterPayload

          4.Testing(6h)

          • Test case writing
          • Unit Testing

          CC :Ramya Tantry, Samir

          Show
          sonali.farakate Sonali Farakate (Inactive) added a comment - - edited Tasks: 1. Analysis(5h) Task identification Debugging for understanding functions and flow - POST method,Create method Understanding 'Assignment' table structure from database 2. Database changes (4h)  Update column name and type of column (CompensationDays) from table Assignment  Delete column EligiblePTODays from table Assignment 3.Code changes(4h) Changes in function "UpsertAssignmentData" Changes in Class OfferLetterPayload 4.Testing(6h) Test case writing Unit Testing CC : Ramya Tantry , Samir
          Hide
          Permalink
          ramya.tantry Ramya Tantry (Inactive) added a comment - - edited

          Hi Samir,

          For the above mentioned changes, we need to change the SMB offer letter PDF to remove the Time off compensation line and replace with text-area for free flow text.

          Please allocate Namrata's time or Priya's time for change as this has to be done with Adobe Reader.

          CC: Rohan J Khandave

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - - edited Hi Samir , For the above mentioned changes, we need to change the SMB offer letter PDF to remove the Time off compensation line and replace with text-area for free flow text. Please allocate Namrata's time or Priya's time for change as this has to be done with Adobe Reader. CC: Rohan J Khandave
          Hide
          Permalink
          samir Samir added a comment -

          Ramya Tantry

          Show
          samir Samir added a comment - Ramya Tantry

            People

            Assignee:
            rohan.khandave Rohan J Khandave (Inactive)
            Reporter:
            swapnil.pandhare Swapnil Pandhare (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 23.5h Original Estimate - 23.5h
                23.5h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 27.75h
                27.75h