-
Type:
New Feature
-
Status: Done
-
Priority:
Medium
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: CBAT Offer Letter - Fall
-
Labels:None
-
Company:All Clients/Multiple Clients
-
Epic Link:
I don't think we need Review for sure because the forms in the process would have been started already and the pending would be that they were send but haven't been started. So I dont think we need Review section at all. Looking at the sent date - this would obviously be filled in for all so again review may not be needed.
Hope this helps. Let me know if you think otherwise.
Hi Harshveer Singh,
Can you please provide some update on this jira?
- Like where to test
- which API and all
As currently, I am unable to get detailed idea for testing.
HI Priya Dhamande, As part of this, you need to test '/api/documents/CBATS/statusSummary' API. This API now returns result grouped by document status. Response structure should be like this:
{
"completed": [
{
"id": 908,
"candidateFirstName": "Narendrawwewwerwer",
"candidateMiddleName": "",
"candidateLastName": "Kumar",
"documentName": "Offer Letter SMBHire",
"documentType": "Offer Letter",
"date": "2019-04-29T02:34:57"
},
],
"inProcess": [
{
"id": 644,
"candidateFirstName": "Olivier",
"candidateMiddleName": "V",
"candidateLastName": "Test",
"documentName": "Offer Letter",
"documentType": "Offer Letter",
"date": "2019-03-07T06:54:24"
},
],
"pending": [
{
"id": 1277,
"candidateFirstName": "John",
"candidateMiddleName": "",
"candidateLastName": "Doe",
"documentName": "SMB OFFER",
"documentType": "Offer Letter",
"date": "2019-04-26T04:34:14"
},
]
}
Harshveer Singh (Inactive)
added a comment - - edited HI Priya Dhamande , As part of this, you need to test '/api/documents/CBATS/statusSummary' API. This API now returns result grouped by document status. Response structure should be like this:
{
"completed" : [
{
"id" : 908,
"candidateFirstName" : "Narendrawwewwerwer" ,
"candidateMiddleName" : "",
"candidateLastName" : "Kumar" ,
"documentName" : "Offer Letter SMBHire" ,
"documentType" : "Offer Letter" ,
"date" : "2019-04-29T02:34:57"
},
],
"inProcess" : [
{
"id" : 644,
"candidateFirstName" : "Olivier" ,
"candidateMiddleName" : "V" ,
"candidateLastName" : "Test" ,
"documentName" : "Offer Letter" ,
"documentType" : "Offer Letter" ,
"date" : "2019-03-07T06:54:24"
},
],
"pending" : [
{
"id" : 1277,
"candidateFirstName" : "John" ,
"candidateMiddleName" : "",
"candidateLastName" : "Doe" ,
"documentName" : "SMB OFFER" ,
"documentType" : "Offer Letter" ,
"date" : "2019-04-26T04:34:14"
},
]
}
Hi Harshveer Singh,
Please update validation or proper error message if incorrect source product is added.
Currently, with this message we didnot get clear idea. Refer screen capture.
Hi Priya, Please create new ticket for this and complete this one if all other testing is passing.
Harshveer Singh (Inactive)
added a comment - - edited Hi Priya, Please create new ticket for this and complete this one if all other testing is passing. Environment: Preprod - OneIM
API: api/documents/CBATS/statusSummary
Test cases attached with jira.
Points covered:
1. API run for correct source product
2. API run for incorrect Source Product.
Suggestion for incorrect message is logged in jira DMS-1720.
Refer screen capture. So, marking jira done.
Sachin Hingole Hrishikesh Deshpande Rohan J Khandave Samir
Monika Demla
Could you please give some information on what needs to be shown in place of "Review".
Check the attached screenshot.
Thanks,
Shamooka