Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1480

Guest user - This should be candidate name or email.

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: CBAT Offer Letter - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      In logout drop down it's showing the Guest User. It should be the candidate name if available otherwise it should be candidate email.

        Attachments

          Activity

          Hide
          akash.thakur Akash Thakur (Inactive) added a comment - - edited

          Hi All,

          Please Find below 3'Cs for this Jira

          Concern:-  Guest user Login This should be candidate name or email.

          Cause:- We use default user to login functionality in the case where the user is not registered into the system but the document is sent to him to review & sign.

          Correction:-In such scenario's we are retrieving the user's Username / Email from the person table only if the user is not registered & he has the sent document for review.

          Rohan J Khandave  I will be raising a PR for this once I am done with writing my unit test cases for changes.

          PFA:- Affected Files 

           

          Thanks,

          Akash Thakur

          Swapnil Pandhare Rohan J Khandave Samir

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - - edited Hi All, Please Find below 3'Cs for this Jira Concern :-  Guest user Login This should be candidate name or email. Cause :- We use default user to login functionality  in the case where the user is not registered into the system but the document is sent to him to review & sign. Correction :-In such scenario's we are retrieving the user's Username / Email from the person table only if the user is not registered & he has the sent document for review. Rohan J Khandave   I will be raising a PR for this once I am done with writing my unit test cases for changes. PFA:- Affected Files    Thanks, Akash Thakur Swapnil Pandhare Rohan J Khandave Samir
          Hide
          akash.thakur Akash Thakur (Inactive) added a comment - - edited

          hi Harshveer Singh,

          I am done with code fix changes & unit test cases for changes made into code please proceed with code review & suggest changes if any required. I have raised PR for the same.

          PR:- https://github.com/cbdr/DMS/pull/623
          Thanks,
          Akash Thakur

          Ganesh Sadawarte

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - - edited hi Harshveer Singh , I am done with code fix changes & unit test cases for changes made into code please proceed with code review & suggest changes if any required. I have raised PR for the same. PR:- https://github.com/cbdr/DMS/pull/623 Thanks, Akash Thakur Ganesh Sadawarte
          Hide
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          verified on preproduction.
          Login - guest user

          Issue is fixed.
          Now for guest user, candidate email is populating

          Closing this ticket

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande

          Thanks,
          Jayshree

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - verified on preproduction. Login - guest user Issue is fixed. Now for guest user, candidate email is populating Closing this ticket Priya Dhamande Sachin Hingole Hrishikesh Deshpande Thanks, Jayshree

            People

            Assignee:
            akash.thakur Akash Thakur (Inactive)
            Reporter:
            narendra.kumar Narendra Kumar
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 12h
                12h
                Remaining:
                Time Spent - 7h Remaining Estimate - 5h
                5h
                Logged:
                Time Spent - 7h Remaining Estimate - 5h
                7h