Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1480

Guest user - This should be candidate name or email.

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: CBAT Offer Letter - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      In logout drop down it's showing the Guest User. It should be the candidate name if available otherwise it should be candidate email.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          narendra.kumar Narendra Kumar created issue -
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Field Original Value New Value
          Remaining Estimate 12h [ 43200 ]
          Original Estimate 12h [ 43200 ]
          samir Samir made changes -
          Assignee Samir [ samir ] Akash Thakur [ akash.thakur ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          Permalink
          akash.thakur Akash Thakur (Inactive) logged work - 12/Jun/19 07:17 AM
          • Time Spent:
            5.5h
             

            Analysis.

            Discussion with Rohan.

            Debugging.

            root cause finding/R&D

            Code Fix.

            Code Merge.

            Unit Testing.

             

          akash.thakur Akash Thakur (Inactive) made changes -
          Remaining Estimate 12h [ 43200 ] 6.5h [ 23400 ]
          Time Spent 5.5h [ 19800 ]
          Worklog Id 182832 [ 182832 ]
          Hide
          Permalink
          akash.thakur Akash Thakur (Inactive) added a comment - - edited

          Hi All,

          Please Find below 3'Cs for this Jira

          Concern:-  Guest user Login This should be candidate name or email.

          Cause:- We use default user to login functionality in the case where the user is not registered into the system but the document is sent to him to review & sign.

          Correction:-In such scenario's we are retrieving the user's Username / Email from the person table only if the user is not registered & he has the sent document for review.

          Rohan J Khandave  I will be raising a PR for this once I am done with writing my unit test cases for changes.

          PFA:- Affected Files 

           

          Thanks,

          Akash Thakur

          Swapnil Pandhare Rohan J Khandave Samir

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - - edited Hi All, Please Find below 3'Cs for this Jira Concern :-  Guest user Login This should be candidate name or email. Cause :- We use default user to login functionality  in the case where the user is not registered into the system but the document is sent to him to review & sign. Correction :-In such scenario's we are retrieving the user's Username / Email from the person table only if the user is not registered & he has the sent document for review. Rohan J Khandave   I will be raising a PR for this once I am done with writing my unit test cases for changes. PFA:- Affected Files    Thanks, Akash Thakur Swapnil Pandhare Rohan J Khandave Samir
          akash.thakur Akash Thakur (Inactive) made changes -
          Attachment DMS_1480_AFFECTED_FILES.txt [ 110246 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Assignee Akash Thakur [ akash.thakur ] Rohan J Khandave [ rohan.khandave ]
          Hide
          Permalink
          akash.thakur Akash Thakur (Inactive) added a comment - - edited

          hi Harshveer Singh,

          I am done with code fix changes & unit test cases for changes made into code please proceed with code review & suggest changes if any required. I have raised PR for the same.

          PR:- https://github.com/cbdr/DMS/pull/623
          Thanks,
          Akash Thakur

          Ganesh Sadawarte

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - - edited hi Harshveer Singh , I am done with code fix changes & unit test cases for changes made into code please proceed with code review & suggest changes if any required. I have raised PR for the same. PR:- https://github.com/cbdr/DMS/pull/623 Thanks, Akash Thakur Ganesh Sadawarte
          Permalink
          akash.thakur Akash Thakur (Inactive) logged work - 13/Jun/19 01:33 AM
          • Time Spent:
            1h
             

            test cases.
            internal code review.
            code merge.
            PR creation etc

          akash.thakur Akash Thakur (Inactive) made changes -
          Remaining Estimate 6.5h [ 23400 ] 5.5h [ 19800 ]
          Time Spent 5.5h [ 19800 ] 6.5h [ 23400 ]
          Worklog Id 182982 [ 182982 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Assignee Rohan J Khandave [ rohan.khandave ] Harshveer Singh [ harshveer.singh ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Harshveer Singh [ harshveer.singh ] Samir [ samir ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 5 [ 164 ] DMS - Fall Sprint 5, DMS - Fall Sprint 6 [ 164, 165 ]
          samir Samir made changes -
          Assignee Samir [ samir ] Priya Dhamande [ priya.dhamande ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Jayshree Nagpure [ jayshree.nagpure ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Attachment 1480.jpg [ 111317 ]
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 26/Jun/19 06:41 AM
          • Time Spent:
            0.5h
             

            testing

          Hide
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          verified on preproduction.
          Login - guest user

          Issue is fixed.
          Now for guest user, candidate email is populating

          Closing this ticket

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande

          Thanks,
          Jayshree

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - verified on preproduction. Login - guest user Issue is fixed. Now for guest user, candidate email is populating Closing this ticket Priya Dhamande Sachin Hingole Hrishikesh Deshpande Thanks, Jayshree
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Remaining Estimate 5.5h [ 19800 ] 5h [ 18000 ]
          Time Spent 6.5h [ 23400 ] 7h [ 25200 ]
          Worklog Id 185287 [ 185287 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Akash Thakur [ akash.thakur ]
          Transition Time In Source Status Execution Times
          Akash Thakur (Inactive) made transition -
          To Do In Progress
          		4d 22h 59m 1
          Akash Thakur (Inactive) made transition -
          In Progress Code Review
          		1d 3h 53m 1
          Raj Hawaldar (Inactive) made transition -
          Code Review In QA Testing
          		1d 3h 14m 1
          Jayshree Nagpure (Inactive) made transition -
          In QA Testing Done
          		12d 1h 58m 1

            People

            Assignee:
            akash.thakur Akash Thakur (Inactive)
            Reporter:
            narendra.kumar Narendra Kumar
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 12h
                12h
                Remaining:
                Time Spent - 7h Remaining Estimate - 5h
                5h
                Logged:
                Time Spent - 7h Remaining Estimate - 5h
                7h