Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1658

Manage Permissions | "Required" field UI dissorted & logo sanitization & company list sorting

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Enhancements - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      1.Login with Admin
      2.Manage Permission > Observe that Required fields UI is dissorted

      Expected Result : "Required" field should be proper

        Attachments

        1. Screenshot (3460).png
          Screenshot (3460).png
          163 kB
        2. UI.jpg
          UI.jpg
          144 kB

          Activity

          Hide
          akash.thakur Akash Thakur (Inactive) added a comment -

          Hi All,

          We have given a fix for the above issue along with this we have also covered some discovered issues such as

          • logo sanitization in the system.
          • company list sorting.
          • Manage permission buttons are moved outside of scroll.

          PR has been raised under DMS-1658 branch & also we have unit tested all the changes. working well Narendra Kumar please proceed with the review & let us know if any changes are required

          Thanks,

          Akash Thakur

          Samir Ganesh Sadawarte Rohan J Khandave Priya Dhamande Jayshree Nagpure 

           

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - Hi All, We have given a fix for the above issue along with this we have also covered some discovered issues such as logo sanitization in the system. company list sorting. Manage permission buttons are moved outside of scroll. PR has been raised under DMS-1658 branch & also we have unit tested all the changes. working well Narendra Kumar please proceed with the review & let us know if any changes are required Thanks, Akash Thakur Samir Ganesh Sadawarte Rohan J Khandave Priya Dhamande Jayshree Nagpure    
          Hide
          akash.thakur Akash Thakur (Inactive) added a comment -

          Please find 3'cs for the above bug

          Concern:-.Manage Permissions Required fields UI is distorted & logo disappearing intermittently.

          Cause:- minor UI was impacted for ongoing changes in CSS getting deployed & for logo its base64 was getting modifying before rendering so it was getting value as unsafe. 

          correction:- we have given code fix for all points.

          Thanks,

          Akash Thakur

          Samir Ganesh Sadawarte Rohan J Khandave Priya Dhamande Jayshree Nagpure 

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - Please find 3'cs for the above bug Concern :-.Manage Permissions Required fields UI is distorted & logo disappearing intermittently. Cause :- minor UI was impacted for ongoing changes in CSS getting deployed & for logo its base64 was getting modifying before rendering so it was getting value as unsafe.  correction :- we have given code fix for all points. Thanks, Akash Thakur Samir   Ganesh Sadawarte   Rohan J Khandave   Priya Dhamande   Jayshree Nagpure  
          Hide
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: Production
          Login: Admin
          Browser: FF and Chrome

          Now, the r of Manage permission popup is wrapped as expected.
          Refer screen capture. So, marking jira done.

          Ganesh Sadawarte Sachin HingoleHrishikesh Deshpande Rohan J Khandave Samir

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Production Login: Admin Browser: FF and Chrome Now, the r of Manage permission popup is wrapped as expected. Refer screen capture. So, marking jira done. Ganesh Sadawarte Sachin Hingole Hrishikesh Deshpande Rohan J Khandave Samir

            People

            Assignee:
            priya.dhamande Priya Dhamande (Inactive)
            Reporter:
            jayshree.nagpure Jayshree Nagpure (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 10h
                10h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10h
                10h