Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1658

Manage Permissions | "Required" field UI dissorted & logo sanitization & company list sorting

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Enhancements - Fall
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      1.Login with Admin
      2.Manage Permission > Observe that Required fields UI is dissorted

      Expected Result : "Required" field should be proper

        Attachments

        1. Screenshot (3460).png
          Screenshot (3460).png
          163 kB
        2. UI.jpg
          UI.jpg
          144 kB

          Activity

          Ascending order - Click to sort in descending order
          jayshree.nagpure Jayshree Nagpure (Inactive) created issue -
          samir Samir made changes -
          Field Original Value New Value
          Fix Version/s Enhancements - Fall [ 10610 ]
          samir Samir made changes -
          Sprint DMS - Fall Sprint 8 [ 167 ]
          samir Samir made changes -
          Assignee Samir [ samir ] Akash Thakur [ akash.thakur ]
          samir Samir made changes -
          Remaining Estimate 6h [ 21600 ]
          Original Estimate 6h [ 21600 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          Permalink
          akash.thakur Akash Thakur (Inactive) logged work - 22/Jul/19 05:56 AM
          • Time Spent:
            3h
             

            testing.

            code fix.

            testing on all screen size.

            code merge.

            etc 

          akash.thakur Akash Thakur (Inactive) made changes -
          Remaining Estimate 6h [ 21600 ] 3h [ 10800 ]
          Time Spent 3h [ 10800 ]
          Worklog Id 190464 [ 190464 ]
          Permalink
          namrata.kakade Namrata Kakade (Inactive) logged work - 22/Jul/19 05:06 PM
          • Time Spent:
            0.5h
             

            Integration support

          namrata.kakade Namrata Kakade (Inactive) made changes -
          Remaining Estimate 3h [ 10800 ] 2.5h [ 9000 ]
          Time Spent 3h [ 10800 ] 3.5h [ 12600 ]
          Worklog Id 190620 [ 190620 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Summary Manage Permissions | "Required" field UI dissorted Manage Permissions | "Required" field UI dissorted & logo sanitization & company list sorting
          Permalink
          akash.thakur Akash Thakur (Inactive) logged work - 23/Jul/19 03:28 AM
          • Time Spent:
            6h
             
            • analysis.
            • clubbed other issues which were discovered.
            • development.
            • incall discussions.
            • code review.
            • code merge.
            • team discussions.
            • testing.
          akash.thakur Akash Thakur (Inactive) made changes -
          Remaining Estimate 2.5h [ 9000 ] 0h [ 0 ]
          Time Spent 3.5h [ 12600 ] 9.5h [ 34200 ]
          Worklog Id 190724 [ 190724 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Original Estimate 6h [ 21600 ] 10h [ 36000 ]
          akash.thakur Akash Thakur (Inactive) made changes -
          Assignee Akash Thakur [ akash.thakur ] Narendra Kumar [ narendra.kumar ]
          Hide
          Permalink
          akash.thakur Akash Thakur (Inactive) added a comment -

          Hi All,

          We have given a fix for the above issue along with this we have also covered some discovered issues such as

          • logo sanitization in the system.
          • company list sorting.
          • Manage permission buttons are moved outside of scroll.

          PR has been raised under DMS-1658 branch & also we have unit tested all the changes. working well Narendra Kumar please proceed with the review & let us know if any changes are required

          Thanks,

          Akash Thakur

          Samir Ganesh Sadawarte Rohan J Khandave Priya Dhamande Jayshree Nagpure 

           

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - Hi All, We have given a fix for the above issue along with this we have also covered some discovered issues such as logo sanitization in the system. company list sorting. Manage permission buttons are moved outside of scroll. PR has been raised under DMS-1658 branch & also we have unit tested all the changes. working well Narendra Kumar please proceed with the review & let us know if any changes are required Thanks, Akash Thakur Samir Ganesh Sadawarte Rohan J Khandave Priya Dhamande Jayshree Nagpure    
          Hide
          Permalink
          akash.thakur Akash Thakur (Inactive) added a comment -

          Please find 3'cs for the above bug

          Concern:-.Manage Permissions Required fields UI is distorted & logo disappearing intermittently.

          Cause:- minor UI was impacted for ongoing changes in CSS getting deployed & for logo its base64 was getting modifying before rendering so it was getting value as unsafe. 

          correction:- we have given code fix for all points.

          Thanks,

          Akash Thakur

          Samir Ganesh Sadawarte Rohan J Khandave Priya Dhamande Jayshree Nagpure 

          Show
          akash.thakur Akash Thakur (Inactive) added a comment - Please find 3'cs for the above bug Concern :-.Manage Permissions Required fields UI is distorted & logo disappearing intermittently. Cause :- minor UI was impacted for ongoing changes in CSS getting deployed & for logo its base64 was getting modifying before rendering so it was getting value as unsafe.  correction :- we have given code fix for all points. Thanks, Akash Thakur Samir   Ganesh Sadawarte   Rohan J Khandave   Priya Dhamande   Jayshree Nagpure  
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Assignee Narendra Kumar [ narendra.kumar ] Priya Dhamande [ priya.dhamande ]
          Permalink
          priya.dhamande Priya Dhamande (Inactive) logged work - 25/Jul/19 05:17 AM
          • Time Spent:
            0.5h
             

            Prod testing

          Hide
          Permalink
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: Production
          Login: Admin
          Browser: FF and Chrome

          Now, the r of Manage permission popup is wrapped as expected.
          Refer screen capture. So, marking jira done.

          Ganesh Sadawarte Sachin HingoleHrishikesh Deshpande Rohan J Khandave Samir

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Production Login: Admin Browser: FF and Chrome Now, the r of Manage permission popup is wrapped as expected. Refer screen capture. So, marking jira done. Ganesh Sadawarte Sachin Hingole Hrishikesh Deshpande Rohan J Khandave Samir
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Attachment Screenshot (3460).png [ 114442 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 9.5h [ 34200 ] 10h [ 36000 ]
          Worklog Id 191306 [ 191306 ]
          Transition Time In Source Status Execution Times
          Akash Thakur (Inactive) made transition -
          To Do In Progress
          		5d 5h 14m 1
          Akash Thakur (Inactive) made transition -
          In Progress Code Review
          		23h 55m 1
          Raj Hawaldar (Inactive) made transition -
          Code Review In QA Testing
          		23h 13m 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing Done
          		1d 2h 30m 1

            People

            Assignee:
            priya.dhamande Priya Dhamande (Inactive)
            Reporter:
            jayshree.nagpure Jayshree Nagpure (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 10h
                10h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10h
                10h