Details

    • Type: Bug
    • Status: Done
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Integration with CBAT
    • Labels:
      None

      Description

      Objective

      There are a few items on the DMS that were identified to be addressed for the DMS-CBAT integration. This includes the Template Creation screens used in Document and Offer letter creation.

      Requirements:

      1. Alphabetize the order of Fields from A to Z / 0-9 for System Fields
        • Means that after Z, then show any numbers order 0-9
      2. Change Given.Name to First.Name
      3. When creating an Offer Letter Template, automatically have "Offer Letter" selected for the Template Type field
      4. Remove the Document Source field from all Templates (Documents and Offer Letter)

        Attachments

          Activity

          Robert.Malony Robert Malony (Inactive) created issue -
          Robert.Malony Robert Malony (Inactive) made changes -
          Field Original Value New Value
          Epic Link DMS-473 [ 75966 ]
          Hide
          Robert.Malony Robert Malony (Inactive) added a comment -

          Hi all,

          Made this list during our call.

          -Robert

          cc: Ravi Banda and ShashiKant Mishra

          Show
          Robert.Malony Robert Malony (Inactive) added a comment - Hi all, Made this list during our call. -Robert cc: Ravi Banda and ShashiKant Mishra
          samir Samir made changes -
          Assignee Samir [ samir ] Ramya Tantry [ ramya.tantry ]
          samir Samir made changes -
          Sprint DMS - Gap Fall & Win Sprint 2 [ 174 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 29/Aug/19 05:38 AM
          • Time Spent:
            3h
             

            Analysis

            Code changes

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 0h [ 0 ]
          Time Spent 3h [ 10800 ]
          Worklog Id 197759 [ 197759 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status In Progress [ 3 ] On Hold [ 10507 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 30/Aug/19 02:01 AM
          • Time Spent:
            2h
             

            Code changes

            Unit testing

          Hide
          ramya.tantry Ramya Tantry (Inactive) added a comment -

          Changes related to point 1 done. Need discussion wIth Samir for other points,hence keeping it on hold.

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - Changes related to point 1 done. Need discussion wIth Samir for other points,hence keeping it on hold.
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Time Spent 3h [ 10800 ] 5h [ 18000 ]
          Worklog Id 197949 [ 197949 ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Gap Fall & Win Sprint 2 [ 174 ] DMS - Gap Fall & Win Sprint 2, DMS - Gap Fall & Win Sprint 3 [ 174, 177 ]
          samir Samir made changes -
          Status On Hold [ 10507 ] To Do [ 10000 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 03/Sep/19 12:22 AM
          • Time Spent:
            2h
             

            Discussion and Code changes

            Jira Updation

          Hide
          ramya.tantry Ramya Tantry (Inactive) added a comment -

          Below are the status of the requirements specified :

          1. Alphabetize the order of Fields from A to Z / 0-9 for System Fields : Means that after Z, then show any numbers order 0-9 [ Changes done under this JIRA ]
          2.  When creating an Offer Letter Template, automatically have "Offer Letter" selected for the Template Type field [ Changes done under DMS- 1766]
          3. Remove the Document Source field from all Templates (Documents and Offer Letter) [ Changes done under DMS- 1766]

          Robert Malony : Need your input on below point.

          Change Given.Name to First.Name 

          The system field for given name is Person.Given Name and there is a different field present for first name as Person.First Name. Could you please elaborate on which fields need to be changed.

          Files Affected :
          DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\DocumentData.cs

          CC :Samir,Rohan J Khandave,Priya Dhamande

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - Below are the status of the requirements specified : Alphabetize the order of Fields from A to Z / 0-9 for  System Fields : Means that after Z, then show any numbers order 0-9 [ Changes done under this JIRA ]  When creating an Offer Letter Template, automatically have "Offer Letter" selected for the  Template Type  field  [ Changes done under DMS- 1766] Remove the  Document Source  field from all Templates (Documents and Offer Letter)   [ Changes done under DMS- 1766] Robert Malony  : Need your input on below point. Change Given.Name to First.Name  The system field for given name is Person.Given Name and there is a different field present for first name as Person.First Name. Could you please elaborate on which fields need to be changed. Files Affected : DMS\DMS.App\src\DMS_AppLogic\BuisnessLogic\DocumentData.cs CC : Samir , Rohan J Khandave , Priya Dhamande
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status To Do [ 10000 ] Code Review [ 11801 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Time Spent 5h [ 18000 ] 7h [ 25200 ]
          Worklog Id 198188 [ 198188 ]
          Hide
          Robert.Malony Robert Malony (Inactive) added a comment -

          Hi Ramya Tantry,

          Adding in Ravi Banda as this was feedback that was captured during the a Fall 2019 Beta meeting. But my recollection is that people in the US do not fully understand "Given Name", rather "First Name". The ask in this requirement was more to ensure that Given name was either 1) changed to First Name or 2) hidden as to not cause confusion.

          Thanks,
          Robert

          cc: Samir, Rohan J Khandave, and Priya Dhamande

          Show
          Robert.Malony Robert Malony (Inactive) added a comment - Hi Ramya Tantry , Adding in Ravi Banda as this was feedback that was captured during the a Fall 2019 Beta meeting. But my recollection is that people in the US do not fully understand "Given Name", rather "First Name". The ask in this requirement was more to ensure that Given name was either 1) changed to First Name or 2) hidden as to not cause confusion. Thanks, Robert cc: Samir , Rohan J Khandave , and Priya Dhamande
          Ashish.Durani Ashish Durani made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Ashish.Durani Ashish Durani made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Priya Dhamande [ priya.dhamande ]
          priya.dhamande Priya Dhamande (Inactive) logged work - 03/Sep/19 11:24 PM
          • Time Spent:
            0.5h
             

            Analysis
            Preprod verification

          Hide
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: Preprod
          Login: Admin
          Browser: FF and Chrome

          Issues verified:
          1. Alphabetize the order of Fields from A to Z / 0-9 for System Fields : Means that after Z, then show any numbers order 0-9 - Pass
          2. Remove the Document Source field from all Templates (Documents and Offer Letter) when CBAT selected as Source Product. - Pass

          Ramya Tantry, check for above comments. Assigning for implementing First Name change.

          Samir Sachin Hingole Hrishikesh Deshpande Rohan J Khandave

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Preprod Login: Admin Browser: FF and Chrome Issues verified: 1. Alphabetize the order of Fields from A to Z / 0-9 for System Fields : Means that after Z, then show any numbers order 0-9 - Pass 2. Remove the Document Source field from all Templates (Documents and Offer Letter) when CBAT selected as Source Product. - Pass Ramya Tantry , check for above comments. Assigning for implementing First Name change. Samir Sachin Hingole Hrishikesh Deshpande Rohan J Khandave
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Status In QA Testing [ 11901 ] To Do [ 10000 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Ramya Tantry [ ramya.tantry ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Time Spent 7h [ 25200 ] 7.5h [ 27000 ]
          Worklog Id 198390 [ 198390 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          ramya.tantry Ramya Tantry (Inactive) logged work - 04/Sep/19 02:22 AM
          • Time Spent:
            1h
             

            Discussion with Samir

            Changes on All environments.

          Hide
          ramya.tantry Ramya Tantry (Inactive) added a comment -

          Hi Priya Dhamande,

          As per discussion with Samir, changed Person.Given Name label to Person.First Name. Also have updated the description of that field to "Person.First Name is equivalent to Person.Given Name". Please verify on Pre-prod and Prod.

          CC:Rohan J Khandave,Samir

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Priya Dhamande , As per discussion with Samir, changed Person.Given Name label to Person.First Name. Also have updated the description of that field to "Person.First Name is equivalent to Person.Given Name". Please verify on Pre-prod and Prod. CC: Rohan J Khandave , Samir
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Status In Progress [ 3 ] In QA Testing [ 11901 ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Assignee Ramya Tantry [ ramya.tantry ] Priya Dhamande [ priya.dhamande ]
          ramya.tantry Ramya Tantry (Inactive) made changes -
          Time Spent 7.5h [ 27000 ] 8.5h [ 30600 ]
          Worklog Id 198415 [ 198415 ]
          Hide
          priya.dhamande Priya Dhamande (Inactive) added a comment -

          Environment: Prod
          Login: Admin
          File Type: PDF, TEXT and HTML
          Browser: FF and Chrome

          The name is changed as expected.
          Refer screen capture. So, marking jira done.

          Samir Rohan J KhandaveSachin Hingole

          Show
          priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Prod Login: Admin File Type: PDF, TEXT and HTML Browser: FF and Chrome The name is changed as expected. Refer screen capture. So, marking jira done. Samir Rohan J Khandave Sachin Hingole
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Robert Malony [ robert.malony ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status In QA Testing [ 11901 ] Done [ 10001 ]
          Transition Time In Source Status Execution Times
          Ramya Tantry (Inactive) made transition -
          In Progress On Hold
          1d 2h 22m 1
          Samir made transition -
          On Hold To Do
          3d 19h 29m 1
          Ramya Tantry (Inactive) made transition -
          To Do Code Review
          2h 53m 1
          Ashish Durani made transition -
          Code Review In QA Testing
          5h 19m 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing To Do
          17h 41m 1
          Ramya Tantry (Inactive) made transition -
          To Do In Progress
          20d 12h 4m 2
          Ramya Tantry (Inactive) made transition -
          In Progress In QA Testing
          18m 35s 1
          Priya Dhamande (Inactive) made transition -
          In QA Testing Done
          7d 23h 14m 1

            People

            Assignee:
            Robert.Malony Robert Malony (Inactive)
            Reporter:
            Robert.Malony Robert Malony (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 8.5h
                8.5h