Hi Rohan J Khandave,

As per our discussions, I have corrected the unit & integration test but was not able to test this test cases due to object disposed error for _context please request you to look into this & let us know to continue the testing.

Thanks,

Akash Thakur

Sonali Farakate Ramya Tantry Raj Hawaldar Ganesh Sadawarte Harshveer Singh

Akash Thakur, Rohan J Khandave Sonali Farakate Ramya Tantry Raj Hawaldar Ganesh Sadawarte Harshveer Singh refer to this PR for fix for _context disposing issue. https://github.com/cbdr/DMS/pull/886

https://github.com/cbdr/DMS/pull/886

Concern: Dependencies resolved by DependencyResolverHelpercs are disposing as soon as they are created.

Cause: DependencyResolverHelpercs.GetService method is creating new Scope for each service it needs to resolve, getting dependency from that scope, and immediately disposing newly created scope, because of which all services resolved within that scope are getting disposed.

Correction: Do not create new scope for each dependency needed, also do not dispose scope immediately.

Changes done in DMSUserControllerTest.cs

• public void Post_ShouldLogoutUser() : 
  parameter passed to function LogoutUser() was string, updated this to UserDto object.
  Assert was not working for this hence changed.

• public void Post_ShouldNotLogoutUser() : 
  parameter passed to function LogoutUser() was string, updated this to UserDto object.
  Assert was not working for this hence changed.

• Post_ShouldRetrieve_FirstNameForActualUser() : 
  Assert statement was giving warning hence changed.

• NOTE : Remaining hard coded values(username, password and usertypeID) updated as per pre-prod database.

CC : Rohan J Khandave

Changes done in GenerateDocumentControllerTest.cs (all test run successfully)

• Moved API URL to constants avoided duplicate string everywhere.

• Resolved correct dependencies for GenerateDocumentController & removed unused services.

• Removed outdated hardcoded Authorization header values replaced to constants.

• NOTE: Remaining hardcoded values(Person identity, source product, template ID) updated as per pre-prod database.

CC : Rohan J Khandave Harshveer Singh Samir

Changes completed in CandidateProfileControllerTest.

• Removed outdated data from TestSuite.
• Hardcoded values updated as per the Pre-Production Database.
• Parameters added to getDocumentDto(bool flag).
• StaticFunctions.GetDBContext() is used.

All test are running for CandidateProfileController.
Regards,
Raj

• Changes done in CandidateProfileTests.cs
  Mock data was missing for document, documentTemplate, person, users. So added mock data for these tables.
  Following mock routines added :

1. GetPersonIdFromEmail
2. GetTemplateFieldDetails

• Changes done in  ProvisioningAPILogicTests
  Changes in unit test parameters.

Thanks,
Sonali Farakate

Changes done in ProvisioningApiTest

1. Authentication changes for all test cases written
2. Removed comments 
3. Removed unnecessary usings
4. Removed unnecessary functions created.
5. Created different input objects for Insert update testcases.

All 18 test cases are running for ProvisioningApiTest

CC: Rohan J Khandave

Done with test case changes. Please take latest of DMS-1900 branch.

No QA inputs required. So, marking jira done.

Rohan J Khandave Samir Ramya Tantry Sachin Hingole Hrishikesh Deshpande