-
Type:
Bug
-
Status: Done
-
Priority:
High
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: Winter 2020 CBAT Integration
-
Labels:None
-
Company:All Clients/Multiple Clients
Overview
Cutting off the bottom of Edit email template section.
Entry Criteria:
- User enters into Edit Email Template.
Acceptance Criteria:
- When the page loads, the callback attached returns the height of the page without including the email template height as the contents are not loaded till then.
- An API call is made which fetches the email template data. After loading the data the page height is increased and the cutting of bottom is removed.
- A loader should be shown till the time API is not returning the template data.
Exit Criteria:
1. The page should be shown completely when the loader hides without any cutting off the bottom border.
I tested this issue and found that it is not happening always. So I'm not able to fix this. Also, I want to test this at your side so that I can check the value coming through the callback. It may be the case value coming from the callback not rendering the height on the iframe.
Let me know when can we do this?
cc: Ravi Banda, Samir
Thanks
Narendra
I have fixed this issue. Today it will be deployed in the pre-prod environment. I'll update you once it will be in prod.
cc: Samir, Ravi Banda
Today its deployed in pre-production.
We are able to see loader now before email template page loads, but still some of the images on tmeplate are not loading. please refer attached video and let me know if this is expected for this JIRA.
Thanks
Prateek
CC: Samir
Prateek
added a comment - Hi Narendra Kumar
We are able to see loader now before email template page loads, but still some of the images on tmeplate are not loading. please refer attached video and let me know if this is expected for this JIRA.
Thanks
Prateek
CC: Samir Hello Prateek
Are there any new updates on this? I see that it's still in the "testing" status, and the last comment on this was made 5 days ago.
CC: Samir, Narendra Kumar
Thank you!
Hi Prateek
You are testing different things. Just discuss it with Shamooka Mohapatra once. It's related to scroll height. On CBAT side, this page sometimes does not have a scroll bar to scroll down the page. And this thing is fixed.
Farah Obaidullah, this issue is fixed and deployed on the pre-prod environment. Most probably it will be deployed on prod tomorrow.
Thanks
Narendra
It's now deployed on the production environment. Can you please check this and confirm if it is working fine or not?
Narendra Kumar Now it is working perfectly. 
Shamooka Mohapatra (Inactive)
added a comment - Narendra Kumar Now it is working perfectly. 
Hi Samir
Currently trying to solve this from the CKEditor side. Like if we could be able to get any event to inform the content is now fully loaded in the editor then we can easily resolve this issue otherwise we have to enable the DMS loader manually.
I will update you soon about the approach I'm going to use to solve this issue.
cc: Shamooka Mohapatra