[DMS-2005] Allow loader to show till the page loads completely in Edit Email Template - Workterra Jira

Details

Type: Bug
Status: Done
Priority: High
Resolution: Done
Affects Version/s: None
Fix Version/s: Winter 2020 CBAT Integration
Labels:
None

Company:
All Clients/Multiple Clients

Description

Overview

Cutting off the bottom of Edit email template section.

Entry Criteria:

User enters into Edit Email Template.

Acceptance Criteria:

When the page loads, the callback attached returns the height of the page without including the email template height as the contents are not loaded till then.
An API call is made which fetches the email template data. After loading the data the page height is increased and the cutting of bottom is removed.
A loader should be shown till the time API is not returning the template data.

Exit Criteria:

1. The page should be shown completely when the loader hides without any cutting off the bottom border.

cc - Shamooka Mohapatra Amrendra Kumar

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

image001.jpg
38 kB
19/Nov/19 01:24 AM
Email template_loader.webm
9.31 MB
09/Jan/20 04:36 AM

Activity

Ascending order - Click to sort in descending order

Mohd Belal (Inactive) created issue - 19/Nov/19 01:25 AM

Mohd Belal (Inactive) made changes - 19/Nov/19 01:52 AM

Field	Original Value	New Value
Description	h2. Overview Cutting off the bottom of Edit email template section. h3. Entry Criteria: # User enters into Edit Email Template. h3. Acceptance Criteria: # When the page loads, the callback attached returns the height of the page without including the email template height as the contents are not loaded till then. # An API call is made which fetches the email template data. After loading the data the page height is increased and the cutting of bottom is removed. # A loader should be shown till the time API is not returning the template data. h3. Exit Criteria: 1. The page should be shown completely when the loader hides without any cutting off the bottom border.	h2. Overview Cutting off the bottom of Edit email template section. h3. Entry Criteria: # User enters into Edit Email Template. h3. Acceptance Criteria: # When the page loads, the callback attached returns the height of the page without including the email template height as the contents are not loaded till then. # An API call is made which fetches the email template data. After loading the data the page height is increased and the cutting of bottom is removed. # A loader should be shown till the time API is not returning the template data. h3. Exit Criteria: 1. The page should be shown completely when the loader hides without any cutting off the bottom border. cc - [~Shamooka.Mohapatra] [~Amrendra]

Narendra Kumar made changes - 08/Dec/19 08:45 PM

Sprint		Winter-2020 Sprint 5 [ 189 ]
Remaining Estimate		8h [ 28800 ]
Original Estimate		8h [ 28800 ]

Narendra Kumar made changes - 08/Dec/19 09:50 PM

Assignee

Samir [ samir ]

Narendra Kumar [ narendra.kumar ]

Narendra Kumar made changes - 09/Dec/19 01:28 AM

Status

To Do [ 10000 ]

In Progress [ 3 ]

Permalink

Narendra Kumar logged work - 09/Dec/19 03:41 AM

Time Spent:

4h

Tried implementing an event listener of CKEditor.

Narendra Kumar made changes - 09/Dec/19 08:42 PM

Remaining Estimate	8h [ 28800 ]	4h [ 14400 ]
Time Spent		4h [ 14400 ]
Worklog Id	216401 [ 216401 ]

Hide

Permalink

Narendra Kumar added a comment - 11/Dec/19 11:25 PM - edited

Hi Samir

Currently trying to solve this from the CKEditor side. Like if we could be able to get any event to inform the content is now fully loaded in the editor then we can easily resolve this issue otherwise we have to enable the DMS loader manually.

I will update you soon about the approach I'm going to use to solve this issue.

cc: Shamooka Mohapatra

Show

Narendra Kumar added a comment - 11/Dec/19 11:25 PM - edited Hi Samir Currently trying to solve this from the CKEditor side. Like if we could be able to get any event to inform the content is now fully loaded in the editor then we can easily resolve this issue otherwise we have to enable the DMS loader manually. I will update you soon about the approach I'm going to use to solve this issue. cc: Shamooka Mohapatra

Hide

Permalink

Narendra Kumar added a comment - 16/Dec/19 08:30 PM - edited

Hi Shamooka Mohapatra

I tested this issue and found that it is not happening always. So I'm not able to fix this. Also, I want to test this at your side so that I can check the value coming through the callback. It may be the case value coming from the callback not rendering the height on the iframe.

Let me know when can we do this?

cc: Ravi Banda, Samir

Thanks

Narendra

Show

Narendra Kumar added a comment - 16/Dec/19 08:30 PM - edited Hi Shamooka Mohapatra I tested this issue and found that it is not happening always. So I'm not able to fix this. Also, I want to test this at your side so that I can check the value coming through the callback. It may be the case value coming from the callback not rendering the height on the iframe. Let me know when can we do this? cc: Ravi Banda , Samir Thanks Narendra

Narendra Kumar made changes - 19/Dec/19 03:02 AM

Assignee

Narendra Kumar [ narendra.kumar ]

Shamooka Mohapatra [ shamooka.mohapatra ]

ShashiKant Mishra (Inactive) made changes - 22/Dec/19 08:36 PM

Sprint

Winter-2020 Sprint 5 [ 189 ]

Winter-2020 Sprint 5, Winter-2020 Sprint 6 [ 189, 190 ]

ShashiKant Mishra (Inactive) made changes - 05/Jan/20 08:38 PM

Sprint

Winter-2020 Sprint 5, Winter-2020 Sprint 6 [ 189, 190 ]

Winter-2020 Sprint 5, Winter-2020 Sprint 6, Winter-2020 Sprint 7 [ 189, 190, 193 ]

Narendra Kumar made changes - 05/Jan/20 10:02 PM

Assignee

Shamooka Mohapatra [ shamooka.mohapatra ]

Narendra Kumar [ narendra.kumar ]

Narendra Kumar made changes - 05/Jan/20 11:30 PM

Remaining Estimate	4h [ 14400 ]	0h [ 0 ]
Time Spent	4h [ 14400 ]	8h [ 28800 ]
Worklog Id	220001 [ 220001 ]

Hide

Permalink

Narendra Kumar added a comment - 05/Jan/20 11:31 PM

Hi Shamooka Mohapatra

I have fixed this issue. Today it will be deployed in the pre-prod environment. I'll update you once it will be in prod.

cc: Samir, Ravi Banda

Show

Narendra Kumar added a comment - 05/Jan/20 11:31 PM Hi Shamooka Mohapatra I have fixed this issue. Today it will be deployed in the pre-prod environment. I'll update you once it will be in prod. cc: Samir , Ravi Banda

Narendra Kumar made changes - 05/Jan/20 11:32 PM

Status

In Progress [ 3 ]

Code Review [ 11801 ]

Permalink

Narendra Kumar logged work - 06/Jan/20 12:37 AM

Time Spent:

4h

I had a discussion with Saurabh and fixed this issue.

Ashish Durani made changes - 08/Jan/20 10:57 PM

Status

Code Review [ 11801 ]

In QA Testing [ 11901 ]

Ashish Durani made changes - 08/Jan/20 10:58 PM

Assignee

Narendra Kumar [ narendra.kumar ]

Prateek [ prateeks ]

Hide

Permalink

Narendra Kumar added a comment - 08/Jan/20 11:12 PM

Hi Shamooka Mohapatra

Today its deployed in pre-production.

Show

Narendra Kumar added a comment - 08/Jan/20 11:12 PM Hi Shamooka Mohapatra Today its deployed in pre-production.

Permalink

Prateek logged work - 09/Jan/20 04:36 AM

Time Spent:

0.2h

<No comment>

Hide

Permalink

Prateek added a comment - 09/Jan/20 04:36 AM

Hi Narendra Kumar

We are able to see loader now before email template page loads, but still some of the images on tmeplate are not loading. please refer attached video and let me know if this is expected for this JIRA.

Thanks

Prateek

CC: Samir

Show

Prateek added a comment - 09/Jan/20 04:36 AM Hi Narendra Kumar We are able to see loader now before email template page loads, but still some of the images on tmeplate are not loading. please refer attached video and let me know if this is expected for this JIRA. Thanks Prateek CC: Samir

Prateek made changes - 09/Jan/20 04:36 AM

Attachment

Email template_loader.webm [ 131096 ]

Prateek made changes - 09/Jan/20 04:37 AM

Time Spent	8h [ 28800 ]	8.2h [ 29520 ]
Worklog Id	220734 [ 220734 ]

Prateek made changes - 09/Jan/20 04:37 AM

Status

In QA Testing [ 11901 ]

On hold in Test [ 10019 ]

Prateek made changes - 09/Jan/20 04:38 AM

Assignee

Prateek [ prateeks ]

Narendra Kumar [ narendra.kumar ]

Hide

Permalink

Farah Obaidullah (Inactive) added a comment - 14/Jan/20 08:25 AM

Hello Prateek

Are there any new updates on this? I see that it's still in the "testing" status, and the last comment on this was made 5 days ago.

CC: Samir, Narendra Kumar

Thank you!

Show

Farah Obaidullah (Inactive) added a comment - 14/Jan/20 08:25 AM Hello Prateek Are there any new updates on this? I see that it's still in the "testing" status, and the last comment on this was made 5 days ago. CC: Samir , Narendra Kumar Thank you!

Hide

Permalink

Narendra Kumar added a comment - 15/Jan/20 01:03 AM

Hi Prateek

You are testing different things. Just discuss it with Shamooka Mohapatra once. It's related to scroll height. On CBAT side, this page sometimes does not have a scroll bar to scroll down the page. And this thing is fixed.

Farah Obaidullah, this issue is fixed and deployed on the pre-prod environment. Most probably it will be deployed on prod tomorrow.

Thanks

Narendra

Show

Narendra Kumar added a comment - 15/Jan/20 01:03 AM Hi Prateek You are testing different things. Just discuss it with Shamooka Mohapatra once. It's related to scroll height. On CBAT side, this page sometimes does not have a scroll bar to scroll down the page. And this thing is fixed. Farah Obaidullah , this issue is fixed and deployed on the pre-prod environment. Most probably it will be deployed on prod tomorrow. Thanks Narendra

Hide

Permalink

Narendra Kumar added a comment - 15/Jan/20 09:37 PM

Hi Shamooka Mohapatra

It's now deployed on the production environment. Can you please check this and confirm if it is working fine or not?

Show

Narendra Kumar added a comment - 15/Jan/20 09:37 PM Hi Shamooka Mohapatra It's now deployed on the production environment. Can you please check this and confirm if it is working fine or not?

Narendra Kumar made changes - 15/Jan/20 09:37 PM

Status

On hold in Test [ 10019 ]

In Production Testing [ 10202 ]

Narendra Kumar made changes - 15/Jan/20 09:37 PM

Assignee

Narendra Kumar [ narendra.kumar ]

Shamooka Mohapatra [ shamooka.mohapatra ]

Hide

Permalink

Shamooka Mohapatra (Inactive) added a comment - 16/Jan/20 07:14 AM

Narendra Kumar Now it is working perfectly.

Show

Shamooka Mohapatra (Inactive) added a comment - 16/Jan/20 07:14 AM Narendra Kumar Now it is working perfectly.

Narendra Kumar made changes - 16/Jan/20 08:56 PM

Resolution		Done [ 10000 ]
Status	In Production Testing [ 10202 ]	Done [ 10001 ]

Narendra Kumar made changes - 16/Jan/20 08:56 PM

Assignee

Shamooka Mohapatra [ shamooka.mohapatra ]

Narendra Kumar [ narendra.kumar ]

Transition	Time In Source Status	Execution Times

Narendra Kumar made transition - 09/Dec/19 01:28 AM

To Do

In Progress

20d 3m

Narendra Kumar made transition - 05/Jan/20 11:32 PM

In Progress

Code Review

27d 22h 3m

Ashish Durani made transition - 08/Jan/20 10:57 PM

Code Review

In QA Testing

2d 23h 24m

Prateek made transition - 09/Jan/20 04:37 AM

In QA Testing

On hold in Test

5h 40m

Narendra Kumar made transition - 15/Jan/20 09:37 PM

On hold in Test

In Production Testing

6d 16h 59m

Narendra Kumar made transition - 16/Jan/20 08:56 PM

In Production Testing

Done

23h 19m

People

Assignee:: Narendra Kumar

Reporter:: Mohd Belal (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 19/Nov/19 01:25 AM

Updated:: 16/Jan/20 08:56 PM

Resolved:: 16/Jan/20 08:56 PM

Time Tracking

Estimated:

Remaining:

Logged:

8.2h