Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-668

DMS | Signature | Draw Signature | Submit Button

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Company:
      All Clients/Multiple Clients

      Description

      Environment: PreProd

      Is Signature not mandatory or not? as we can submit without adding Sign?

      Swapnil Pandhare Samir Narendra Kumar Ramya Tantry

        Attachments

          Issue Links

            Activity

            Hide
            narendra.kumar Narendra Kumar added a comment -

            Hi Samir and Swapnil Pandhare,

            Can you please put your comment on this?

            Show
            narendra.kumar Narendra Kumar added a comment - Hi Samir and Swapnil Pandhare , Can you please put your comment on this?
            Hide
            narendra.kumar Narendra Kumar added a comment - - edited

            Hi Samir 

            As we have discussed that we will place the validation of required signature based on the e-signature flag. But when I went through the code I found that I'm not getting the e-signature flag anywhere. So for this I discussed with Ramya Tantry. So based on discussion we need to modify some API so that I can get that flag. And then I could be able to put the validation on submit.

            Swapnil Pandhare can you please create a ticket for this and assign to someone.

             

            Thanks

            Narendra

            Show
            narendra.kumar Narendra Kumar added a comment - - edited Hi Samir   As we have discussed that we will place the validation of required signature based on the e-signature flag. But when I went through the code I found that I'm not getting the e-signature flag anywhere. So for this I discussed with Ramya Tantry . So based on discussion we need to modify some API so that I can get that flag. And then I could be able to put the validation on submit. Swapnil Pandhare can you please create a ticket for this and assign to someone.   Thanks Narendra
            Hide
            narendra.kumar Narendra Kumar added a comment -

            Hi Samir and Swapnil Pandhare

            I have configured a variable that will store the e-signature flag from API. Right now its hard coded to true.

            So now user are required to sign the document. If he do not sign and submit the doc. An error message will prompt that Signature is missing. Please sign the document.

            **Or you can suggest the error message. Also, I'll configure my variable with the API data once API will modified.

             

            Thanks 

            Narendra

            Show
            narendra.kumar Narendra Kumar added a comment - Hi Samir and Swapnil Pandhare I have configured a variable that will store the e-signature flag from API. Right now its hard coded to true. So now user are required to sign the document. If he do not sign and submit the doc. An error message will prompt that Signature is missing. Please sign the document. **Or you can suggest the error message. Also, I'll configure my variable with the API data once API will modified.   Thanks  Narendra
            Hide
            narendra.kumar Narendra Kumar added a comment -

            Hi Samir

            Based on discussion - You have created a separate ticket for implementing API. So moving it into Code Review.

             

            cc - Swapnil Pandhare

            Thanks

            Narendra

            Show
            narendra.kumar Narendra Kumar added a comment - Hi Samir Based on discussion - You have created a separate ticket for implementing API. So moving it into Code Review.   cc - Swapnil Pandhare Thanks Narendra
            Hide
            narendra.kumar Narendra Kumar added a comment -

            Hi Swapnil Pandhare

            Created PR with the current changes. API implementation will complete in another ticket.

             

            cc - Samir

            Thanks

            Narendra

            Show
            narendra.kumar Narendra Kumar added a comment - Hi Swapnil Pandhare Created PR with the current changes. API implementation will complete in another ticket.   cc - Samir Thanks Narendra
            Hide
            narendra.kumar Narendra Kumar added a comment -

            HI Ramya Tantry

            I have made the suggested changes. Now you can review PR for this task.

             

            Thanks

            Show
            narendra.kumar Narendra Kumar added a comment - HI Ramya Tantry I have made the suggested changes. Now you can review PR for this task.   Thanks
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Hi Narendra Kumar,
            I have approved the request and merged the changes.

            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Hi Narendra Kumar , I have approved the request and merged the changes.
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Verified this on preproduction.
            Showing proper validation message
            PFA -

            Thanks,
            Jayshree

            Priya Dhamande Swapnil Pandhare Samir

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Verified this on preproduction. Showing proper validation message PFA - Thanks, Jayshree Priya Dhamande Swapnil Pandhare Samir

              People

              Assignee:
              narendra.kumar Narendra Kumar
              Reporter:
              priya.dhamande Priya Dhamande (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 8h Original Estimate - 8h
                  8h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 8.75h
                  8.75h