[DMS-668] DMS | Signature | Draw Signature | Submit Button - Workterra Jira

Details

Type: Bug
Status: Done
Priority: Medium
Resolution: Done
Affects Version/s: None
Fix Version/s: None
Labels:
None

Company:
All Clients/Multiple Clients

Description

Environment: PreProd

Is Signature not mandatory or not? as we can submit without adding Sign?

Swapnil Pandhare Samir Narendra Kumar Ramya Tantry

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

Signaturevalidation.jpg
210 kB
07/Feb/19 12:20 AM

Issue Links

relates to

DMS-243 Signing

Done

Activity

Ascending order - Click to sort in descending order

Priya Dhamande (Inactive) created issue - 31/Jan/19 01:53 AM

Priya Dhamande (Inactive) made changes - 31/Jan/19 01:56 AM

Field	Original Value	New Value
Link		This issue relates to ~~DMS-243~~ [ ~~DMS-243~~ ]

Narendra Kumar made changes - 31/Jan/19 02:08 AM

Sprint

DMS - Sprint 2 [ 150 ]

Hide

Permalink

Narendra Kumar added a comment - 31/Jan/19 10:02 PM

Hi Samir and Swapnil Pandhare,

Can you please put your comment on this?

Show

Narendra Kumar added a comment - 31/Jan/19 10:02 PM Hi Samir and Swapnil Pandhare , Can you please put your comment on this?

Narendra Kumar made changes - 03/Feb/19 09:23 PM

Remaining Estimate		8h [ 28800 ]
Original Estimate		8h [ 28800 ]

Narendra Kumar made changes - 03/Feb/19 10:47 PM

Status

To Do [ 10000 ]

In Progress [ 3 ]

Hide

Permalink

Narendra Kumar added a comment - 03/Feb/19 10:51 PM - edited

Hi Samir

As we have discussed that we will place the validation of required signature based on the e-signature flag. But when I went through the code I found that I'm not getting the e-signature flag anywhere. So for this I discussed with Ramya Tantry. So based on discussion we need to modify some API so that I can get that flag. And then I could be able to put the validation on submit.

Swapnil Pandhare can you please create a ticket for this and assign to someone.

Thanks

Narendra

Show

Narendra Kumar added a comment - 03/Feb/19 10:51 PM - edited Hi Samir As we have discussed that we will place the validation of required signature based on the e-signature flag. But when I went through the code I found that I'm not getting the e-signature flag anywhere. So for this I discussed with Ramya Tantry . So based on discussion we need to modify some API so that I can get that flag. And then I could be able to put the validation on submit. Swapnil Pandhare can you please create a ticket for this and assign to someone. Thanks Narendra

Hide

Permalink

Narendra Kumar added a comment - 04/Feb/19 03:10 AM

Hi Samir and Swapnil Pandhare

I have configured a variable that will store the e-signature flag from API. Right now its hard coded to true.

So now user are required to sign the document. If he do not sign and submit the doc. An error message will prompt that Signature is missing. Please sign the document.

**Or you can suggest the error message. Also, I'll configure my variable with the API data once API will modified.

Thanks

Narendra

Show

Narendra Kumar added a comment - 04/Feb/19 03:10 AM Hi Samir and Swapnil Pandhare I have configured a variable that will store the e-signature flag from API. Right now its hard coded to true. So now user are required to sign the document. If he do not sign and submit the doc. An error message will prompt that Signature is missing. Please sign the document. **Or you can suggest the error message. Also, I'll configure my variable with the API data once API will modified. Thanks Narendra

Hide

Permalink

Narendra Kumar added a comment - 05/Feb/19 09:27 PM

Hi Samir

Based on discussion - You have created a separate ticket for implementing API. So moving it into Code Review.

cc - Swapnil Pandhare

Thanks

Narendra

Show

Narendra Kumar added a comment - 05/Feb/19 09:27 PM Hi Samir Based on discussion - You have created a separate ticket for implementing API. So moving it into Code Review. cc - Swapnil Pandhare Thanks Narendra

Narendra Kumar made changes - 05/Feb/19 09:27 PM

Status

In Progress [ 3 ]

Code Review [ 11801 ]

Hide

Permalink

Narendra Kumar added a comment - 05/Feb/19 09:31 PM

Hi Swapnil Pandhare

Created PR with the current changes. API implementation will complete in another ticket.

cc - Samir

Thanks

Narendra

Show

Narendra Kumar added a comment - 05/Feb/19 09:31 PM Hi Swapnil Pandhare Created PR with the current changes. API implementation will complete in another ticket. cc - Samir Thanks Narendra

Hide

Permalink

Narendra Kumar added a comment - 06/Feb/19 02:21 AM

HI Ramya Tantry

I have made the suggested changes. Now you can review PR for this task.

Thanks

Show

Narendra Kumar added a comment - 06/Feb/19 02:21 AM HI Ramya Tantry I have made the suggested changes. Now you can review PR for this task. Thanks

Permalink

Ramya Tantry (Inactive) logged work - 06/Feb/19 03:01 AM

Time Spent:

0.25h

code review

Hide

Permalink

Ramya Tantry (Inactive) added a comment - 06/Feb/19 03:01 AM

Hi Narendra Kumar,
I have approved the request and merged the changes.

Show

Ramya Tantry (Inactive) added a comment - 06/Feb/19 03:01 AM Hi Narendra Kumar , I have approved the request and merged the changes.

Ramya Tantry (Inactive) made changes - 06/Feb/19 03:01 AM

Remaining Estimate	8h [ 28800 ]	7.75h [ 27900 ]
Time Spent		0.25h [ 900 ]
Worklog Id	159431 [ 159431 ]

Raj Hawaldar (Inactive) made changes - 06/Feb/19 08:38 PM

Status

Code Review [ 11801 ]

In QA Testing [ 11901 ]

Raj Hawaldar (Inactive) made changes - 06/Feb/19 08:39 PM

Assignee

Narendra Kumar [ narendra.kumar ]

Jayshree Nagpure [ jayshree.nagpure ]

Jayshree Nagpure (Inactive) made changes - 07/Feb/19 12:20 AM

Attachment

Signaturevalidation.jpg [ 97404 ]

Hide

Permalink

Jayshree Nagpure (Inactive) added a comment - 07/Feb/19 12:21 AM

Verified this on preproduction.
Showing proper validation message
PFA -

Thanks,
Jayshree

Priya Dhamande Swapnil Pandhare Samir

Show

Jayshree Nagpure (Inactive) added a comment - 07/Feb/19 12:21 AM Verified this on preproduction. Showing proper validation message PFA - Thanks, Jayshree Priya Dhamande Swapnil Pandhare Samir

Jayshree Nagpure (Inactive) made changes - 07/Feb/19 12:21 AM

Resolution		Done [ 10000 ]
Status	In QA Testing [ 11901 ]	Done [ 10001 ]

Permalink

Jayshree Nagpure (Inactive) logged work - 07/Feb/19 03:58 AM

Time Spent:

0.5h

Testing

Jayshree Nagpure (Inactive) made changes - 07/Feb/19 03:58 AM

Remaining Estimate	7.75h [ 27900 ]	7.25h [ 26100 ]
Time Spent	0.25h [ 900 ]	0.75h [ 2700 ]
Worklog Id	159666 [ 159666 ]

Permalink

Narendra Kumar logged work - 26/Feb/19 12:00 AM

Time Spent:

8h

<No comment>

Priya Dhamande (Inactive) made changes - 05/Mar/19 05:34 AM

Assignee

Jayshree Nagpure [ jayshree.nagpure ]

Narendra Kumar [ narendra.kumar ]

Narendra Kumar made changes - 15/Oct/19 03:08 AM

Remaining Estimate	7.25h [ 26100 ]	0.25h [ 900 ]
Time Spent	0.75h [ 2700 ]	7.75h [ 27900 ]
Worklog Id	205660 [ 205660 ]

Narendra Kumar made changes - 16/Oct/19 01:31 AM

Remaining Estimate	0.25h [ 900 ]	7.25h [ 26100 ]
Time Spent	7.75h [ 27900 ]	0.75h [ 2700 ]
Worklog Id	205660 [ 205660 ]
Worklog Time Spent	7h [ 25200 ]

Narendra Kumar made changes - 16/Oct/19 01:34 AM

Remaining Estimate	7.25h [ 26100 ]	0h [ 0 ]
Time Spent	0.75h [ 2700 ]	8.75h [ 31500 ]
Worklog Id	206527 [ 206527 ]

Transition	Time In Source Status	Execution Times

Narendra Kumar made transition - 03/Feb/19 10:47 PM

To Do

In Progress

3d 20h 53m

Narendra Kumar made transition - 05/Feb/19 09:27 PM

In Progress

Code Review

1d 22h 40m

Raj Hawaldar (Inactive) made transition - 06/Feb/19 08:38 PM

Code Review

In QA Testing

23h 10m

Jayshree Nagpure (Inactive) made transition - 07/Feb/19 12:21 AM

In QA Testing

Done

3h 42m

People

Assignee:: Narendra Kumar

Reporter:: Priya Dhamande (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 31/Jan/19 01:53 AM

Updated:: 16/Oct/19 01:34 AM

Resolved:: 07/Feb/19 12:21 AM

Time Tracking

Estimated:

Remaining:

Logged:

8.75h