Mohd Belal.

We had a discussion on the same with Molly, this was wrong implemented.

Ideally, the Reference document attached while sending the forms should fall into Reference type grid. Not the one which is created as Reference Type.

If more inputs required, please let us know.

Samir Swapnil Pandhare

Hi Ganesh Sadawarte,

As per our discussion regarding this yesterday, can you please add your comment over here.

cc - Swapnil Pandhare, Samir, Priya Dhamande

Thanks 

Hi Swapnil Pandhare,

As per the latest discussion with Ganesh Sadawarte, there needs to be change made in the API part for getting the Reference Doc.

cc - Samir

Thanks

Hi Priya Dhamande,

Please provide inputs for below points:
1. If we were to show action and reference attachments in their respective grid, what should be the action on click of such documents?
2. Should there be specific UI changes for that templates for action and reference attachments on review and sign page.

CC: Swapnil Pandhare,Samir

Hi Ramya Tantry,

We have discussed about the Reference documents in call. Molly and Aruna will be working ion the same.

So, assigning ticket to Swapnil for analysis and exact functionality.

Samir Swapnil Pandhare

CC :Aruna Raheja Robert Malony

Swapnil Pandhare : We have designed the attachment option uploaded by Candidate but as per my discussion with you this ticket required something else.

Robert Malony : As discussed, kindly update the ticket. I have updated the previous mockups for your reference. Let me know if you need something else from me.

CC:Kristen Samir

Hi Robert Malony,

Currently, attachments(attached from Send forms page) are not shown on Review and Sign page.

Do we need to show it on Review and Sign page? If yes, where and how it will be positioned on page?

Thanks,

Swapnil P.

Hi Swapnil Pandhare,

I vaguely remember talking with Molly Ronovsky about this and will test my memory to see if it is good or not.

Is this the current behavior:

• When a document is added as an attachment, it can be attached as an action or reference document.
• Reference documents do not require any action to be taken
  • Are these attachments only
• Actionable documents require a user to sign or enter information
  • Are all forms that require interactions considered Actionable
    • Can they be 1) attachments and 2) assigned forms

These will help me to better understand how we want to manage the attachments and assigned forms.  We need to discuss this on the 04/02/2019 scrum meeting.

Thanks,

Robert

Robert Malony Swapnil Pandhare,

Couple of things....

• Right now the 'reference document' is not working the way it was intended to work. Reference docs should be able to be sent just like the action docs, but fall under the reference doc section when the candidate logs into their portal. Right now, it's only sending as an attachment on the email - it really does nothing.
• They are just what an attachment would do - but we would want them stored in the portal so they can reference it at any point / is associated with all documents sent to them.
• Action docs are any documents that require anything to be filled out by the candidate OR need to be signed. They would all just be part of what ends up in the portal.

As well, keep in mind, when you go to send forms, and there is a spot for upload - those are not working as intended.

Let me know if you need any further details!

Hi Molly Ronovsky,

Just wanted to circle back around this with you in that for the first pass of DMS, Action Documents will be hidden for now as they will just be covered in Forms, but I'll be creating a new requirement for Reference Documents in that they need to 1) be seen on the portal, but also 2) linked to the Forms that they were attached to.  Right now, that is not something that is available which was their for Sertifi.

-Robert

cc: Swapnil Pandhare

Robert Malony,

To clarify, ad-hoc action/reference documents will be hidden for now as they are not working as they should - they were just sending as attachments. Yes, this is something that Sertifi had. As well, reference docs should be in the portal as the mock-ups show / requirements had.

Let me know if you need anything else! / if anything else is unclear

Swapnil Pandhare

HI Molly Ronovsky,

Thanks for update.

1)What action will happen when candidate clicks on "action required adhoc forms(attachments) " from Review and Sign page? Will those attachment be downloaded or viewed itself in the portal or any other action ? 

2)What action will happen when candidate clicks on "reference adhoc forms(attachments)" from Review and Sign page? Will those attachment be downloaded or viewed itself in the portal or any other action ? 

CC: Robert Malony , Samir

Swapnil Pandhare,

1) This would be from the send forms page when they could upload new forms that have not been created as a template - they could upload a new form to send, and if action, it would send just like the others are sent, and if reference, it would just fall in the reference section when a candidate gets to the review and sign page. From there, they would be able to download the form, but no action is required from them (just like Sertifi / the demo I did for you all).

2) Reference documents would appear in the reference documents section of the review and sign page - again they would be download able / no action is required by the candidate.

As well, when sending either, you should be able to upload more than one.

Robert MalonySamir

Hi Molly Ronovsky,

Please find screenshot below which will clarify my question ?

 CC : Robert Malony

Expected Functionality as per discussion with Swapnil
1. Document templates which are marked as Reference and reference documents sent while sending forms will be seen under Reference documents pane of Review and Sign.
Reference document uploaded will be viewed with file extension in reference document pane.
2. On click of name of the reference documents, these documents will be downloaded.
3. On send forms page, remove action documents from UI.
4. As per existing flow, reference documents attached with send forms will be sent as email attachment as well.

Task details (04/16/2019)

1. Code changes to get uploaded reference document in reference pane of review and sign.
2. Discussion with Swapnil and Komal
3. Unit testing
4. Code push to remote - DMS-748 branch

Functionality tested:
1. Send action document template with reference document attached. - Action template to be seen under action document pane and reference document under reference pane.
2. Send reference document template with reference document attached. - Both will be seen under reference pane.
3. Send two document templates(combination of reference and action templates) with reference document attached. - Only one reference document will be seen even if this reference doc has been sent with two separate mails for respective document template.
4. Guest user flow - document listing.

Task details (04/16/2019):

1. Code changes to get download reference document in reference pane of review and sign.
2. Discussion with Ramya
3. Unit testing
4. Sync code of DMS-748 branch

Functionality tested for existing user:

Functionality Remain:
Not able to test above combination for guest user as wrong company is getting on local for guest user login.:Need to do code debug and apply changes as per same.

CC:Ganesh Sadawarte, Ramya Tantry, Swapnil Pandhare

Swapnil Pandhare
If you upload a document to the Action required section, it would do the same thing if you send a template that is labeled as action required. So it would send, and candidate would be able to complete form / sign / and would show up on action docs in the sign/review page. On the contrary, if it's uploaded as a reference doc, it would show up on the sign / review page under reference docs, with nothing needing to be done on the page.

I went through both scenarios in Sertifi and how it worked with the team a few months ago in zoom - do you still have that recording?

Robert Malony

List of modified files : DMS-1207: On click of name of the reference documents, documents will be downloaded)

1. DMS/DMS.App/src/DMS_AppLogic/PersonData.cs
2. DMS/DMS.App/src/DMS_WebApi/Controllers/Document/FileUploadController.cs
3. DMS/DMS.App/src/Entities/Person/SentFormsDTO.cs
4. DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Person/review-sign-page/review-sign-page.component.html
5. DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Person/review-sign-page/review-sign-page.component.ts

Functionality tested for guest user:

On click of name of the reference documents, these documents will be downloaded:

1. If attachment is given while sending form then it will get displayed as 'Filename.extenstion' in reference document section.
2. Reference document will appear with their tile in listing.
3. And on click of name of the reference documents, these documents will be downloaded.

Task details (04/17/2019):

1. Code changes to get download reference document in reference pane of review and sign.
2. Discussion with Ganesh
3. Unit testing
4. Code merge and push on DMS-748 branch

Hi Komal,

Please do the requested changes and commit those.

Thanks,

Swapnil P.

Hi

As per discussion with Samir, working on DMS-1169 priority task, so putting this jira on-hold.

Thanks,
Komal
CC:Samir, Swapnil Pandhare, Ganesh Sadawarte, Ramya Tantry

Hi Swapnil Pandhare,

I have done required changes, can you please check now?

Thanks,
Komal

CC: Samir, Swapnil Pandhare,Ganesh Sadawarte,Ramya Tantry
 

Environment: Preprod

1. Document created > Action Type
2. Send Forms > Action document browse window is missing

Komal Barde, can you please verify the same.

Swapnil Pandhare Ganesh Sadawarte Rohan J Khandave

Hi Priya Dhamande,

As discussed, assigning this jira back to you.

Thanks,
Komal.

CC:Ganesh Sadawarte

Environment: Preprod

All the test cases worked as expected. So, marking Jira Done.

Swapnil Pandhare Ganesh Sadawarte Rohan J Khandave