Details

    • Type: New Feature
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Integration with CBAT
    • Labels:
      None

      Description

      Apply user permissions to page like , Read, Write ,Update , Delete 

      Also apply permissions to data table for Edit , Delete .

      We need to disable controls if user not having specific permission.

      Also needs to create common platform to fetch permissions & to apply permission.

        Attachments

          Issue Links

            Activity

            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Rohan J Khandave,

            We have verified on Pre-production environment.
            Below mentioned are few observations :

            1.send forms : Data is editable even though the "Update" flag is false
            2.Create document : Create flag is false , not able to create document but Button should be disabled instead of enable, as it creates confusion regarding functionality
            3.Template library : Delete button is disabled , at the same time completed forms library delete functionality is also disabled even though the flag is true
            4.Edit email template : Update flag is "False" - still able to update the template and save

            Note : Randomly verified these fields from the template, could not able to verify all the feature for all fields as few of them are not applicable for all fields.

            Not working fine
            Please look into this points.

            Thanks,
            Jayshree

            Priya Dhamande Sachin Hingole Satya Hrishikesh Deshpande Samir

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Rohan J Khandave , We have verified on Pre-production environment. Below mentioned are few observations : 1.send forms : Data is editable even though the "Update" flag is false 2.Create document : Create flag is false , not able to create document but Button should be disabled instead of enable, as it creates confusion regarding functionality 3.Template library : Delete button is disabled , at the same time completed forms library delete functionality is also disabled even though the flag is true 4.Edit email template : Update flag is "False" - still able to update the template and save Note : Randomly verified these fields from the template, could not able to verify all the feature for all fields as few of them are not applicable for all fields. Not working fine Please look into this points. Thanks, Jayshree Priya Dhamande Sachin Hingole Satya Hrishikesh Deshpande Samir
            Hide
            rohan.khandave Rohan J Khandave (Inactive) added a comment -

            Moving to code review as issue are addressed into DMS-973.

            Show
            rohan.khandave Rohan J Khandave (Inactive) added a comment - Moving to code review as issue are addressed into DMS-973 .
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Rohan J Khandave - Assigning this ticket to you as status is in code review

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Rohan J Khandave - Assigning this ticket to you as status is in code review
            Hide
            rohan.khandave Rohan J Khandave (Inactive) added a comment -

            Please check

            Show
            rohan.khandave Rohan J Khandave (Inactive) added a comment - Please check
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited

            Hi Rohan J Khandave,

            We have check this on preproduction.
            User permission flag were ON for both the servers
            After updating flag, tried with logout and login.

            Updated flag to False for delete functionality of Template library and completed forms library, still we are able to delete the document

            Not working fine

            Re-opening for the same

            Thanks,
            Jayshree

            Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya Samir

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited Hi Rohan J Khandave , We have check this on preproduction. User permission flag were ON for both the servers After updating flag, tried with logout and login. Updated flag to False for delete functionality of Template library and completed forms library, still we are able to delete the document Not working fine Re-opening for the same Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya Samir
            Hide
            rohan.khandave Rohan J Khandave (Inactive) added a comment -

            Hello Jayshree Nagpure,

            Please provide your test data.

            Thanks,
            RohanK

            CC – Priya Dhamande

            Show
            rohan.khandave Rohan J Khandave (Inactive) added a comment - Hello Jayshree Nagpure , Please provide your test data. Thanks, RohanK CC – Priya Dhamande
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            URL : corporate/dms//api/userPermissions/91

            UserDid :C7F0DT48MTPPRODFFR
            ACC did : A7F70WORKTERRAWBBT

            Admin Login cred : CBATAdmin/CBraCB

            Body : [
            {
            "id": 1,
            "name": "AdminMenuRole",
            "isroleassigned": true,
            "featuretype": "FeatureMenu",
            "featuredetailslist": [
            {
            "id": 3,
            "featureid": 0,
            "featurename": "documenttemplate",
            "featurenamedescription": "Create Document Template",
            "roleid": 0,
            "menupermission":

            { "norights": true, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false }

            },
            {
            "id": 4,
            "featureid": 0,
            "featurename": "formsLibrary",
            "featurenamedescription": "Template library",
            "roleid": 0,
            "menupermission":

            { "norights": false, "readonly": true, "create": true, "update": true, "delete": false, "readpiidata": false }

            },
            {
            "id": 5,
            "featureid": 0,
            "featurename": "completedFormsLibrary",
            "featurenamedescription": "Completed document library",
            "roleid": 0,
            "menupermission":

            { "norights": false, "readonly": true, "create": true, "update": true, "delete": false, "readpiidata": false }

            },
            {
            "id": 6,
            "featureid": 0,
            "featurename": "reviewSignPage",
            "featurenamedescription": "Review and Sign",
            "roleid": 0,
            "menupermission":

            { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false }

            },
            {
            "id": 7,
            "featureid": 0,
            "featurename": "previewForm",
            "featurenamedescription": "Preview Document",
            "roleid": 0,
            "menupermission":

            { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false }

            },
            {
            "id": 8,
            "featureid": 0,
            "featurename": "sendformdetails",
            "featurenamedescription": "Send forms(Ad-hoc forms)",
            "roleid": 0,
            "menupermission":

            { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false }

            },
            {
            "id": 9,
            "featureid": 0,
            "featurename": "editemailtype",
            "featurenamedescription": "Email template",
            "roleid": 0,
            "menupermission":

            { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false }

            },
            {
            "id": 10,
            "featureid": 0,
            "featurename": "SendForms",
            "featurenamedescription": "SendForms",
            "roleid": 0,
            "menupermission":

            { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false }

            },
            {
            "id": 2,
            "featureid": 0,
            "featurename": "completedFormsLibrary",
            "featurenamedescription": "This menu allow user to view and edit completed from",
            "roleid": 0,
            "menupermission":

            { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": true }

            }
            ]
            },
            {
            "id": 2,
            "name": "AdmindataRole",
            "isroleassigned": true,
            "featuretype": "DataPermission",
            "featuredetailslist": [
            {
            "id": 1,
            "featureid": 0,
            "featurename": "ReadPIIData",
            "featurenamedescription": null,
            "roleid": 0,
            "menupermission":

            { "norights": false, "readonly": false, "create": false, "update": false, "delete": false, "readpiidata": true }

            },
            {
            "id": 2,
            "featureid": 0,
            "featurename": "ReadOnlyNonPIIData",
            "featurenamedescription": null,
            "roleid": 0,
            "menupermission":

            { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": true }

            }
            ]
            }
            ]
            "usertype": "Admin"
            }

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - URL : corporate/dms//api/userPermissions/91 UserDid :C7F0DT48MTPPRODFFR ACC did : A7F70WORKTERRAWBBT Admin Login cred : CBATAdmin/CBraCB Body : [ { "id": 1, "name": "AdminMenuRole", "isroleassigned": true, "featuretype": "FeatureMenu", "featuredetailslist": [ { "id": 3, "featureid": 0, "featurename": "documenttemplate", "featurenamedescription": "Create Document Template", "roleid": 0, "menupermission": { "norights": true, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false } }, { "id": 4, "featureid": 0, "featurename": "formsLibrary", "featurenamedescription": "Template library", "roleid": 0, "menupermission": { "norights": false, "readonly": true, "create": true, "update": true, "delete": false, "readpiidata": false } }, { "id": 5, "featureid": 0, "featurename": "completedFormsLibrary", "featurenamedescription": "Completed document library", "roleid": 0, "menupermission": { "norights": false, "readonly": true, "create": true, "update": true, "delete": false, "readpiidata": false } }, { "id": 6, "featureid": 0, "featurename": "reviewSignPage", "featurenamedescription": "Review and Sign", "roleid": 0, "menupermission": { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false } }, { "id": 7, "featureid": 0, "featurename": "previewForm", "featurenamedescription": "Preview Document", "roleid": 0, "menupermission": { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false } }, { "id": 8, "featureid": 0, "featurename": "sendformdetails", "featurenamedescription": "Send forms(Ad-hoc forms)", "roleid": 0, "menupermission": { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false } }, { "id": 9, "featureid": 0, "featurename": "editemailtype", "featurenamedescription": "Email template", "roleid": 0, "menupermission": { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false } }, { "id": 10, "featureid": 0, "featurename": "SendForms", "featurenamedescription": "SendForms", "roleid": 0, "menupermission": { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": false } }, { "id": 2, "featureid": 0, "featurename": "completedFormsLibrary", "featurenamedescription": "This menu allow user to view and edit completed from", "roleid": 0, "menupermission": { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": true } } ] }, { "id": 2, "name": "AdmindataRole", "isroleassigned": true, "featuretype": "DataPermission", "featuredetailslist": [ { "id": 1, "featureid": 0, "featurename": "ReadPIIData", "featurenamedescription": null, "roleid": 0, "menupermission": { "norights": false, "readonly": false, "create": false, "update": false, "delete": false, "readpiidata": true } }, { "id": 2, "featureid": 0, "featurename": "ReadOnlyNonPIIData", "featurenamedescription": null, "roleid": 0, "menupermission": { "norights": false, "readonly": true, "create": true, "update": true, "delete": true, "readpiidata": true } } ] } ] "usertype": "Admin" }
            Hide
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment -

            4/3/2019 Task Details.

            • Code changes for load permissions.
            • Discussion with Rohan J Khandave.
            • unit testing & check review & sign page from mail
            • changes push to git and assign for code review.

            CC-Swapnil Pandhare

            Show
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - 4/3/2019 Task Details. Code changes for load permissions. Discussion with Rohan J Khandave . unit testing & check review & sign page from mail changes push to git and assign for code review. CC- Swapnil Pandhare
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Ganesh Sadawarte,

            We have verified on preproduction.

            in case of NoRights : false, then user should not be able to access any menus like create document template.
            So its not working as expected.

            Re-opening this ticket.

            Priya Dhamande

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Ganesh Sadawarte , We have verified on preproduction. in case of NoRights : false, then user should not be able to access any menus like create document template. So its not working as expected. Re-opening this ticket. Priya Dhamande
            Hide
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited

            Hi Jayshree Nagpure,

            As per our discussion on Friday please create new for bug for this.

            Thanks,
            Ganesh

            Show
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) added a comment - - edited Hi Jayshree Nagpure , As per our discussion on Friday please create new for bug for this. Thanks, Ganesh
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Verified attached testcases.
            Found few issue are linked to this ticket

            Closing this ticket

            Thanks,
            Jayshree

            Priya Dhamande

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Verified attached testcases. Found few issue are linked to this ticket Closing this ticket Thanks, Jayshree Priya Dhamande

              People

              Assignee:
              jayshree.nagpure Jayshree Nagpure (Inactive)
              Reporter:
              rohan.khandave Rohan J Khandave (Inactive)
              Developer:
              Ganesh Sadawarte (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 32h
                  32h
                  Remaining:
                  Time Spent - 23.5h Remaining Estimate - 8.5h
                  8.5h
                  Logged:
                  Time Spent - 23.5h Remaining Estimate - 8.5h
                  23.5h