-
Type:
Bug
-
Status: Resolution Setting
-
Priority:
Medium
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: Integrations
-
Labels:None
-
Environment:Stage
-
Bug Type:Functional
-
Bug Severity:Medium
-
Level:Admin
-
Module:TSR
-
Reported by:Harbinger
-
Item State:Stage QA - Production Deployment on Hold
-
Issue Importance:Q2
Env- Stage
Company - TSR Onboard
1] Add employee through API, while adding assigned tour id = 12
2] Now update employee with "PUT" request and mentioned tour id = 13
3] Observe the response message it is
{
"status": "Success",
"company": "13008",
"employeeID": "E5346",
"jobID": "101595",
"tourID": 13,
"description": "Employee record updated successfully"
}
Actual Result:
Respective tour is not get assigned to employee but the response message is misleading.
Expected Result:
We need to change the response message.
- relates to
-
NF-3998 Regression testing for TSR Integration with Old UI on Stage
-
- Closed
-
Modified file
1.Database Objects\MasterCompanyDB\02_UDFs\dbo.OES_UDF_ValidateEmployeeTourRecord.sql
Concern: Update Employee>After updating tour id success message is displaying.
Cause: Tourid is removed from employee source table
Correction: UDF is modified to check for candidate, jobid and tourid combination when employee information is updated.
Seema Gaikwad (Inactive)
added a comment - Modified file
1.Database Objects\MasterCompanyDB\02_UDFs\dbo.OES_UDF_ValidateEmployeeTourRecord.sql
Concern: Update Employee>After updating tour id success message is displaying.
Cause: Tourid is removed from employee source table
Correction: UDF is modified to check for candidate, jobid and tourid combination when employee information is updated.
Verified the fix on Local, now updating employee with tour id, below response is displaying:
{
"status": "Error",
"message": "Invalid parameter value",
"errorLevel": "Error",
"code": 400,
"description": "No record found to update for supplied Candidate, JobId and Tour combination"
}
We can deploy fix to Stage.
Kunal Kedari (Inactive)
added a comment - Verified the fix on Local, now updating employee with tour id, below response is displaying:
{
"status": "Error",
"message": "Invalid parameter value",
"errorLevel": "Error",
"code": 400,
"description": "No record found to update for supplied Candidate, JobId and Tour combination"
}
We can deploy fix to Stage.
cc: Prasad Pise , Saurabh Sablaka We have verified the fix on Local (wt-stage), now below message is displaying after trying to update tourid, we can deploy fix to Stage.
{
"status": "Error",
"message": "Invalid parameter value",
"errorLevel": "Error",
"code": 400,
"description": "No record found to update for supplied Candidate, JobId and Tour combination"
}
Kunal Kedari (Inactive)
added a comment - We have verified the fix on Local (wt-stage), now below message is displaying after trying to update tourid, we can deploy fix to Stage.
{
"status": "Error",
"message": "Invalid parameter value",
"errorLevel": "Error",
"code": 400,
"description": "No record found to update for supplied Candidate, JobId and Tour combination"
}
Cc: Saurabh Sablaka , Prasad Pise Verified fix on Stage, working as expected. We can deploy it to Production.
Kunal Kedari (Inactive)
added a comment - Verified fix on Stage, working as expected. We can deploy it to Production. Business decided to stop all the work related to TSR.
Kunal Kedari (Inactive)
added a comment - Business decided to stop all the work related to TSR. 
Hi Kunal Kedari,
We are not assigning tour when employee information is updated.
So when No combination present for candidate,job and tourid following message is shown
CC : Saurabh Sablaka Ramya Tantry