Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-4028

TSR Integration>Regression>Add Employee>Server error is displaying after adding employee with salary other than default currency

    Details

    • Type: Bug
    • Status: Resolution Setting
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Integrations
    • Labels:
      None
    • Environment:
      Stage
    • Bug Type:
      Functional
    • Bug Severity:
      Medium
    • Level:
      Admin
    • Module:
      TSR
    • Reported by:
      Harbinger
    • Item State:
      Stage QA - Production Deployment on Hold
    • Issue Importance:
      Q2

      Description

      Env- Stage
      Company - TSR Onboard

      Steps:
      1] Suppose Default Currency format is ( $ US Dollar ). [We can set this default currency format by navigating Company Information>Localisation Settings]
      2] Try to add employee using API, with salary in Pound or Euro.

      Actual Result:
      Internal Server error is displaying, if we try to add employee with US dollar $ then it is getting added successfully.
      Expected Result:
      Error should not be displaying while adding employee with salary other than than default format.
      Refer attached screenshot for more details.

      Cc: Saurabh Sablaka, Prasad Pise

        Attachments

          Issue Links

            Activity

            kunal.kedari Kunal Kedari (Inactive) created issue -
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Development [ 10007 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206)
            seema.gaikwad Seema Gaikwad (Inactive) logged work - 02/Aug/17 09:13 AM - edited
            • Time Spent:
              2.5h
               

              Issue debugging.
              Discussion with Ramya and Kunal
              Script Modification and testing on Stage

            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 4h [ 14400 ]
            Original Estimate 4h [ 14400 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 4h [ 14400 ] 2h [ 7200 ]
            Time Spent 2h [ 7200 ]
            Worklog Id 68907 [ 68907 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206) Parent values: Development(10200)Level 1 values: Ready for Review(10208)
            Hide
            seema.gaikwad Seema Gaikwad (Inactive) added a comment -

            Modified Files
            1.Database Objects/MasterCompanyDB/04_Stored Procedures/dbo.OES_SP_AssignCurrency.sql

            Show
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - Modified Files 1.Database Objects/MasterCompanyDB/04_Stored Procedures/dbo.OES_SP_AssignCurrency.sql
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Code Review Date 02/Aug/2017
            Code Reviewed By Ramya Tantry [ 13001 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
            Hide
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - - edited

            Concern: Add Employee>Server error is displaying after adding employee with salary other than default currency
            Cause: database cluster name was not given for onlineEnrollment
            Correction: 'dbo.OES_SP_AssignCurrency.sql' SP modification

            Show
            seema.gaikwad Seema Gaikwad (Inactive) added a comment - - edited Concern: Add Employee>Server error is displaying after adding employee with salary other than default currency Cause: database cluster name was not given for onlineEnrollment Correction: 'dbo.OES_SP_AssignCurrency.sql' SP modification
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Assignee Seema Gaikwad [ seema.gaikwad ] Kunal Kedari [ kunal.kedari ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Worklog Id 68907 [ 68907 ]
            seema.gaikwad Seema Gaikwad (Inactive) made changes -
            Remaining Estimate 2h [ 7200 ] 1.5h [ 5400 ]
            Time Spent 2h [ 7200 ] 2.5h [ 9000 ]
            Worklog Id 68907 [ 68907 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            ramya.tantry Ramya Tantry (Inactive) logged work - 02/Aug/17 04:02 PM
            • Time Spent:
              0.5h
               

              Issue analysis with Seema

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 1.5h [ 5400 ] 1h [ 3600 ]
            Time Spent 2.5h [ 9000 ] 3h [ 10800 ]
            Worklog Id 69067 [ 69067 ]
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Hi Seema Gaikwad

            We have verified the fix on Local (wt-stage), now server error is not displaying after adding or updating employee with salary other than default currency.

            We can deploy fix to Stage.

            Cc: Prasad Pise, Saurabh Sablaka

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Hi Seema Gaikwad We have verified the fix on Local (wt-stage), now server error is not displaying after adding or updating employee with salary other than default currency. We can deploy fix to Stage. Cc: Prasad Pise , Saurabh Sablaka
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
            Developer Seema Gaikwad [ seema.gaikwad ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Production Due Date 17/Aug/2017
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Stage Due Date 14/Aug/17 [ 2017-08-14 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Stage Due Date 14/Aug/17 [ 2017-08-14 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified fix on Stage, error is not displaying after adding employee with salary other than default currency.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified fix on Stage, error is not displaying after adding employee with salary other than default currency.
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Production Due Date 17/Aug/2017 24/Aug/2017
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Stage Due Date 9/Aug/17 [ 2017-08-09 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Link This issue relates to NF-3998 [ NF-3998 ]
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Business decided to stop all the work related to TSR.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Business decided to stop all the work related to TSR.
            satyap Satya made changes -
            Environment_New Stage [ 18443 ]
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Stage Testing [ 10201 ] Resolution Setting [ 11616 ]
            Transition Time In Source Status Execution Times
            Seema Gaikwad (Inactive) made transition -
            Open In Development
            17h 59m 1
            Kunal Kedari (Inactive) made transition -
            In Development In LB Testing
            4d 22h 36m 1
            Kunal Kedari (Inactive) made transition -
            In LB Testing Stage Testing
            3d 7h 10m 1
            Sachin Hingole (Inactive) made transition -
            Stage Testing Resolution Setting
            258d 14h 32m 1

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              kunal.kedari Kunal Kedari (Inactive)
              Developer:
              Seema Gaikwad (Inactive)
              QA:
              Kunal Kedari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Pre-Prod Due Date:
                Production Due Date:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4h
                  4h
                  Remaining:
                  Time Spent - 3h Remaining Estimate - 1h
                  1h
                  Logged:
                  Time Spent - 3h Remaining Estimate - 1h
                  3h