New Features 2017Project Type: software

New Features 2017

Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-593

TSR Integration->Add Employee->Employee is getting added without payroll schedule.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Integrations
    • Labels:
      None
    • Module:
      TSR
    • Reported by:
      Harbinger
    • Item State:
      Production Complete - Closed
    • Issue Importance:
      Q1

      Description

      1. Launch the Postman app.
      2. Select “Post” request from dropdwon.
      3. Select authorization type as “Basic Auth”.
      4. Enter valid User ID and Password.
      5. Enter below URL:
      http://10.0.2.120/api/employee/addEmployeeTour
      6. Pass the require parameter using body.
      (Do not mentioned payroll scheduled in parameter)
      "Company":"12480",
      "JobID":1245,
      "JobPosition":"test",
      "CandidateID":"13760",
      "FirstName":"Q",
      "LastName":"R",
      "EmailID":"s227458@test.com",
      "EmploymentStartDate":"03/17/2017",
      "AnnualSalary":"$120000.0",
      "TourID":28,

      7. Click on Send button.

      Actual Result:
      In output we are seeing message Invalid Payroll schedule message, but when we check in DB employee is added.
      Expected Result:
      Employee should not be get added without payroll schedule, and if it there is no such constraint then should employee added message on screen.

      Please note same issue exists if we mentioned in input : AssignDefaultPayrollSchedule":false

      Cc: Saurabh Sablaka, Prasad Pise

        Attachments

          Issue Links

          relates to

          Enhancement - An improvement or enhancement to an existing feature or task. NF-180 TSR: API: Add Employee- generate & assign defaults

          • High - Serious problem that could block progress.
          • Closed

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rupesh.mandal Rupesh Mandal (Inactive) added a comment -

            Issue Resolved

            Show
            rupesh.mandal Rupesh Mandal (Inactive) added a comment - Issue Resolved
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            The fix is verified on Local (wt-stage) environment, now employee is not getting added without payroll schedule.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - The fix is verified on Local (wt-stage) environment, now employee is not getting added without payroll schedule.
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified fix on Stage environment employee is not getting added without payroll schedule and proper message is displaying if we have not entered payroll schedule while adding employee. Marking as "Production Deployment on Hold"

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified fix on Stage environment employee is not getting added without payroll schedule and proper message is displaying if we have not entered payroll schedule while adding employee. Marking as "Production Deployment on Hold"
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Hi Rupesh Mandal

            We are reopening this issue as employee is getting added without valid payroll schedule. We have passed following parameters through API:

            "EmploymentStartDate":"04/22/2017",
            "AnnualSalary":"$120000.0",
            "TourID":12,
            "AssignDefaultPayrollSchedule":false,
            "PayrollSchedule":"Bi-Weekly"

            As assigndefaultpayrollschedule is false and mentioned payrollschedule values (Bi-Weekly, Monthly) is not exists in application. API is showing error message:
            "Error occurred while assigning payroll schedule to employee, please contact system administrator."
            It is fine that error message is displaying, but employee should not be get added.

            Also getting getting below error while clicking on such employee name from Search Employee list.

            Cc: Prasad Pise, Saurabh Sablaka

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Hi Rupesh Mandal We are reopening this issue as employee is getting added without valid payroll schedule. We have passed following parameters through API: "EmploymentStartDate":"04/22/2017", "AnnualSalary":"$120000.0", "TourID":12, "AssignDefaultPayrollSchedule":false, "PayrollSchedule":"Bi-Weekly" As assigndefaultpayrollschedule is false and mentioned payrollschedule values (Bi-Weekly, Monthly) is not exists in application. API is showing error message: "Error occurred while assigning payroll schedule to employee, please contact system administrator." It is fine that error message is displaying, but employee should not be get added. Also getting getting below error while clicking on such employee name from Search Employee list. Cc: Prasad Pise , Saurabh Sablaka
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified the fix on Stage environment, now employee id getting added without mentioning payroll schedule, in this case default payroll schedule get assigned to employee. Marking fix as "Production Deployment On Hold"

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified the fix on Stage environment, now employee id getting added without mentioning payroll schedule, in this case default payroll schedule get assigned to employee. Marking fix as "Production Deployment On Hold"

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              kunal.kedari Kunal Kedari (Inactive)
              QA:
              Kunal Kedari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: