New Features 2017Project Type: software

New Features 2017

Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-593

TSR Integration->Add Employee->Employee is getting added without payroll schedule.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Integrations
    • Labels:
      None
    • Module:
      TSR
    • Reported by:
      Harbinger
    • Item State:
      Production Complete - Closed
    • Issue Importance:
      Q1

      Description

      1. Launch the Postman app.
      2. Select “Post” request from dropdwon.
      3. Select authorization type as “Basic Auth”.
      4. Enter valid User ID and Password.
      5. Enter below URL:
      http://10.0.2.120/api/employee/addEmployeeTour
      6. Pass the require parameter using body.
      (Do not mentioned payroll scheduled in parameter)
      "Company":"12480",
      "JobID":1245,
      "JobPosition":"test",
      "CandidateID":"13760",
      "FirstName":"Q",
      "LastName":"R",
      "EmailID":"s227458@test.com",
      "EmploymentStartDate":"03/17/2017",
      "AnnualSalary":"$120000.0",
      "TourID":28,

      7. Click on Send button.

      Actual Result:
      In output we are seeing message Invalid Payroll schedule message, but when we check in DB employee is added.
      Expected Result:
      Employee should not be get added without payroll schedule, and if it there is no such constraint then should employee added message on screen.

      Please note same issue exists if we mentioned in input : AssignDefaultPayrollSchedule":false

      Cc: Saurabh Sablaka, Prasad Pise

        Attachments

          Issue Links

          relates to

          Enhancement - An improvement or enhancement to an existing feature or task. NF-180 TSR: API: Add Employee- generate & assign defaults

          • High - Serious problem that could block progress.
          • Closed

            Activity

            Ascending order - Click to sort in descending order
            kunal.kedari Kunal Kedari (Inactive) created issue -
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Field Original Value New Value
            Link This issue relates to NF-180 [ NF-180 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Description 1. Launch the Postman app.
            2. Select “Post” request from dropdwon.
            3. Select authorization type as “Basic Auth”.
            4. Enter valid User ID and Password.
            5. Enter below URL:
            http://10.0.2.120/api/employee/addEmployeeTour
            6. Pass the require parameter using body.
                (Do not mentioned payroll scheduled in parameter)
            "Company":"12480",
            "JobID":1245,
            "JobPosition":"test",
            "CandidateID":"13760",
            "FirstName":"Q",
            "LastName":"R",
            "EmailID":"s227458@test.com",
            "EmploymentStartDate":"03/17/2017",
            "AnnualSalary":"$120000.0",
            "TourID":28,

            7. Click on Send button.

            Actual Result:
            In output we are seeing message Invalid Payroll schedule message, but when we check in DB employee is added.
            Expected Result:
            Employee should not be get added without payroll schedule, and if it there is no such constraint then should employee added message on screen.

            Cc: [~saurabh.sablaka], [~prasadp]             		1. Launch the Postman app.
            2. Select “Post” request from dropdwon.
            3. Select authorization type as “Basic Auth”.
            4. Enter valid User ID and Password.
            5. Enter below URL:
            http://10.0.2.120/api/employee/addEmployeeTour
            6. Pass the require parameter using body.
                (Do not mentioned payroll scheduled in parameter)
            "Company":"12480",
            "JobID":1245,
            "JobPosition":"test",
            "CandidateID":"13760",
            "FirstName":"Q",
            "LastName":"R",
            "EmailID":"s227458@test.com",
            "EmploymentStartDate":"03/17/2017",
            "AnnualSalary":"$120000.0",
            "TourID":28,

            7. Click on Send button.

            Actual Result:
            In output we are seeing message Invalid Payroll schedule message, but when we check in DB employee is added.
            Expected Result:
            Employee should not be get added without payroll schedule, and if it there is no such constraint then should employee added message on screen.

            Please note same issue exists if we mentioned in input : AssignDefaultPayrollSchedule":false

            Cc: [~saurabh.sablaka], [~prasadp]
            rupesh.mandal Rupesh Mandal (Inactive) made changes -
            Status Open [ 1 ] In Development [ 10007 ]
            rupesh.mandal Rupesh Mandal (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            Hide
            Permalink
            rupesh.mandal Rupesh Mandal (Inactive) added a comment -

            Issue Resolved

            Show
            rupesh.mandal Rupesh Mandal (Inactive) added a comment - Issue Resolved
            rupesh.mandal Rupesh Mandal (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            rupesh.mandal Rupesh Mandal (Inactive) made changes -
            Assignee Rupesh Mandal [ rupesh.mandal ] Kunal Kedari [ kunal.kedari ]
            prasadp Prasad Pise (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            The fix is verified on Local (wt-stage) environment, now employee is not getting added without payroll schedule.

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - The fix is verified on Local (wt-stage) environment, now employee is not getting added without payroll schedule.
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            prasadp Prasad Pise (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            prasadp Prasad Pise (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified fix on Stage environment employee is not getting added without payroll schedule and proper message is displaying if we have not entered payroll schedule while adding employee. Marking as "Production Deployment on Hold"

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified fix on Stage environment employee is not getting added without payroll schedule and proper message is displaying if we have not entered payroll schedule while adding employee. Marking as "Production Deployment on Hold"
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Resolution Unresolved [ 10200 ]
            Status Stage Testing [ 10201 ] Reopen in Stage [ 10023 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Attachment Error.jpg [ 44216 ]
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Hi Rupesh Mandal

            We are reopening this issue as employee is getting added without valid payroll schedule. We have passed following parameters through API:

            "EmploymentStartDate":"04/22/2017",
            "AnnualSalary":"$120000.0",
            "TourID":12,
            "AssignDefaultPayrollSchedule":false,
            "PayrollSchedule":"Bi-Weekly"

            As assigndefaultpayrollschedule is false and mentioned payrollschedule values (Bi-Weekly, Monthly) is not exists in application. API is showing error message:
            "Error occurred while assigning payroll schedule to employee, please contact system administrator."
            It is fine that error message is displaying, but employee should not be get added.

            Also getting getting below error while clicking on such employee name from Search Employee list.

            Cc: Prasad Pise, Saurabh Sablaka

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Hi Rupesh Mandal We are reopening this issue as employee is getting added without valid payroll schedule. We have passed following parameters through API: "EmploymentStartDate":"04/22/2017", "AnnualSalary":"$120000.0", "TourID":12, "AssignDefaultPayrollSchedule":false, "PayrollSchedule":"Bi-Weekly" As assigndefaultpayrollschedule is false and mentioned payrollschedule values (Bi-Weekly, Monthly) is not exists in application. API is showing error message: "Error occurred while assigning payroll schedule to employee, please contact system administrator." It is fine that error message is displaying, but employee should not be get added. Also getting getting below error while clicking on such employee name from Search Employee list. Cc: Prasad Pise , Saurabh Sablaka
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Assignee Kunal Kedari [ kunal.kedari ] Rupesh Mandal [ rupesh.mandal ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224) Parent values: Stage QA(10202)Level 1 values: Re-open(10216)
            Hide
            Permalink
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Verified the fix on Stage environment, now employee id getting added without mentioning payroll schedule, in this case default payroll schedule get assigned to employee. Marking fix as "Production Deployment On Hold"

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Verified the fix on Stage environment, now employee id getting added without mentioning payroll schedule, in this case default payroll schedule get assigned to employee. Marking fix as "Production Deployment On Hold"
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Re-open(10216) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Assignee Rupesh Mandal [ rupesh.mandal ] Kunal Kedari [ kunal.kedari ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Reopen in Stage [ 10023 ] In Development [ 10007 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            saurabh.sablaka Saurabh Sablaka (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224) Parent values: Production QA(10203)Level 1 values: Production Deployed(10221)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Production QA(10203)Level 1 values: Production Deployed(10221) Parent values: Production Complete(10222)Level 1 values: Closed(10223)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Stage Testing [ 10201 ] Production Testing [ 10202 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Production Testing [ 10202 ] Production Complete [ 10028 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Resolution Unresolved [ 10200 ] Fixed [ 1 ]
            Status Production Complete [ 10028 ] Closed [ 6 ]
            Transition Time In Source Status Execution Times
            Rupesh Mandal (Inactive) made transition -
            Open In Development
            		1d 18h 6m 1
            Kunal Kedari (Inactive) made transition -
            Stage Testing Reopened in Stage
            		9d 19h 55m 1
            Kunal Kedari (Inactive) made transition -
            Reopened in Stage In Development
            		16d 23h 42m 1
            Kunal Kedari (Inactive) made transition -
            In Development In LB Testing
            		11s 2
            Kunal Kedari (Inactive) made transition -
            In LB Testing Stage Testing
            		3d 7h 48m 2
            Kunal Kedari (Inactive) made transition -
            Stage Testing In Production Testing
            		66d 20h 13m 1
            Kunal Kedari (Inactive) made transition -
            In Production Testing Production Complete
            		5s 1
            Kunal Kedari (Inactive) made transition -
            Production Complete Closed
            		2s 1

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              kunal.kedari Kunal Kedari (Inactive)
              QA:
              Kunal Kedari (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: