Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-86

Review Performance Management Schema

    Details

    • Type: Support Activity
    • Status: Resolved
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Module:
      Performance Management
    • Reported by:
      Client
    • Issue Importance:
      Q1

      Description

      Please see attached schema creation script for the tables and constraints for the Performance management module.

        Attachments

          Issue Links

            Activity

            Hide
            indraprakash Indraprakash Tiwari (Inactive) added a comment -

            I have reviewed attached script, and seem to be some changes required.
            1. We cannot use default constraint without specifying constraint name, constraint name must be specify, see tables script for (Surveys, Feedback, Metrics, PerformanceCheckins, etc)
            2. Cannot use TEXTIMAGE_ON when a table has no text, ntext, image, varchar(max), nvarchar(max), varbinary(max), xml or large CLR type columns. ( see tables script for (PerformanceRatings)
            3. [Created] [datetime] NOT NULL,
            [CreatedBy] [bigint] NOT NULL,
            [Modified] [datetime] NULL,
            [ModifiedBy] [bigint] NULL,
            These four columns should be present in all tables.
            4. IsCompanyUser column must be present in tables, which tell us user level (gloabal/client)
            5. Use varchar instead of nvarchar, wherever is possible
            6. Use Date datatype instead of datetime, where time is not required.

            Observation:
            Workterra using datetimestamp for created and UserID for createdby

            Show
            indraprakash Indraprakash Tiwari (Inactive) added a comment - I have reviewed attached script, and seem to be some changes required. 1. We cannot use default constraint without specifying constraint name, constraint name must be specify, see tables script for (Surveys, Feedback, Metrics, PerformanceCheckins, etc) 2. Cannot use TEXTIMAGE_ON when a table has no text, ntext, image, varchar(max), nvarchar(max), varbinary(max), xml or large CLR type columns. ( see tables script for (PerformanceRatings) 3. [Created] [datetime] NOT NULL, [CreatedBy] [bigint] NOT NULL, [Modified] [datetime] NULL, [ModifiedBy] [bigint] NULL, These four columns should be present in all tables. 4. IsCompanyUser column must be present in tables, which tell us user level (gloabal/client) 5. Use varchar instead of nvarchar, wherever is possible 6. Use Date datatype instead of datetime, where time is not required. Observation: Workterra using datetimestamp for created and UserID for createdby
            Hide
            indraprakash Indraprakash Tiwari (Inactive) added a comment - - edited

            We can not use "*" in any query and stored procedure, Colum name must be specify.
            see below procedure
            PM_SP_Common_IsEmployeeIdInManagementChain, IsEmployeePositionIdInManagementChain

            Show
            indraprakash Indraprakash Tiwari (Inactive) added a comment - - edited We can not use "*" in any query and stored procedure, Colum name must be specify. see below procedure PM_SP_Common_IsEmployeeIdInManagementChain, IsEmployeePositionIdInManagementChain
            Hide
            matthew.dominioni Matthew Dominioni (Inactive) added a comment -

            I understand all of the requested changes except for "4. IsCompanyUser column must be present in tables...". Can you provide more details and maybe give an example of another table that has this column present and what it's used for?

            Show
            matthew.dominioni Matthew Dominioni (Inactive) added a comment - I understand all of the requested changes except for "4. IsCompanyUser column must be present in tables...". Can you provide more details and maybe give an example of another table that has this column present and what it's used for?
            Hide
            matthew.dominioni Matthew Dominioni (Inactive) added a comment -

            review must be complete before checking in initial database scripts.

            Show
            matthew.dominioni Matthew Dominioni (Inactive) added a comment - review must be complete before checking in initial database scripts.
            Hide
            matthew.dominioni Matthew Dominioni (Inactive) added a comment -

            I have updated attached script file. Once approved, I will split this out and check in individual files per naming convention one per table and the stored procedures.

            Show
            matthew.dominioni Matthew Dominioni (Inactive) added a comment - I have updated attached script file. Once approved, I will split this out and check in individual files per naming convention one per table and the stored procedures.
            Hide
            indraprakash Indraprakash Tiwari (Inactive) added a comment -

            Hi Matt,
            You can see the structure of employee table. IsCompanyUser having a flag which indicate that entries been modified by Company user or Admin/Partner.

            IsCompanyUser = 1 means changes did by Company User Only
            IsCompanyUser = 0 means changes did by Admin/partner which is exists on Onlineenrollment table.

            One more point, I have seen that you have dropped all the default constraint from schema, Can you verify once again whether it is required or not?

            Rest scripts are fine to me.

            Regards,
            Indra

            Show
            indraprakash Indraprakash Tiwari (Inactive) added a comment - Hi Matt, You can see the structure of employee table. IsCompanyUser having a flag which indicate that entries been modified by Company user or Admin/Partner. IsCompanyUser = 1 means changes did by Company User Only IsCompanyUser = 0 means changes did by Admin/partner which is exists on Onlineenrollment table. One more point, I have seen that you have dropped all the default constraint from schema, Can you verify once again whether it is required or not? Rest scripts are fine to me. Regards, Indra
            Hide
            matthew.dominioni Matthew Dominioni (Inactive) added a comment -

            Checked in all scripts after requested changes have been made.

            Show
            matthew.dominioni Matthew Dominioni (Inactive) added a comment - Checked in all scripts after requested changes have been made.
            Hide
            matthew.dominioni Matthew Dominioni (Inactive) added a comment -

            Add all scripts into SVN trunk revision 78799

            Show
            matthew.dominioni Matthew Dominioni (Inactive) added a comment - Add all scripts into SVN trunk revision 78799

              People

              Assignee:
              matthew.dominioni Matthew Dominioni (Inactive)
              Reporter:
              matthew.dominioni Matthew Dominioni (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: