Uploaded image for project: 'WORKTERRA'
  1. WORKTERRA
  2. WT-10897

Import Record summary should have unique identification

    Details

    • Type: Bug
    • Status: In LB Testing
    • Priority: Medium
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: BenAdmin
    • Labels:
    • Environment:
      Production
    • Bug Type:
      Functional
    • Bug Severity:
      Medium
    • Module:
      BenAdmin - Import
    • Reported by:
      Harbinger
    • Item State:
      LB QA - On Hold
    • Sprint:
      WT Sprint 37 - Bugs

      Description

      To show number of records imported, sent to bad, a third table is used.
      The table do not identify the record uniquely and only returns the top record. So if there's a parallel import, scenario may occur that statistics of two imports are swapped depending on which completes first.

      ImportExportBadFileID can be used as unique key for import to solve the issue.

        Attachments

          Issue Links

            Activity

            suraj.sokasane Suraj Sokasane (Inactive) created issue -
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Field Original Value New Value
            Assignee Jaideep Vinchurkar [ jaideep.vinchurkar ] snehal katkar [ snehal.katkar ]
            gaurav.sodani Gaurav Sodani (Inactive) made changes -
            Sprint WT Sprint 37 - Bugs [ 87 ]
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Dev Due Date 21/Sep/2017
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Status Open [ 1 ] In Development [ 10007 ]
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204)
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Developer snehal katkar [ snehal.katkar ]
            snehal.katkar Snehal Katkar (Inactive) logged work - 21/Sep/17 01:14 AM
            • Time Spent:
              5.5h
               

              Analysis

            snehal.katkar Snehal Katkar (Inactive) logged work - 22/Sep/17 06:35 AM
            • Time Spent:
              8h
               

              Analysis, coding

            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Dev Due Date 21/Sep/2017 25/Sep/2017
            snehal.katkar Snehal Katkar (Inactive) logged work - 23/Sep/17 06:35 AM - edited
            • Time Spent:
              10h
               
              <No comment>
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Assignee snehal katkar [ snehal.katkar ] Jaideep Vinchurkar [ jaideep.vinchurkar ]
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204) Parent values: Development(10200)Level 1 values: Ready for Review(10208)
            Hide
            snehal.katkar Snehal Katkar (Inactive) added a comment -

            Files Having Changes:

            1)\trunk\WORKTERRAweb\App\BusinessLogic\ImportExportDTS\ExecuteImportDTS.vb
            2)\trunk\WORKTERRAweb\App\BusinessLogic\ImportExportDTS\ImportEmployeeEnrollment.vb
            3)\trunk\WORKTERRAweb\Web\Web Projects\WORKTERRA\Areas\Customization\Controllers\EDI\ImportExportBaseController.cs
            4)\trunk\WORKTERRAweb\Web\Web Projects\WORKTERRA\Areas\Customization\Models\EDI\ImportExportRecordDetails.cs
            5)\trunk\WORKTERRAweb\Web\Web Projects\WORKTERRA\Areas\Customization\Models\EDI\ManualImportExportModel.cs

            Changes:

            1) Removed calls to functions which accesses 'ImportExportRecordSummary' table to insert and fetch the data
            2) Created separate variables to store total no of records and total no of valid records. Added these values to 'CompanyWiseAsyncRoutineInfoHash'
            3) Displayed record counts on UI using hash 'CompanyWiseAsyncRoutineInfoHash'.

            Show
            snehal.katkar Snehal Katkar (Inactive) added a comment - Files Having Changes: 1)\trunk\WORKTERRAweb\App\BusinessLogic\ImportExportDTS\ExecuteImportDTS.vb 2)\trunk\WORKTERRAweb\App\BusinessLogic\ImportExportDTS\ImportEmployeeEnrollment.vb 3)\trunk\WORKTERRAweb\Web\Web Projects\WORKTERRA\Areas\Customization\Controllers\EDI\ImportExportBaseController.cs 4)\trunk\WORKTERRAweb\Web\Web Projects\WORKTERRA\Areas\Customization\Models\EDI\ImportExportRecordDetails.cs 5)\trunk\WORKTERRAweb\Web\Web Projects\WORKTERRA\Areas\Customization\Models\EDI\ManualImportExportModel.cs Changes: 1) Removed calls to functions which accesses 'ImportExportRecordSummary' table to insert and fetch the data 2) Created separate variables to store total no of records and total no of valid records. Added these values to 'CompanyWiseAsyncRoutineInfoHash' 3) Displayed record counts on UI using hash 'CompanyWiseAsyncRoutineInfoHash'.
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) logged work - 23/Sep/17 03:19 PM
            • Time Spent:
              0.5h
               
              <No comment>
            Hide
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) added a comment -

            Good to check in

            Show
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) added a comment - Good to check in
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Assignee Jaideep Vinchurkar [ jaideep.vinchurkar ] snehal katkar [ snehal.katkar ]
            Code Review Date 23/Sep/2017
            Code Reviewed By Jaideep Vinchurkar [ 11908 ]
            QA Jayshree Nagpure [ jayshree.nagpure ]
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Remaining Estimate 12h [ 43200 ] 11.5h [ 41400 ]
            Time Spent 0.5h [ 1800 ]
            Worklog Id 80804 [ 80804 ]
            snehal.katkar Snehal Katkar (Inactive) logged work - 24/Sep/17 06:35 AM
            • Time Spent:
              4h
               

              Code changes, code check in, jira update, discussion with Jaideep and Suraj

            Hide
            snehal.katkar Snehal Katkar (Inactive) added a comment -

            Concern: Import Record summary should have unique identification

            Impacted Areas:
            1) Manual Import (Sync/Async)
            2) Re-Import

            Scenarios to check:
            1) Bad record count, total record count, valid record count should be correct
            2) Bad file should be able to download

            Show
            snehal.katkar Snehal Katkar (Inactive) added a comment - Concern: Import Record summary should have unique identification Impacted Areas: 1) Manual Import (Sync/Async) 2) Re-Import Scenarios to check: 1) Bad record count, total record count, valid record count should be correct 2) Bad file should be able to download
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Remaining Estimate 11.5h [ 41400 ] 6h [ 21600 ]
            Time Spent 0.5h [ 1800 ] 6h [ 21600 ]
            Worklog Id 81123 [ 81123 ]
            snehal.katkar Snehal Katkar (Inactive) logged work - 26/Sep/17 06:37 AM - edited
            • Time Spent:
              6h
               

              code changes, code check in, testing

            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Assignee snehal katkar [ snehal.katkar ] Jayshree Nagpure [ jayshree.nagpure ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Production Due Date 12/Oct/2017
            Stage Due Date 9/Oct/17 [ 2017-10-09 ]
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Remaining Estimate 6h [ 21600 ] 0h [ 0 ]
            Time Spent 6h [ 21600 ] 14h [ 50400 ]
            Worklog Id 82106 [ 82106 ]
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Time Spent 14h [ 50400 ] 22h [ 79200 ]
            Worklog Id 82107 [ 82107 ]
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Time Spent 22h [ 79200 ] 26h [ 93600 ]
            Worklog Id 82108 [ 82108 ]
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Time Spent 26h [ 93600 ] 31h [ 111600 ]
            Worklog Id 82109 [ 82109 ]
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Time Spent 31h [ 111600 ] 32h [ 115200 ]
            Worklog Id 82109 [ 82109 ]
            snehal.katkar Snehal Katkar (Inactive) made changes -
            Time Spent 32h [ 115200 ] 34h [ 122400 ]
            Worklog Id 82107 [ 82107 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 29/Sep/17 08:13 AM
            • Time Spent:
              1h
               

              LB Testing

            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Snehal Katkar,

            Verified on LB
            Company - QA ASML for hspl

            Verified below scenario
            1)Bad Record count - PAss
            2)Total imported record count - Pass
            3)Bad file download - Pass
            4)When bad file is generated, re-imported data - Pass
            5)Valid record count for all scenario - PAss
            6)Verified all above scenario for syn and Async manual import
            7)Verified all scenario for company and global level import
            8)Verified Import type -> Employee import, spouse import, child import , Election data import and waive import

            All above mentioned scenarios are working fine
            Hence marking item state as Ready for stage.

            Thanks,
            Jayshree

            cc : Rakesh Roy Prasad Pise

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Snehal Katkar , Verified on LB Company - QA ASML for hspl Verified below scenario 1)Bad Record count - PAss 2)Total imported record count - Pass 3)Bad file download - Pass 4)When bad file is generated, re-imported data - Pass 5)Valid record count for all scenario - PAss 6)Verified all above scenario for syn and Async manual import 7)Verified all scenario for company and global level import 8)Verified Import type -> Employee import, spouse import, child import , Election data import and waive import All above mentioned scenarios are working fine Hence marking item state as Ready for stage. Thanks, Jayshree cc : Rakesh Roy Prasad Pise
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Time Spent 34h [ 122400 ] 35h [ 126000 ]
            Worklog Id 82574 [ 82574 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Snehal Katkar,

            Verified Demographics and dependent import on stage,
            Company - Je dunn for hspl, city of durham for hspl,
            Symphony for hspl, city of bellevue for hspl

            But Import is getting fail , could not verify as its blocked due to : WT-11623

            Error Log : ErrorID : 0
            ErrorSource : ControllerAppTier.SaveAndGetData->WORKTERRAControllerAppTier.SaveAndGetData->ExecuteImportDTS.ImportData_Isolated->WTIsolatedRoutines.Main->ExecuteImportDTS.ImportData->ImportValidation.ImportData->ImportValidation.GetUniqueUserNameHashTable
            ErrorMessage: Item has already been added. Key in dictionary: 'abc05011990test' Key being added: 'abc05011990test'
            StackTrace: at WORKTERRA.Shared.WORKTERRAControllerAppTier.SaveAndGetData(WORKTERRAControllerWebTierEntity objWORKTERRAControllerWebTierEntity)
            at WORKTERRA.ControllerAppTier.SaveAndGetData(Int32 intProjectsId, String strInput)
            TargetSite: System.String SaveAndGetData(WORKTERRA.Shared.WORKTERRAControllerWebTierEntity)

            Hence Marking this jira as Stage QA on Hold,
            We will verify once WT-11623 will deploy on stage.

            Thanks,
            Jayshree

            cc : Rakesh Roy Prasad Pise Jaideep Vinchurkar

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Snehal Katkar , Verified Demographics and dependent import on stage, Company - Je dunn for hspl, city of durham for hspl, Symphony for hspl, city of bellevue for hspl But Import is getting fail , could not verify as its blocked due to : WT-11623 Error Log : ErrorID : 0 ErrorSource : ControllerAppTier.SaveAndGetData->WORKTERRAControllerAppTier.SaveAndGetData->ExecuteImportDTS.ImportData_Isolated->WTIsolatedRoutines.Main->ExecuteImportDTS.ImportData->ImportValidation.ImportData->ImportValidation.GetUniqueUserNameHashTable ErrorMessage: Item has already been added. Key in dictionary: 'abc05011990test' Key being added: 'abc05011990test' StackTrace: at WORKTERRA.Shared.WORKTERRAControllerAppTier.SaveAndGetData(WORKTERRAControllerWebTierEntity objWORKTERRAControllerWebTierEntity) at WORKTERRA.ControllerAppTier.SaveAndGetData(Int32 intProjectsId, String strInput) TargetSite: System.String SaveAndGetData(WORKTERRA.Shared.WORKTERRAControllerWebTierEntity) Hence Marking this jira as Stage QA on Hold, We will verify once WT-11623 will deploy on stage. Thanks, Jayshree cc : Rakesh Roy Prasad Pise Jaideep Vinchurkar
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: On Hold(10215)
            jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 23/Oct/17 11:53 AM
            • Time Spent:
              1.5h
               

              Testing on Stage
              Discussion with Snehal

            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Time Spent 35h [ 126000 ] 36.5h [ 131400 ]
            Worklog Id 85804 [ 85804 ]
            vishal.bajad Vishal Bajad (Inactive) made changes -
            Link This issue causes WT-11762 [ WT-11762 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Resolution Unresolved [ 10200 ]
            Status Stage Testing [ 10201 ] Reopen in Stage [ 10023 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Status Reopen in Stage [ 10023 ] In Development [ 10007 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            Hide
            snehal.katkar Snehal Katkar (Inactive) added a comment -

            Hi Jayshree Nagpure,

            As discussed, I have reverted this patch from stage. Please check and let me know in case of any issues.

            cc: Rakesh Roy, Jaideep Vinchurkar

            Show
            snehal.katkar Snehal Katkar (Inactive) added a comment - Hi Jayshree Nagpure , As discussed, I have reverted this patch from stage. Please check and let me know in case of any issues. cc: Rakesh Roy , Jaideep Vinchurkar
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Snehal Katkar,

            Import working fine on stage
            Hence marking item state as Ready for Stage.

            Thanks,
            Jayshree

            cc : Rakesh Roy Prasad Pise

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Snehal Katkar , Import working fine on stage Hence marking item state as Ready for Stage. Thanks, Jayshree cc : Rakesh Roy Prasad Pise
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: On Hold(10215) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Labels Manual_import
            satyap Satya made changes -
            Environment_New Production [ 18442 ]
            gaurav.sodani Gaurav Sodani (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: LB QA(10201)Level 1 values: On Hold(10211)
            Transition Time In Source Status Execution Times
            Snehal Katkar (Inactive) made transition -
            Open In Development
            20d 2h 5m 1
            Jayshree Nagpure (Inactive) made transition -
            In LB Testing Stage Testing
            25d 18h 21m 1
            Jayshree Nagpure (Inactive) made transition -
            Stage Testing Reopened in Stage
            2d 19h 44m 1
            Jayshree Nagpure (Inactive) made transition -
            Reopened in Stage In Development
            3s 1
            Jayshree Nagpure (Inactive) made transition -
            In Development In LB Testing
            7d 7h 18m 2

              People

              Assignee:
              jayshree.nagpure Jayshree Nagpure (Inactive)
              Reporter:
              suraj.sokasane Suraj Sokasane (Inactive)
              Developer:
              Snehal Katkar (Inactive)
              QA:
              Jayshree Nagpure (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Dev Due Date:
                Pre-Prod Due Date:
                Production Due Date:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 12h Original Estimate - 12h
                  12h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 36.5h
                  36.5h