Uploaded image for project: 'WORKTERRA'
  1. WORKTERRA
  2. WT-11882

Import Add Employee: enable/disable flag on Email message format

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: BenAdmin
    • Environment:
      Production
    • Bug Type:
      Functional
    • Bug Severity:
      Critical
    • Module:
      BenAdmin - Import
    • Reported by:
      Client
    • Company:
      County of San Luis Obispo
    • Item State:
      Production Complete - Closed
    • Sprint:
      WT Sprint 40 - Bugs

      Description

      1. Why was email sent out to employee, when for ‘Add Employee’ – Email status has been disabled. These employees have been loaded to system through Import
      2. Why was email sent our as ‘From’ email address – admin@workterra.net All emails for BCC should be sent out through admin@benxcel.net address.

      CC : Satya Samir Bharti Satpute Gaurav Sodani

        Attachments

          Issue Links

            Activity

            swapnil.pandhare Swapnil Pandhare (Inactive) created issue -
            Hide
            swapnil.pandhare Swapnil Pandhare (Inactive) added a comment - - edited

            CC : Satya Samir

            Hi Satya ,

            Please find the details below :
            1. Concern: Why was email sent out to employee, when for ‘Add Employee’ – Email status has been disabled. These employees have been loaded to system through Import.
            Cause : While sending email to employee through import, Email message category Send Email flag is not checked.
            Correction : We need to add check for Email category send email flag before sending to following function : SendNotificationMailToEmployeeForUserCredentials

            2. Concern : Why was email sent our as ‘From’ email address – admin@workterra.net All emails for BCC should be sent out through admin@benxcel.net address.
            Cause : SLO company is not added in benexcel list. So, admin email address is not getting replaced.
            Correction : We have added SLO company id in OES_SP_Send_CdoSysMail SP for which from email id will be “admin@benxcel.net”

            Thanks,
            Swapnil P.

            Show
            swapnil.pandhare Swapnil Pandhare (Inactive) added a comment - - edited CC : Satya Samir Hi Satya , Please find the details below : 1. Concern : Why was email sent out to employee, when for ‘Add Employee’ – Email status has been disabled. These employees have been loaded to system through Import. Cause : While sending email to employee through import, Email message category Send Email flag is not checked. Correction : We need to add check for Email category send email flag before sending to following function : SendNotificationMailToEmployeeForUserCredentials 2. Concern : Why was email sent our as ‘From’ email address – admin@workterra.net All emails for BCC should be sent out through admin@benxcel.net address. Cause : SLO company is not added in benexcel list. So, admin email address is not getting replaced. Correction : We have added SLO company id in OES_SP_Send_CdoSysMail SP for which from email id will be “admin@benxcel.net” Thanks, Swapnil P.
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Field Original Value New Value
            Assignee Swapnil Pandhare [ swapnil.pandhare ] Jaideep Vinchurkar [ jaideep.vinchurkar ]
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Status Open [ 1 ] In Development [ 10007 ]
            satyap Satya made changes -
            satyap Satya made changes -
            Attachment FW BCC Groups.msg [ 66262 ]
            Hide
            satyap Satya added a comment -

            Attached are two emails received from Debbie for this issue.

            Hi Debbie Kulling,

            Please find updated comments from Development on SLO issues reported today. We will handle this in Import code.

            For Workaround: you can set Company Information - Receive Email flag as 'No' so this will ensure there are not emails sent out for next import in the system.

            Regards,
            Satya Prakash

            Cc: Jaideep Vinchurkar Swapnil Pandhare Gaurav Sodani Rakesh Roy Bharti Satpute Jennifer Reed Suraj Sokasane

            Show
            satyap Satya added a comment - Attached are two emails received from Debbie for this issue. Hi Debbie Kulling , Please find updated comments from Development on SLO issues reported today. We will handle this in Import code. For Workaround: you can set Company Information - Receive Email flag as 'No' so this will ensure there are not emails sent out for next import in the system. Regards, Satya Prakash Cc: Jaideep Vinchurkar Swapnil Pandhare Gaurav Sodani Rakesh Roy Bharti Satpute Jennifer Reed Suraj Sokasane
            Hide
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) added a comment -

            Please look into issue #1

            Show
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) added a comment - Please look into issue #1
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Assignee Jaideep Vinchurkar [ jaideep.vinchurkar ] Suraj Sokasane [ suraj.sokasane ]
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Assignee Suraj Sokasane [ suraj.sokasane ] Vishal Bajad [ vishal.bajad ]
            Hide
            vishal.bajad Vishal Bajad (Inactive) added a comment -

            Hi All ,

            Please find details as below ,
            Concern : Why was email sent out to employee, when for ‘Add Employee’ – Email status has been disabled. These employees have been loaded to system through Import.

            Cause : While sending email to employee through import, Email message category Send Email flag is not checked.

            Correction : We have added Email category send email flag before sending email to users

            Impacted Area : Email for Login Credentials will be send , when Receive Email flag set From Company info , Employee level Receive Email and Email category Send Message flag set to yes.

            Test Scenario:

            • Email will not send if any one from received email flag set to No
            • Email will get send if all received email flag set to Yes

            Affected Files :

            • OES_SP_Import_SendUserCredentialNotifications

            Jaideep Vinchurkar : As i am facing issue with SVN , Please review the script that need to be check in to Trunk and LB. Script share in separate mail.

            Thanks !

            Show
            vishal.bajad Vishal Bajad (Inactive) added a comment - Hi All , Please find details as below , Concern : Why was email sent out to employee, when for ‘Add Employee’ – Email status has been disabled. These employees have been loaded to system through Import. Cause : While sending email to employee through import, Email message category Send Email flag is not checked. Correction : We have added Email category send email flag before sending email to users Impacted Area : Email for Login Credentials will be send , when Receive Email flag set From Company info , Employee level Receive Email and Email category Send Message flag set to yes. Test Scenario : Email will not send if any one from received email flag set to No Email will get send if all received email flag set to Yes Affected Files : OES_SP_Import_SendUserCredentialNotifications Jaideep Vinchurkar : As i am facing issue with SVN , Please review the script that need to be check in to Trunk and LB. Script share in separate mail. Thanks !
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) logged work - 31/Oct/17 01:10 PM
            • Time Spent:
              1h
               
              <No comment>
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Code Review Date 31/Oct/2017
            Code Reviewed By Jaideep Vinchurkar [ 11908 ]
            Developer Vishal Bajad [ vishal.bajad ]
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206) Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209)
            QA Jayshree Nagpure [ jayshree.nagpure ]
            Root Cause Bug [ 18430 ]
            Sprint WT Sprint 40 - Bugs [ 94 ]
            Remaining Estimate 10h [ 36000 ]
            Original Estimate 10h [ 36000 ]
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Remaining Estimate 10h [ 36000 ] 9h [ 32400 ]
            Time Spent 1h [ 3600 ]
            Worklog Id 88340 [ 88340 ]
            Hide
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) added a comment -

            Code is reviewed and checked-in in Trunk and LB

            Show
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) added a comment - Code is reviewed and checked-in in Trunk and LB
            vishal.bajad Vishal Bajad (Inactive) logged work - 31/Oct/17 02:06 PM
            • Time Spent:
              4h
               
              <No comment>
            vishal.bajad Vishal Bajad (Inactive) made changes -
            Remaining Estimate 9h [ 32400 ] 5h [ 18000 ]
            Time Spent 1h [ 3600 ] 5h [ 18000 ]
            Worklog Id 88395 [ 88395 ]
            vishal.bajad Vishal Bajad (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            vishal.bajad Vishal Bajad (Inactive) made changes -
            Assignee Vishal Bajad [ vishal.bajad ] Jaideep Vinchurkar [ jaideep.vinchurkar ]
            Hide
            satyap Satya added a comment -

            @Rakesh: #2 from above list has been done by Ashwin Wankhede. Can you please get this verified for all BCC group companies?

            Regards,
            Satay Prakash

            Cc: Samir Jaideep Vinchurkar Gaurav SodaniPrasad PiseHrishikesh Deshpande Sachin Hingole

            Show
            satyap Satya added a comment - @Rakesh: #2 from above list has been done by Ashwin Wankhede . Can you please get this verified for all BCC group companies? Regards, Satay Prakash Cc: Samir Jaideep Vinchurkar Gaurav Sodani Prasad Pise Hrishikesh Deshpande Sachin Hingole
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Local Testing(10209) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) made changes -
            Assignee Jaideep Vinchurkar [ jaideep.vinchurkar ] Jayshree Nagpure [ jayshree.nagpure ]
            satyap Satya made changes -
            Labels Email_Notifications
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
            jyotibala Jyotibala Pardeshi (Inactive) logged work - 02/Nov/17 09:25 AM - edited
            • Time Spent:
              1.5h
               

              Internal discussion with Hrishikesh, Gaurav, Ashwin and Sheetal.
              Did the stored procedure changes.
              Executed script on LB.
              Discussion with Jayashree on email functionality.
              reverted changes from LB and verified with jayashree.

            jyotibala Jyotibala Pardeshi (Inactive) made changes -
            Remaining Estimate 5h [ 18000 ] 4.25h [ 15300 ]
            Time Spent 5h [ 18000 ] 5.75h [ 20700 ]
            Worklog Id 88748 [ 88748 ]
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited

            Hi Swapnil Pandhare,

            Verified On LB
            Company - For QA CAISO For hspl.

            Verified below scenario for #1 Point : - Working fine
            1)Verified For Only ADD EMPLOYEE through import.
            2)Email for Login Credentials send , when Receive Email flag set From Company info , Employee level Receive Email and Email category Send Message flag set to yes.- Email received
            3)Add employee "Receive email" is set as No and other remaining two flag is YES - Mail not received
            4)Email message format - No, Other two remaining flag set to yes- Mail not received
            5)system setting -NO and other remaining two flag YES - Mail not received
            6)Verified for One employee
            7)Verified for Multiple employee

            Verified Sender address for #2 Point
            Its also corrected.
            Updated as "Sender: admin@benxcel.net"

            Working fine as expected.

            Marking item state as Ready for Stage

            Thanks,
            Jayshree

            cc : Rakesh Roy Prasad Pise Jaideep Vinchurkar Hrishikesh Deshpande

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited Hi Swapnil Pandhare , Verified On LB Company - For QA CAISO For hspl. Verified below scenario for #1 Point : - Working fine 1)Verified For Only ADD EMPLOYEE through import. 2)Email for Login Credentials send , when Receive Email flag set From Company info , Employee level Receive Email and Email category Send Message flag set to yes.- Email received 3)Add employee "Receive email" is set as No and other remaining two flag is YES - Mail not received 4)Email message format - No, Other two remaining flag set to yes- Mail not received 5)system setting -NO and other remaining two flag YES - Mail not received 6)Verified for One employee 7)Verified for Multiple employee Verified Sender address for #2 Point Its also corrected. Updated as "Sender: admin@benxcel.net" Working fine as expected. Marking item state as Ready for Stage Thanks, Jayshree cc : Rakesh Roy Prasad Pise Jaideep Vinchurkar Hrishikesh Deshpande
            jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 02/Nov/17 01:38 PM
            • Time Spent:
              2.5h
               

              Testing on LB
              Discussion with Dev
              Follow up with Ashwin and Jyotibala for Email trigger notification

            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Remaining Estimate 4.25h [ 15300 ] 1.75h [ 6300 ]
            Time Spent 5.75h [ 20700 ] 8.25h [ 29700 ]
            Worklog Id 88871 [ 88871 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Attachment EmailSender.txt [ 66668 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213)
            jyotibala Jyotibala Pardeshi (Inactive) made changes -
            Remaining Estimate 1.75h [ 6300 ] 0.5h [ 1800 ]
            Time Spent 8.25h [ 29700 ] 9.5h [ 34200 ]
            Worklog Id 88748 [ 88748 ]
            jyotibala Jyotibala Pardeshi (Inactive) made changes -
            Remaining Estimate 0.5h [ 1800 ] 1h [ 3600 ]
            Time Spent 9.5h [ 34200 ] 9h [ 32400 ]
            Worklog Id 88748 [ 88748 ]
            satyap Satya made changes -
            Environment_New Production [ 18442 ]
            satyap Satya made changes -
            Summary FW: BenXcel 2.0 Login Credentials - SLO - URGENT!! Import Add Employee - consider Email message format Enable/disable flag
            satyap Satya made changes -
            Summary Import Add Employee - consider Email message format Enable/disable flag Import Add Employee - consider Email message format enable/disable flag
            satyap Satya made changes -
            Summary Import Add Employee - consider Email message format enable/disable flag Import Add Employee: enable/disable flag on Email message format
            gaurav.sodani Gaurav Sodani (Inactive) made changes -
            Developer Vishal Bajad [ vishal.bajad ] Jaideep Vinchurkar [ jaideep.vinchurkar ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: Ready for Stage(10213) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Verified On Stage
            Company - Symphony For hspl.

            Verified below scenario for #1 Point : - Working fine
            1)Verified For Only ADD EMPLOYEE through import.
            2)Email for Login Credentials send , when Receive Email flag set From Company info , Employee level Receive Email and Email category Send Message flag set to yes.- Email received
            3)Add employee "Receive email" is set as No and other remaining two flag is YES - Mail not received
            4)Email message format - No, Other two remaining flag set to yes- Mail not received
            5)system setting -NO and other remaining two flag YES - Mail not received
            6)Verified for One employee
            7)Verified for Multiple employee

            For Point #2 - As discussed with Hrishikesh Deshpande, to changes sender's address its not in scope.
            Will check on Production
            Point #1 - Working fine

            Thanks,
            Jayshree

            cc : Rakesh Roy Prasad Pise Hrishikesh Deshpande

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Verified On Stage Company - Symphony For hspl. Verified below scenario for #1 Point : - Working fine 1)Verified For Only ADD EMPLOYEE through import. 2)Email for Login Credentials send , when Receive Email flag set From Company info , Employee level Receive Email and Email category Send Message flag set to yes.- Email received 3)Add employee "Receive email" is set as No and other remaining two flag is YES - Mail not received 4)Email message format - No, Other two remaining flag set to yes- Mail not received 5)system setting -NO and other remaining two flag YES - Mail not received 6)Verified for One employee 7)Verified for Multiple employee For Point #2 - As discussed with Hrishikesh Deshpande , to changes sender's address its not in scope. Will check on Production Point #1 - Working fine Thanks, Jayshree cc : Rakesh Roy Prasad Pise Hrishikesh Deshpande
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217)
            jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 14/Nov/17 01:11 PM
            • Time Spent:
              2h
               

              Stage testing

            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Remaining Estimate 1h [ 3600 ] 0h [ 0 ]
            Time Spent 9h [ 32400 ] 11h [ 39600 ]
            Worklog Id 90790 [ 90790 ]
            Hide
            gaurav.sodani Gaurav Sodani (Inactive) added a comment -

            Hi All,
            Attaching development approval email to work on this ticket: Unable to embed resource: FW Development approval for Bugs reported in November 1st week.msg of type application/octet-stream
            Regards
            Gaurav

            Show
            gaurav.sodani Gaurav Sodani (Inactive) added a comment - Hi All, Attaching development approval email to work on this ticket: Unable to embed resource: FW Development approval for Bugs reported in November 1st week.msg of type application/octet-stream Regards Gaurav
            gaurav.sodani Gaurav Sodani (Inactive) made changes -
            Production Due Date 25/Nov/2017
            gaurav.sodani Gaurav Sodani (Inactive) made changes -
            Hide
            gaurav.sodani Gaurav Sodani (Inactive) added a comment -

            Hi All,
            Attaching production deployment approval email for reference:
            Unable to embed resource: Re Request for Production deployment - 25 Nov 2017.msg of type application/octet-stream
            Regards
            Gaurav

            Show
            gaurav.sodani Gaurav Sodani (Inactive) added a comment - Hi All, Attaching production deployment approval email for reference: Unable to embed resource: Re Request for Production deployment - 25 Nov 2017.msg of type application/octet-stream Regards Gaurav
            gaurav.sodani Gaurav Sodani (Inactive) made changes -
            Approval status Approved for production deployment [ 18457 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Ready for Production(10217) Parent values: Production QA(10203)Level 1 values: Production Deployed(10221)
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: Production QA(10203)Level 1 values: Production Deployed(10221) Parent values: Production QA(10203)Level 1 values: In Testing(10218)
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Status Stage Testing [ 10201 ] Production Testing [ 10202 ]
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Verified On Production
            Company - ASML for hspl.
            Verified below scenario for #1 Point : - Working fine
            1)Verified For Only ADD EMPLOYEE through import.
            2)Email for Login Credentials send , when Receive Email flag set From Company info , Employee level Receive Email and Email category Send Message flag set to yes.- Email received
            3)Add employee "Receive email" is set as No and other remaining two flag is YES - Mail not received
            4)Email message format - No, Other two remaining flag set to yes- Mail not received
            5)system setting -NO and other remaining two flag YES - Mail not received
            6)Verified for One employee
            7)Verified for Multiple employee

            For Pint #2 ; Its already tested on Production

            Thanks,
            Jayshree

            cc :Rakesh Roy Prasad PiseHrishikesh Deshpande

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Verified On Production Company - ASML for hspl. Verified below scenario for #1 Point : - Working fine 1)Verified For Only ADD EMPLOYEE through import. 2)Email for Login Credentials send , when Receive Email flag set From Company info , Employee level Receive Email and Email category Send Message flag set to yes.- Email received 3)Add employee "Receive email" is set as No and other remaining two flag is YES - Mail not received 4)Email message format - No, Other two remaining flag set to yes- Mail not received 5)system setting -NO and other remaining two flag YES - Mail not received 6)Verified for One employee 7)Verified for Multiple employee For Pint #2 ; Its already tested on Production Thanks, Jayshree cc : Rakesh Roy Prasad Pise Hrishikesh Deshpande
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Item State Parent values: Production QA(10203)Level 1 values: In Testing(10218) Parent values: Production Complete(10222)Level 1 values: Closed(10223)
            jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 28/Nov/17 12:55 PM
            • Time Spent:
              1h
               

              Production testing

            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Resolution Fixed [ 1 ]
            Status Production Testing [ 10202 ] Production Complete [ 10028 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Time Spent 11h [ 39600 ] 12h [ 43200 ]
            Worklog Id 93259 [ 93259 ]
            jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
            Status Production Complete [ 10028 ] Closed [ 6 ]
            Ganesh.sadawarte Ganesh Sadawarte (Inactive) made changes -
            Link This issue relates to NF-5866 [ NF-5866 ]
            Transition Time In Source Status Execution Times
            Swapnil Pandhare (Inactive) made transition -
            Open In Development
            35m 59s 1
            Vishal Bajad (Inactive) made transition -
            In Development In LB Testing
            16h 38m 1
            Jayshree Nagpure (Inactive) made transition -
            In LB Testing Stage Testing
            13d 15h 38m 1
            Jayshree Nagpure (Inactive) made transition -
            Stage Testing In Production Testing
            14d 19m 1
            Jayshree Nagpure (Inactive) made transition -
            In Production Testing Production Complete
            7h 50m 1
            Jayshree Nagpure (Inactive) made transition -
            Production Complete Closed
            23h 10m 1

              People

              Assignee:
              jayshree.nagpure Jayshree Nagpure (Inactive)
              Reporter:
              swapnil.pandhare Swapnil Pandhare (Inactive)
              Developer:
              Jaideep Vinchurkar (Inactive)
              QA:
              Jayshree Nagpure (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Production Due Date:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 10h Original Estimate - 10h
                  10h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 12h
                  12h