Uploaded image for project: 'WORKTERRA'
  1. WORKTERRA
  2. WT-3873

Verify OR logical condition with single quote for SQL Injection

    Details

    • Type: Enhancement
    • Status: Closed
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: BenAdmin
    • Labels:
      None
    • Module:
      BenAdmin - Security
    • Reported by:
      Support
    • Item State:
      Production Complete - Closed

      Description

      We need to verify OR condition for SQL injection. Scenario which was tried to save is as mentioned below-

      asdf' OR '1'='1

      We have verified OR with single quote and at least one space before and after OR.

        Attachments

        1. image006.png
          image006.png
          0.7 kB
        2. WT-3873.doc
          268 kB

          Activity

          vijayendra Vijayendra Shinde (Inactive) created issue -
          Hide
          vijayendra Vijayendra Shinde (Inactive) added a comment -

          Affected Files:

          /branches/LB/Config Files WT Stage/Web Server/Web.config
          /branches/LB/Web/SharedFunctionWebTier/SharedFunctionWebTier/Modules/CustomModelBinder.cs

          Show
          vijayendra Vijayendra Shinde (Inactive) added a comment - Affected Files: /branches/LB/Config Files WT Stage/Web Server/Web.config /branches/LB/Web/SharedFunctionWebTier/SharedFunctionWebTier/Modules/CustomModelBinder.cs
          vijayendra Vijayendra Shinde (Inactive) made changes -
          Field Original Value New Value
          Assignee Vijay Siddha [ vijays ] Deepali Tidke [ deepalit ]
          vijayendra Vijayendra Shinde (Inactive) made changes -
          Status New Request [ 10029 ] Pending for Approval [ 10002 ]
          vijayendra Vijayendra Shinde (Inactive) made changes -
          Status Pending for Approval [ 10002 ] Approved for Development [ 10003 ]
          vijayendra Vijayendra Shinde (Inactive) made changes -
          Status Approved for Development [ 10003 ] In Development [ 10007 ]
          gokul.sonawane Gokul Sonawane (Inactive) made changes -
          Item State Parent values: LB QA(10201) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
          deepalit Deepali Tidke (Inactive) made changes -
          Status In Development [ 10007 ] Local Testing [ 10200 ]
          Hide
          deepalit Deepali Tidke (Inactive) added a comment - - edited

          need discussion before starting this patch, will start from monday

          Show
          deepalit Deepali Tidke (Inactive) added a comment - - edited need discussion before starting this patch, will start from monday
          Hide
          deepalit Deepali Tidke (Inactive) added a comment -

          checked following pages:

          -Plan Design [check for all benefit types]
          -Form Builder pages creation flow

          Will check few more pages tomorrow and will update the jira

          Show
          deepalit Deepali Tidke (Inactive) added a comment - checked following pages: -Plan Design [check for all benefit types] -Form Builder pages creation flow Will check few more pages tomorrow and will update the jira
          Hide
          deepalit Deepali Tidke (Inactive) added a comment -

          Also, checked following pages:

          -Add/Change? Benefit Plans
          -Benefit Type Builder
          -Employee self serve mode
          -export/import template local & global
          l-anding pages
          -rates page
          -Pages which accepts email id like TemplateSettings , TemplateDelivery
          -Company information pages
          -email format message page

          Show
          deepalit Deepali Tidke (Inactive) added a comment - Also, checked following pages: -Add/Change? Benefit Plans -Benefit Type Builder -Employee self serve mode -export/import template local & global l-anding pages -rates page -Pages which accepts email id like TemplateSettings , TemplateDelivery -Company information pages -email format message page
          deepalit Deepali Tidke (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
          Hide
          deepalit Deepali Tidke (Inactive) added a comment -

          testing is done on lb , we will make it ready for stage once security testing gets completed by Rupali W.

          Show
          deepalit Deepali Tidke (Inactive) added a comment - testing is done on lb , we will make it ready for stage once security testing gets completed by Rupali W.
          prasadp Prasad Pise (Inactive) made changes -
          Attachment WT-3873.doc [ 24007 ]
          Hide
          prasadp Prasad Pise (Inactive) added a comment -

          Testing is still in progress. Please refer attached doc for tested areas till now WT-3873.doc

          Show
          prasadp Prasad Pise (Inactive) added a comment - Testing is still in progress. Please refer attached doc for tested areas till now WT-3873.doc
          Hide
          deepalit Deepali Tidke (Inactive) added a comment -

          Prasad Pise kindly update.

          Show
          deepalit Deepali Tidke (Inactive) added a comment - Prasad Pise kindly update.
          prasadp Prasad Pise (Inactive) made changes -
          Attachment WT-3873.doc [ 24007 ]
          prasadp Prasad Pise (Inactive) made changes -
          Attachment WT-3873.doc [ 24507 ]
          Hide
          prasadp Prasad Pise (Inactive) added a comment -

          I have verified few “Input Text fields” on following pages/forms in Workterra web application for the SQL Injection related issue WT-3873.
          • Company Information
          • Classes
          • Add/Update Company
          • Add Employee/Update Employee
          • Employee Demographics
          Employee Education : > Certification Information page is still prone to SQL injections as it accepts text like
          asdf' OR '1'='1
          " or ""="

          • Employee Emergency Contact
          Employment Management
          • Change Classes
          • Change Status
          • Compensation History
          • View History WT-3873.doc
          • Template Management
          • Group Template Management
          • Manual Import/Export
          Employee Self Serve Mode Could not be tested due to server error for the “Town of Cary” company

          There still some fields where input validation needs to be implemented.

          Show
          prasadp Prasad Pise (Inactive) added a comment - I have verified few “Input Text fields” on following pages/forms in Workterra web application for the SQL Injection related issue WT-3873 . • Company Information • Classes • Add/Update Company • Add Employee/Update Employee • Employee Demographics • Employee Education : > Certification Information page is still prone to SQL injections as it accepts text like asdf' OR '1'='1 " or ""=" • Employee Emergency Contact • Employment Management • Change Classes • Change Status • Compensation History • View History WT-3873.doc • Template Management • Group Template Management • Manual Import/Export • Employee Self Serve Mode Could not be tested due to server error for the “Town of Cary” company There still some fields where input validation needs to be implemented.
          Hide
          vijayendra Vijayendra Shinde (Inactive) added a comment -

          Hi Prasad Pise,

          By looking at attached snaps,
          1. We can see, asdf'OR'1'='1 string has been inserted as string value. It is not injection in SQL. With above query, sql execution will fail because there is no. space between asdf' OR '1'='1. In sql injection second boolean expression OR '1'='1 doesn't insert into database because it is logical condition.

          In case of SQL injection result sould be only asdf.

          2. On Employment management screen, when we add characters, system thrown server error. I want to get more inputs on this, how we identified this is SQL Injection error.

          3. Deepali Tidke, Prasad is facing server error while testing self serve mode. Please get this issue resolved so that he can test sql injection in self serve mode.

          CC: Samir, Rakesh Roy,

          Show
          vijayendra Vijayendra Shinde (Inactive) added a comment - Hi Prasad Pise , By looking at attached snaps, 1. We can see, asdf'OR'1'='1 string has been inserted as string value. It is not injection in SQL. With above query, sql execution will fail because there is no. space between asdf' OR '1'='1. In sql injection second boolean expression OR '1'='1 doesn't insert into database because it is logical condition. In case of SQL injection result sould be only asdf. 2. On Employment management screen, when we add characters, system thrown server error. I want to get more inputs on this, how we identified this is SQL Injection error. 3. Deepali Tidke , Prasad is facing server error while testing self serve mode. Please get this issue resolved so that he can test sql injection in self serve mode. CC: Samir , Rakesh Roy ,
          Hide
          deepalit Deepali Tidke (Inactive) added a comment -

          Prasad PiseVijayendra Shinde as of now on LB self serve mode works on only 1 company i.e. ASML comp, Prasad Pise you can check self serve mode on this company.

          CC: SamirRakesh Roy

          Show
          deepalit Deepali Tidke (Inactive) added a comment - Prasad Pise Vijayendra Shinde as of now on LB self serve mode works on only 1 company i.e. ASML comp, Prasad Pise you can check self serve mode on this company. CC: Samir Rakesh Roy
          deepalit Deepali Tidke (Inactive) made changes -
          Assignee Deepali Tidke [ deepalit ] Prasad Pise [ prasadp ]
          Hide
          samir Samir added a comment -

          Hi Prasad,

          Are we using any tool for SQL injection?

          Regards,

          Samir

          From: Vijayendra Shinde (JIRA) jira@workterra.atlassian.net
          Sent: Monday, August 22, 2016 12:17 PM
          To: samir@harbingergroup.com
          Subject: [JIRA] Vijayendra Shinde mentioned you on WT-3873 (JIRA)

          cid:image001.png@01D1FCA8.35503810

          <https://workterra.atlassian.net/secure/ViewProfile.jspa?name=vijayendra>
          Vijayendra Shinde mentioned you on
          <https://workterra.atlassian.net/browse/WT-3873> EnhancementWT-3873

          <https://workterra.atlassian.net/browse/WT-3873> Re: Verify OR logical
          condition with single quote for SQL Injection

          Hi <https://workterra.atlassian.net/secure/ViewProfile.jspa?name=prasadp>
          Prasad Pise,

          By looking at attached snaps,
          1. We can see, asdf'OR'1'='1 string has been inserted as string value. It is
          not injection in SQL. With above query, sql execution will fail because
          there is no. space between asdf' OR '1'='1. In sql injection second boolean
          expression OR '1'='1 doesn't insert into database because it is logical
          condition.

          In case of SQL injection result sould be only asdf.

          2. On Employment management screen, when we add characters, system thrown
          server error. I want to get more inputs on this, how we identified this is
          SQL Injection error.

          3. <https://workterra.atlassian.net/secure/ViewProfile.jspa?name=deepalit>
          Deepali Tidke, Prasad is facing server error while testing self serve mode.
          Please get this issue resolved so that he can test sql injection in self
          serve mode.

          CC: <https://workterra.atlassian.net/secure/ViewProfile.jspa?name=samir>
          Samir,
          <https://workterra.atlassian.net/secure/ViewProfile.jspa?name=rakeshr>
          Rakesh Roy,

          <https://workterra.atlassian.net/browse/WT-3873#add-comment> Add Comment

          <https://workterra.atlassian.net/browse/WT-3873#add-comment> Add Comment

          This message was sent by Atlassian JIRA (v1000.253.3#100011-sha1:6da8fdb)

          Atlassian logo

          Show
          samir Samir added a comment - Hi Prasad, Are we using any tool for SQL injection? Regards, Samir From: Vijayendra Shinde (JIRA) jira@workterra.atlassian.net Sent: Monday, August 22, 2016 12:17 PM To: samir@harbingergroup.com Subject: [JIRA] Vijayendra Shinde mentioned you on WT-3873 (JIRA) cid:image001.png@01D1FCA8.35503810 < https://workterra.atlassian.net/secure/ViewProfile.jspa?name=vijayendra > Vijayendra Shinde mentioned you on < https://workterra.atlassian.net/browse/WT-3873 > EnhancementWT-3873 < https://workterra.atlassian.net/browse/WT-3873 > Re: Verify OR logical condition with single quote for SQL Injection Hi < https://workterra.atlassian.net/secure/ViewProfile.jspa?name=prasadp > Prasad Pise, By looking at attached snaps, 1. We can see, asdf'OR'1'='1 string has been inserted as string value. It is not injection in SQL. With above query, sql execution will fail because there is no. space between asdf' OR '1'='1. In sql injection second boolean expression OR '1'='1 doesn't insert into database because it is logical condition. In case of SQL injection result sould be only asdf. 2. On Employment management screen, when we add characters, system thrown server error. I want to get more inputs on this, how we identified this is SQL Injection error. 3. < https://workterra.atlassian.net/secure/ViewProfile.jspa?name=deepalit > Deepali Tidke, Prasad is facing server error while testing self serve mode. Please get this issue resolved so that he can test sql injection in self serve mode. CC: < https://workterra.atlassian.net/secure/ViewProfile.jspa?name=samir > Samir, < https://workterra.atlassian.net/secure/ViewProfile.jspa?name=rakeshr > Rakesh Roy, < https://workterra.atlassian.net/browse/WT-3873#add-comment > Add Comment < https://workterra.atlassian.net/browse/WT-3873#add-comment > Add Comment This message was sent by Atlassian JIRA (v1000.253.3#100011-sha1:6da8fdb) Atlassian logo
          samir Samir made changes -
          Attachment image006.png [ 24732 ]
          Hide
          prasadp Prasad Pise (Inactive) added a comment -

          Samir, I haven't used any tool for this verification.

          Show
          prasadp Prasad Pise (Inactive) added a comment - Samir , I haven't used any tool for this verification.
          prasadp Prasad Pise (Inactive) made changes -
          Attachment WT-3873.doc [ 24507 ]
          Hide
          prasadp Prasad Pise (Inactive) added a comment -

          SamirVijayendra Shinde
          I have verified following few more pages and found issues in red marked areas.

          • Employee Self Serve Mode (ATG JE Dunn)
          • User Access Policy - > Add New Policy – Server Error when Single Quote is inserted in Policy Name field.
          • Benefit Type Builder
            *ISSUE: Text field “Benefit Type Name” shows validation message when a character (t,g,l) is present in text

          PFA updated document for more details WT-3873.doc .
          These issues needs to be fixed before moving on production environment.

          Show
          prasadp Prasad Pise (Inactive) added a comment - Samir Vijayendra Shinde I have verified following few more pages and found issues in red marked areas. Employee Self Serve Mode (ATG JE Dunn) User Access Policy - > Add New Policy – Server Error when Single Quote is inserted in Policy Name field. Benefit Type Builder *ISSUE: Text field “Benefit Type Name” shows validation message when a character (t,g,l) is present in text PFA updated document for more details WT-3873.doc . These issues needs to be fixed before moving on production environment.
          prasadp Prasad Pise (Inactive) made changes -
          Attachment WT-3873.doc [ 25623 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Assignee Prasad Pise [ prasadp ] Vijayendra Shinde [ ID10506 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status Local Testing [ 10200 ] Reopen in Local [ 10018 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: Re-open(10212)
          ashwin.wankhede Ashwin Wankhede (Inactive) made changes -
          Item State Parent values: LB QA(10201)Level 1 values: Re-open(10212) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
          ashwin.wankhede Ashwin Wankhede (Inactive) made changes -
          Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Production QA(10203)Level 1 values: Production Deployed(10221)
          vijayendra Vijayendra Shinde (Inactive) made changes -
          Assignee Vijayendra Shinde [ ID10506 ] Prasad Pise [ prasadp ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status Reopen in Local [ 10018 ] In Development [ 10007 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status In Development [ 10007 ] Local Testing [ 10200 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status Local Testing [ 10200 ] Reopen in Local [ 10018 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status Reopen in Local [ 10018 ] In Development [ 10007 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status In Development [ 10007 ] Local Testing [ 10200 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status Local Testing [ 10200 ] Pending for Stage Approval [ 10300 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status Pending for Stage Approval [ 10300 ] Approved for Stage [ 10030 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status Approved for Stage [ 10030 ] Stage Testing [ 10201 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status Stage Testing [ 10201 ] Pending for Production Approval [ 10301 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status Pending for Production Approval [ 10301 ] Approved for production [ 10034 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Status Approved for production [ 10034 ] Production Testing [ 10202 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Production Testing [ 10202 ] Production Complete [ 10028 ]
          rakeshr Rakesh Roy (Inactive) made changes -
          Item State Parent values: Production QA(10203)Level 1 values: Production Deployed(10221) Parent values: Production Complete(10222)Level 1 values: Closed(10223)
          prasadp Prasad Pise (Inactive) made changes -
          Status Production Complete [ 10028 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times
          Vijayendra Shinde (Inactive) made transition -
          New Request Pending for Approval
          26m 52s 1
          Vijayendra Shinde (Inactive) made transition -
          Pending for Approval Approved for Development
          2s 1
          Vijayendra Shinde (Inactive) made transition -
          Approved for Development In Development
          7s 1
          Rakesh Roy (Inactive) made transition -
          In LB Testing Reopen in Local
          32d 17h 27m 2
          Rakesh Roy (Inactive) made transition -
          Reopen in Local In Development
          20d 1h 24m 2
          Rakesh Roy (Inactive) made transition -
          In Development In LB Testing
          2d 2h 19m 3
          Rakesh Roy (Inactive) made transition -
          In LB Testing Pending for Stage Approval
          3s 1
          Rakesh Roy (Inactive) made transition -
          Pending for Stage Approval Approved for Stage
          3s 1
          Rakesh Roy (Inactive) made transition -
          Approved for Stage Stage Testing
          3s 1
          Rakesh Roy (Inactive) made transition -
          Stage Testing Pending for Production Approval
          4s 1
          Rakesh Roy (Inactive) made transition -
          Pending for Production Approval Approved for production
          4s 1
          Rakesh Roy (Inactive) made transition -
          Approved for production In Production Testing
          7s 1
          Rakesh Roy (Inactive) made transition -
          In Production Testing Production Complete
          49d 1h 24m 1
          Prasad Pise (Inactive) made transition -
          Production Complete Closed
          90d 4h 58m 1

            People

            Assignee:
            prasadp Prasad Pise (Inactive)
            Reporter:
            vijayendra Vijayendra Shinde (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: