Uploaded image for project: 'WORKTERRA'
  1. WORKTERRA
  2. WT-3873

Verify OR logical condition with single quote for SQL Injection

    Details

    • Type: Enhancement
    • Status: Closed
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: BenAdmin
    • Labels:
      None
    • Module:
      BenAdmin - Security
    • Reported by:
      Support
    • Item State:
      Production Complete - Closed

      Description

      We need to verify OR condition for SQL injection. Scenario which was tried to save is as mentioned below-

      asdf' OR '1'='1

      We have verified OR with single quote and at least one space before and after OR.

        Attachments

        1. image006.png
          0.7 kB
          Samir
        2. WT-3873.doc
          268 kB
          Prasad Pise

          Activity

          Hide
          vijayendra Vijayendra Shinde (Inactive) added a comment -

          Affected Files:

          /branches/LB/Config Files WT Stage/Web Server/Web.config
          /branches/LB/Web/SharedFunctionWebTier/SharedFunctionWebTier/Modules/CustomModelBinder.cs

          Show
          vijayendra Vijayendra Shinde (Inactive) added a comment - Affected Files: /branches/LB/Config Files WT Stage/Web Server/Web.config /branches/LB/Web/SharedFunctionWebTier/SharedFunctionWebTier/Modules/CustomModelBinder.cs
          Hide
          deepalit Deepali Tidke (Inactive) added a comment - - edited

          need discussion before starting this patch, will start from monday

          Show
          deepalit Deepali Tidke (Inactive) added a comment - - edited need discussion before starting this patch, will start from monday
          Hide
          deepalit Deepali Tidke (Inactive) added a comment -

          checked following pages:

          -Plan Design [check for all benefit types]
          -Form Builder pages creation flow

          Will check few more pages tomorrow and will update the jira

          Show
          deepalit Deepali Tidke (Inactive) added a comment - checked following pages: -Plan Design [check for all benefit types] -Form Builder pages creation flow Will check few more pages tomorrow and will update the jira
          Hide
          deepalit Deepali Tidke (Inactive) added a comment -

          Also, checked following pages:

          -Add/Change? Benefit Plans
          -Benefit Type Builder
          -Employee self serve mode
          -export/import template local & global
          l-anding pages
          -rates page
          -Pages which accepts email id like TemplateSettings , TemplateDelivery
          -Company information pages
          -email format message page

          Show
          deepalit Deepali Tidke (Inactive) added a comment - Also, checked following pages: -Add/Change? Benefit Plans -Benefit Type Builder -Employee self serve mode -export/import template local & global l-anding pages -rates page -Pages which accepts email id like TemplateSettings , TemplateDelivery -Company information pages -email format message page
          Hide
          deepalit Deepali Tidke (Inactive) added a comment -

          testing is done on lb , we will make it ready for stage once security testing gets completed by Rupali W.

          Show
          deepalit Deepali Tidke (Inactive) added a comment - testing is done on lb , we will make it ready for stage once security testing gets completed by Rupali W.
          Hide
          prasadp Prasad Pise (Inactive) added a comment -

          Testing is still in progress. Please refer attached doc for tested areas till now WT-3873.doc

          Show
          prasadp Prasad Pise (Inactive) added a comment - Testing is still in progress. Please refer attached doc for tested areas till now WT-3873.doc
          Hide
          deepalit Deepali Tidke (Inactive) added a comment -

          Prasad Pise kindly update.

          Show
          deepalit Deepali Tidke (Inactive) added a comment - Prasad Pise kindly update.
          Hide
          prasadp Prasad Pise (Inactive) added a comment -

          I have verified few “Input Text fields” on following pages/forms in Workterra web application for the SQL Injection related issue WT-3873.
          • Company Information
          • Classes
          • Add/Update Company
          • Add Employee/Update Employee
          • Employee Demographics
          Employee Education : > Certification Information page is still prone to SQL injections as it accepts text like
          asdf' OR '1'='1
          " or ""="

          • Employee Emergency Contact
          Employment Management
          • Change Classes
          • Change Status
          • Compensation History
          • View History WT-3873.doc
          • Template Management
          • Group Template Management
          • Manual Import/Export
          Employee Self Serve Mode Could not be tested due to server error for the “Town of Cary” company

          There still some fields where input validation needs to be implemented.

          Show
          prasadp Prasad Pise (Inactive) added a comment - I have verified few “Input Text fields” on following pages/forms in Workterra web application for the SQL Injection related issue WT-3873 . • Company Information • Classes • Add/Update Company • Add Employee/Update Employee • Employee Demographics • Employee Education : > Certification Information page is still prone to SQL injections as it accepts text like asdf' OR '1'='1 " or ""=" • Employee Emergency Contact • Employment Management • Change Classes • Change Status • Compensation History • View History WT-3873.doc • Template Management • Group Template Management • Manual Import/Export • Employee Self Serve Mode Could not be tested due to server error for the “Town of Cary” company There still some fields where input validation needs to be implemented.
          Hide
          vijayendra Vijayendra Shinde (Inactive) added a comment -

          Hi Prasad Pise,

          By looking at attached snaps,
          1. We can see, asdf'OR'1'='1 string has been inserted as string value. It is not injection in SQL. With above query, sql execution will fail because there is no. space between asdf' OR '1'='1. In sql injection second boolean expression OR '1'='1 doesn't insert into database because it is logical condition.

          In case of SQL injection result sould be only asdf.

          2. On Employment management screen, when we add characters, system thrown server error. I want to get more inputs on this, how we identified this is SQL Injection error.

          3. Deepali Tidke, Prasad is facing server error while testing self serve mode. Please get this issue resolved so that he can test sql injection in self serve mode.

          CC: Samir, Rakesh Roy,

          Show
          vijayendra Vijayendra Shinde (Inactive) added a comment - Hi Prasad Pise , By looking at attached snaps, 1. We can see, asdf'OR'1'='1 string has been inserted as string value. It is not injection in SQL. With above query, sql execution will fail because there is no. space between asdf' OR '1'='1. In sql injection second boolean expression OR '1'='1 doesn't insert into database because it is logical condition. In case of SQL injection result sould be only asdf. 2. On Employment management screen, when we add characters, system thrown server error. I want to get more inputs on this, how we identified this is SQL Injection error. 3. Deepali Tidke , Prasad is facing server error while testing self serve mode. Please get this issue resolved so that he can test sql injection in self serve mode. CC: Samir , Rakesh Roy ,
          Hide
          deepalit Deepali Tidke (Inactive) added a comment -

          Prasad PiseVijayendra Shinde as of now on LB self serve mode works on only 1 company i.e. ASML comp, Prasad Pise you can check self serve mode on this company.

          CC: SamirRakesh Roy

          Show
          deepalit Deepali Tidke (Inactive) added a comment - Prasad Pise Vijayendra Shinde as of now on LB self serve mode works on only 1 company i.e. ASML comp, Prasad Pise you can check self serve mode on this company. CC: Samir Rakesh Roy
          Hide
          samir Samir added a comment -

          Hi Prasad,

          Are we using any tool for SQL injection?

          Regards,

          Samir

          From: Vijayendra Shinde (JIRA) jira@workterra.atlassian.net
          Sent: Monday, August 22, 2016 12:17 PM
          To: samir@harbingergroup.com
          Subject: [JIRA] Vijayendra Shinde mentioned you on WT-3873 (JIRA)

          cid:image001.png@01D1FCA8.35503810

          <https://workterra.atlassian.net/secure/ViewProfile.jspa?name=vijayendra>
          Vijayendra Shinde mentioned you on
          <https://workterra.atlassian.net/browse/WT-3873> EnhancementWT-3873

          <https://workterra.atlassian.net/browse/WT-3873> Re: Verify OR logical
          condition with single quote for SQL Injection

          Hi <https://workterra.atlassian.net/secure/ViewProfile.jspa?name=prasadp>
          Prasad Pise,

          By looking at attached snaps,
          1. We can see, asdf'OR'1'='1 string has been inserted as string value. It is
          not injection in SQL. With above query, sql execution will fail because
          there is no. space between asdf' OR '1'='1. In sql injection second boolean
          expression OR '1'='1 doesn't insert into database because it is logical
          condition.

          In case of SQL injection result sould be only asdf.

          2. On Employment management screen, when we add characters, system thrown
          server error. I want to get more inputs on this, how we identified this is
          SQL Injection error.

          3. <https://workterra.atlassian.net/secure/ViewProfile.jspa?name=deepalit>
          Deepali Tidke, Prasad is facing server error while testing self serve mode.
          Please get this issue resolved so that he can test sql injection in self
          serve mode.

          CC: <https://workterra.atlassian.net/secure/ViewProfile.jspa?name=samir>
          Samir,
          <https://workterra.atlassian.net/secure/ViewProfile.jspa?name=rakeshr>
          Rakesh Roy,

          <https://workterra.atlassian.net/browse/WT-3873#add-comment> Add Comment

          <https://workterra.atlassian.net/browse/WT-3873#add-comment> Add Comment

          This message was sent by Atlassian JIRA (v1000.253.3#100011-sha1:6da8fdb)

          Atlassian logo

          Show
          samir Samir added a comment - Hi Prasad, Are we using any tool for SQL injection? Regards, Samir From: Vijayendra Shinde (JIRA) jira@workterra.atlassian.net Sent: Monday, August 22, 2016 12:17 PM To: samir@harbingergroup.com Subject: [JIRA] Vijayendra Shinde mentioned you on WT-3873 (JIRA) cid:image001.png@01D1FCA8.35503810 < https://workterra.atlassian.net/secure/ViewProfile.jspa?name=vijayendra > Vijayendra Shinde mentioned you on < https://workterra.atlassian.net/browse/WT-3873 > EnhancementWT-3873 < https://workterra.atlassian.net/browse/WT-3873 > Re: Verify OR logical condition with single quote for SQL Injection Hi < https://workterra.atlassian.net/secure/ViewProfile.jspa?name=prasadp > Prasad Pise, By looking at attached snaps, 1. We can see, asdf'OR'1'='1 string has been inserted as string value. It is not injection in SQL. With above query, sql execution will fail because there is no. space between asdf' OR '1'='1. In sql injection second boolean expression OR '1'='1 doesn't insert into database because it is logical condition. In case of SQL injection result sould be only asdf. 2. On Employment management screen, when we add characters, system thrown server error. I want to get more inputs on this, how we identified this is SQL Injection error. 3. < https://workterra.atlassian.net/secure/ViewProfile.jspa?name=deepalit > Deepali Tidke, Prasad is facing server error while testing self serve mode. Please get this issue resolved so that he can test sql injection in self serve mode. CC: < https://workterra.atlassian.net/secure/ViewProfile.jspa?name=samir > Samir, < https://workterra.atlassian.net/secure/ViewProfile.jspa?name=rakeshr > Rakesh Roy, < https://workterra.atlassian.net/browse/WT-3873#add-comment > Add Comment < https://workterra.atlassian.net/browse/WT-3873#add-comment > Add Comment This message was sent by Atlassian JIRA (v1000.253.3#100011-sha1:6da8fdb) Atlassian logo
          Hide
          prasadp Prasad Pise (Inactive) added a comment -

          Samir, I haven't used any tool for this verification.

          Show
          prasadp Prasad Pise (Inactive) added a comment - Samir , I haven't used any tool for this verification.
          Hide
          prasadp Prasad Pise (Inactive) added a comment -

          SamirVijayendra Shinde
          I have verified following few more pages and found issues in red marked areas.

          • Employee Self Serve Mode (ATG JE Dunn)
          • User Access Policy - > Add New Policy – Server Error when Single Quote is inserted in Policy Name field.
          • Benefit Type Builder
            *ISSUE: Text field “Benefit Type Name” shows validation message when a character (t,g,l) is present in text

          PFA updated document for more details WT-3873.doc .
          These issues needs to be fixed before moving on production environment.

          Show
          prasadp Prasad Pise (Inactive) added a comment - Samir Vijayendra Shinde I have verified following few more pages and found issues in red marked areas. Employee Self Serve Mode (ATG JE Dunn) User Access Policy - > Add New Policy – Server Error when Single Quote is inserted in Policy Name field. Benefit Type Builder *ISSUE: Text field “Benefit Type Name” shows validation message when a character (t,g,l) is present in text PFA updated document for more details WT-3873.doc . These issues needs to be fixed before moving on production environment.

            People

            Assignee:
            prasadp Prasad Pise (Inactive)
            Reporter:
            vijayendra Vijayendra Shinde (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: