To provide facility for users(Partner/Broker/CA) at same hierarchy or at higher hierarchy to access the Invoice Templates and Invoices created by each other. This will only happen for companies that are assigned to respective users(Partner/Broker/CA). SA user will be able access all Invoices for all companies with all rights.
Example:
Company C1 has 2 Partners (P1, P2) and 1 Broker (B1)
Invoice Template T1 is created by Partner P1. Invoices against this template are also generated. Template T1 and the generated Invoices can be accessed by SA(higher hierarchy) and Partner P2(same hierarchy). Broker B1 cannot access the template or invoices generated.
Attachments
Issue Links
relates to
WT-9793Invoice Management -> Cancel button should be enabled when a user is only able to view the template details.
Closed
NF-3359Invoice Mangement -> Invoice not accessible to any other user except creator user
Closed
WT-7762BCC Invoice Management - Implementing User Access Policies for Company Admin in Invoice
To provide facility for users(Partner/Broker/CA) at same hierarchy or at higher hierarchy to access the Invoice Templates and Invoices created by each other. This will only happen for companies that are assigned to respective users(Partner/Broker/CA). SA user will be able access all Invoices for all companies with all rights.
*Example:*
Company C1 has 2 Partners (P1, P2) and 1 Broker (B1)
Invoice Template T1 is created by Partner P1. Invoices against this template are also generated. Template T1 and the generated Invoices can be accessed by SA(higher hierarchy) and Partner P2(same hierarchy). Broker B1 cannot access the template or invoices generated.
Pair Programming - Debugging for server error while editing Invoice template
Code review of trigger changes - Suggested to change "ModifiedBy" to "ModifiedUserID"
Below are 3C's :- Concern :- Invoice not accessible to any other user except creator user Cause :- Invoice accessibility was blocked to user other than who created the template Correction :- Given access to users whose role is same or greater than template creator user
Example: Template created by CA. Earlier accessible to only that CA. Now will be accessible to Partner as well as SA.
They can Edit or delete invoice templates / generated invoices. Also can generate invoice
Tested Scenarios:- User acces policy
1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
2) User with role smaller than creator role should not be able to edit,delete and generate invoice. Note :- 1) If a user has created template and generated invoice then anyone cannot delete or modify template as per feature of system.
2) Consider, CA has created a template and SA has generated respective invoice. Though the invoice is generated by SA, all the users(Partner/Broker/CA) who have access to it can update / delete the generated invoice.
Triggers
1) History should be tracked when Invoice template is created / updated / deleted.
2) History should be tracked when Invoice is created / finalized / due date is updated / deleted.
Note :-
For now we are tracking changes made by user only on two tables InvoiceDetails and InvoiceList by maintaining history table
For detailed tracking of users we need to maintain history tables of below tables :-
InvoiceEmployeeStatus
InvoiceDetails_LocalizeFields
InvoiceBenefitwiseBilling
InvoiceHeaderFields
InvoiceMappingFields
InvoiceDocumentList
InvoicePlandesign
InvoiceProvider
InvoiceBenefits
InvoiceDetailClass1
InvoiceDetailClass2
InvoiceDetailClass3
InvoiceDetailClass4
Jyoti Agrawal (Inactive)
added a comment - Below are 3C's :-
Concern :- Invoice not accessible to any other user except creator user
Cause :- Invoice accessibility was blocked to user other than who created the template
Correction :- Given access to users whose role is same or greater than template creator user
Example: Template created by CA. Earlier accessible to only that CA. Now will be accessible to Partner as well as SA.
They can Edit or delete invoice templates / generated invoices. Also can generate invoice
Affected Areas :- Select Invoice Page
Create Invoice Page
Generate Invoice Page
InvoiceDetails_History Table
InvoiceList_History Table
Affected Files :-
MasterCompanyDB/04_Stored Procedures/dbo.OES_SP_Invoice_DeleteInvoiceRecords.StoredProcedure.sql
MasterCompanyDB/04_Stored Procedures/OES_SP_Invoice_CAEligibleTemplates.sql
MasterCompanyDB/05_Triggers/dbo.trgDelInVoiceDetails_History.sql
MasterCompanyDB/05_Triggers/dbo.[trgDelInvoiceList_History.sql
MasterCompanyDB/05_Triggers/dbo.trgInsInVoiceDetails_History.sql
MasterCompanyDB/05_Triggers/dbo.trgInsInvoiceList_History.sql
MasterCompanyDB/05_Triggers/dbo.trgUpdInVoiceDetails_History.sql
MasterCompanyDB/05_Triggers/dbo.trgUpdInvoiceList_History.sql
MasterCompanyDB/01_DDL/566_ WT-9588 _WTB_Report_NewTable_InVoiceDetails_History.sql
MasterCompanyDB/01_DDL/567_ WT-9588 _WTB_Report_NewTable_InvoiceList_History.sql
App/BusinessLogic/InvoiceManagement/InvoiceDetails.cs
App/BusinessLogic/InvoiceManagement/InvoiceManagement.dll.config
Shared Library/ValueObjects/ValueObjects/AddInvoiceDetails.cs
BenAdmin/Areas/Report/Models/InvoiceManagement/CreateInvoiceModel.cs
BenAdmin/Areas/Report/Models/InvoiceManagement/SelectInvoiceModel.cs
Tested Scenarios :-
User acces policy
1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
Note :- 1) If a user has created template and generated invoice then anyone cannot delete or modify template as per feature of system.
2) Consider, CA has created a template and SA has generated respective invoice. Though the invoice is generated by SA, all the users(Partner/Broker/CA) who have access to it can update / delete the generated invoice.
Triggers
1) History should be tracked when Invoice template is created / updated / deleted.
2) History should be tracked when Invoice is created / finalized / due date is updated / deleted.
Note :-
For now we are tracking changes made by user only on two tables InvoiceDetails and InvoiceList by maintaining history table
For detailed tracking of users we need to maintain history tables of below tables :-
InvoiceEmployeeStatus
InvoiceDetails_LocalizeFields
InvoiceBenefitwiseBilling
InvoiceHeaderFields
InvoiceMappingFields
InvoiceDocumentList
InvoicePlandesign
InvoiceProvider
InvoiceBenefits
InvoiceDetailClass1
InvoiceDetailClass2
InvoiceDetailClass3
InvoiceDetailClass4
These will be covered in ticket WT-7762
Above fix has been verified on LB on Caiso company. Following are the scenarios tested:-
1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
3) Verified this for Partner,Broker,CA,and SA log in
Venkatesh Pujari (Inactive)
added a comment - Hi Jyoti Agrawal ,
Above fix has been verified on LB on Caiso company. Following are the scenarios tested:-
1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
3) Verified this for Partner,Broker,CA,and SA log in
Working fine as expected. This is ready for Stage
Prasanna Karlekar , Sachin Hingole
Thanks,
Venkatesh
Above fix has been verified on Stage on AFI For Hspl company. Following are the scenarios tested:-
1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
3) Verified this for Partner,Broker,CA,and SA log in
Working fine as expected. This is ready for Production
Venkatesh Pujari (Inactive)
added a comment - Hi Jyoti Agrawal,
Above fix has been verified on Stage on AFI For Hspl company. Following are the scenarios tested:-
1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
3) Verified this for Partner,Broker,CA,and SA log in
Working fine as expected. This is ready for Production
Prasanna Karlekar , Sachin Hingole
Thanks,
Venkatesh
Venkatesh Pujari (Inactive)
added a comment - Hi Debbie Kulling ,
The fix has been deployed and also tested on Stage site. Please could you verify at your end and let us know if you any queries on this.
Prasanna Karlekar
Thanks,
Venkatesh
As mentioned by Venkatesh Pujari in above comment, this fix is deployed in Stage environment.
Please note, that due to this fix, template and generated invoices will be accessible to all users, who have access to BCC companies and have same / higher level rights as that of user who created invoice templates.
So, it will be helpful if this is reviewed at your and client's end once and then go ahead is given to deploy this in Production environment.
Prasanna Karlekar (Inactive)
added a comment - Hi Debbie Kulling ,
As mentioned by Venkatesh Pujari in above comment, this fix is deployed in Stage environment.
Please note, that due to this fix, template and generated invoices will be accessible to all users, who have access to BCC companies and have same / higher level rights as that of user who created invoice templates.
So, it will be helpful if this is reviewed at your and client's end once and then go ahead is given to deploy this in Production environment.
Waiting for your reply on Production deployment.
Thank you!
cc: Satya , Venkatesh Pujari , Jyoti Agrawal
Invoices must be generated against the template. As per current implementation, user is not allowed to edit template if invoice is generated against it.
This fix was done, so that other users apart from user who created invoice template could generate monthly invoices.
We have not yet started analyzing/working on functionality related to edit template in WT-7519.
Prasanna Karlekar (Inactive)
added a comment - Invoices must be generated against the template. As per current implementation, user is not allowed to edit template if invoice is generated against it.
This fix was done, so that other users apart from user who created invoice template could generate monthly invoices.
We have not yet started analyzing/working on functionality related to edit template in WT-7519 .
Let us know, of you face any more issue.
Thank you!
Prasanna Karlekar (Inactive)
added a comment - Hi Debbie Kulling ,
Could you please also update this JIRA for approval.
Thank you!
cc: Jyoti Agrawal , Venkatesh Pujari , Lalit Kumar
Prasanna Karlekar (Inactive)
added a comment - Debbie Kulling -
Thank you for the approval. This will get deployed on Production tomorrow i.e. 20-Jun-2017.
cc: Jyoti Agrawal , Venkatesh Pujari
Above fix has been verified on Production on AFI For Hspl company. Following are the scenarios tested:-
1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
3) Verified this for Partner,Broker,CA,and SA log in
Venkatesh Pujari (Inactive)
added a comment - - edited Hi Jyoti Agrawal ,
Above fix has been verified on Production on AFI For Hspl company. Following are the scenarios tested:-
1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
3) Verified this for Partner,Broker,CA,and SA log in
Working fine as expected.
Prasanna Karlekar,Sachin Hingole
Thanks,
Venkatesh
Venkatesh Pujari (Inactive)
added a comment - - edited Hi Debbie Kulling ,
The fix has been deployed and also tested on Production site. Please could you verify at your end and close this ticket.
Prasanna Karlekar
Thanks,
Venkatesh
Bug
Critical
WT-7762 BCC Invoice Management - Implementing User Access Policies for Company Admin in Invoice
Jyoti Agrawal (Inactive)
created issue -
Jyoti Agrawal (Inactive)
made changes -
Khandu Kshirsagar (Inactive)
made changes -
Sachin Hingole (Inactive)
made changes -
Parmeshwar Jumbad (Inactive)
made changes -
Below are 3C's :-
Concern :- Invoice not accessible to any other user except creator user
Cause :- Invoice accessibility was blocked to user other than who created the template
Correction :- Given access to users whose role is same or greater than template creator user
Example: Template created by CA. Earlier accessible to only that CA. Now will be accessible to Partner as well as SA.
They can Edit or delete invoice templates / generated invoices. Also can generate invoice
Affected Areas :- Select Invoice Page
Create Invoice Page
Generate Invoice Page
InvoiceDetails_History Table
InvoiceList_History Table
Affected Files :-
MasterCompanyDB/04_Stored Procedures/dbo.OES_SP_Invoice_DeleteInvoiceRecords.StoredProcedure.sql
MasterCompanyDB/04_Stored Procedures/OES_SP_Invoice_CAEligibleTemplates.sql
MasterCompanyDB/05_Triggers/dbo.trgDelInVoiceDetails_History.sql
MasterCompanyDB/05_Triggers/dbo.[trgDelInvoiceList_History.sql
MasterCompanyDB/05_Triggers/dbo.trgInsInVoiceDetails_History.sql
MasterCompanyDB/05_Triggers/dbo.trgInsInvoiceList_History.sql
MasterCompanyDB/05_Triggers/dbo.trgUpdInVoiceDetails_History.sql
MasterCompanyDB/05_Triggers/dbo.trgUpdInvoiceList_History.sql
MasterCompanyDB/01_DDL/566_
WT-9588_WTB_Report_NewTable_InVoiceDetails_History.sqlMasterCompanyDB/01_DDL/567_
WT-9588_WTB_Report_NewTable_InvoiceList_History.sqlApp/BusinessLogic/InvoiceManagement/InvoiceDetails.cs
App/BusinessLogic/InvoiceManagement/InvoiceManagement.dll.config
Shared Library/ValueObjects/ValueObjects/AddInvoiceDetails.cs
BenAdmin/Areas/Report/Models/InvoiceManagement/CreateInvoiceModel.cs
BenAdmin/Areas/Report/Models/InvoiceManagement/SelectInvoiceModel.cs
Tested Scenarios:-
User acces policy
1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
Note :- 1) If a user has created template and generated invoice then anyone cannot delete or modify template as per feature of system.
2) Consider, CA has created a template and SA has generated respective invoice. Though the invoice is generated by SA, all the users(Partner/Broker/CA) who have access to it can update / delete the generated invoice.
Triggers
1) History should be tracked when Invoice template is created / updated / deleted.
2) History should be tracked when Invoice is created / finalized / due date is updated / deleted.
Note :-
For now we are tracking changes made by user only on two tables InvoiceDetails and InvoiceList by maintaining history table
For detailed tracking of users we need to maintain history tables of below tables :-
InvoiceEmployeeStatus
InvoiceDetails_LocalizeFields
InvoiceBenefitwiseBilling
InvoiceHeaderFields
InvoiceMappingFields
InvoiceDocumentList
InvoicePlandesign
InvoiceProvider
InvoiceBenefits
InvoiceDetailClass1
InvoiceDetailClass2
InvoiceDetailClass3
InvoiceDetailClass4
These will be covered in ticket
WT-7762