Uploaded image for project: 'WORKTERRA'
  1. WORKTERRA
  2. WT-9588

Invoice Mangement -> Invoice not accessible to any other user except creator user

    Details

    • Type: Bug
    • Status: Production Complete
    • Priority: Critical
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: BenAdmin
    • Labels:
      None
    • Bug Severity:
      Medium
    • Module:
      BenAdmin - Report
    • Reported by:
      Harbinger
    • Item State:
      Production Complete - Closed

      Description

      To provide facility for users(Partner/Broker/CA) at same hierarchy or at higher hierarchy to access the Invoice Templates and Invoices created by each other. This will only happen for companies that are assigned to respective users(Partner/Broker/CA). SA user will be able access all Invoices for all companies with all rights.

      Example:
      Company C1 has 2 Partners (P1, P2) and 1 Broker (B1)
      Invoice Template T1 is created by Partner P1. Invoices against this template are also generated. Template T1 and the generated Invoices can be accessed by SA(higher hierarchy) and Partner P2(same hierarchy). Broker B1 cannot access the template or invoices generated.

        Attachments

          Issue Links

            Activity

            Hide
            jyoti.agrawal Jyoti Agrawal (Inactive) added a comment -

            Below are 3C's :-
            Concern :- Invoice not accessible to any other user except creator user
            Cause :- Invoice accessibility was blocked to user other than who created the template
            Correction :- Given access to users whose role is same or greater than template creator user
            Example: Template created by CA. Earlier accessible to only that CA. Now will be accessible to Partner as well as SA.
            They can Edit or delete invoice templates / generated invoices. Also can generate invoice

            Affected Areas :- Select Invoice Page
            Create Invoice Page
            Generate Invoice Page
            InvoiceDetails_History Table
            InvoiceList_History Table

            Affected Files :-
            MasterCompanyDB/04_Stored Procedures/dbo.OES_SP_Invoice_DeleteInvoiceRecords.StoredProcedure.sql
            MasterCompanyDB/04_Stored Procedures/OES_SP_Invoice_CAEligibleTemplates.sql
            MasterCompanyDB/05_Triggers/dbo.trgDelInVoiceDetails_History.sql
            MasterCompanyDB/05_Triggers/dbo.[trgDelInvoiceList_History.sql
            MasterCompanyDB/05_Triggers/dbo.trgInsInVoiceDetails_History.sql
            MasterCompanyDB/05_Triggers/dbo.trgInsInvoiceList_History.sql
            MasterCompanyDB/05_Triggers/dbo.trgUpdInVoiceDetails_History.sql
            MasterCompanyDB/05_Triggers/dbo.trgUpdInvoiceList_History.sql
            MasterCompanyDB/01_DDL/566_WT-9588_WTB_Report_NewTable_InVoiceDetails_History.sql
            MasterCompanyDB/01_DDL/567_WT-9588_WTB_Report_NewTable_InvoiceList_History.sql
            App/BusinessLogic/InvoiceManagement/InvoiceDetails.cs
            App/BusinessLogic/InvoiceManagement/InvoiceManagement.dll.config
            Shared Library/ValueObjects/ValueObjects/AddInvoiceDetails.cs
            BenAdmin/Areas/Report/Models/InvoiceManagement/CreateInvoiceModel.cs
            BenAdmin/Areas/Report/Models/InvoiceManagement/SelectInvoiceModel.cs

            Tested Scenarios:-
            User acces policy
            1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
            2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
            Note :- 1) If a user has created template and generated invoice then anyone cannot delete or modify template as per feature of system.
            2) Consider, CA has created a template and SA has generated respective invoice. Though the invoice is generated by SA, all the users(Partner/Broker/CA) who have access to it can update / delete the generated invoice.

            Triggers
            1) History should be tracked when Invoice template is created / updated / deleted.
            2) History should be tracked when Invoice is created / finalized / due date is updated / deleted.

            Note :-
            For now we are tracking changes made by user only on two tables InvoiceDetails and InvoiceList by maintaining history table
            For detailed tracking of users we need to maintain history tables of below tables :-
            InvoiceEmployeeStatus
            InvoiceDetails_LocalizeFields
            InvoiceBenefitwiseBilling
            InvoiceHeaderFields
            InvoiceMappingFields
            InvoiceDocumentList
            InvoicePlandesign
            InvoiceProvider
            InvoiceBenefits
            InvoiceDetailClass1
            InvoiceDetailClass2
            InvoiceDetailClass3
            InvoiceDetailClass4

            These will be covered in ticket WT-7762

            Show
            jyoti.agrawal Jyoti Agrawal (Inactive) added a comment - Below are 3C's :- Concern :- Invoice not accessible to any other user except creator user Cause :- Invoice accessibility was blocked to user other than who created the template Correction :- Given access to users whose role is same or greater than template creator user Example: Template created by CA. Earlier accessible to only that CA. Now will be accessible to Partner as well as SA. They can Edit or delete invoice templates / generated invoices. Also can generate invoice Affected Areas :- Select Invoice Page Create Invoice Page Generate Invoice Page InvoiceDetails_History Table InvoiceList_History Table Affected Files :- MasterCompanyDB/04_Stored Procedures/dbo.OES_SP_Invoice_DeleteInvoiceRecords.StoredProcedure.sql MasterCompanyDB/04_Stored Procedures/OES_SP_Invoice_CAEligibleTemplates.sql MasterCompanyDB/05_Triggers/dbo.trgDelInVoiceDetails_History.sql MasterCompanyDB/05_Triggers/dbo.[trgDelInvoiceList_History.sql MasterCompanyDB/05_Triggers/dbo.trgInsInVoiceDetails_History.sql MasterCompanyDB/05_Triggers/dbo.trgInsInvoiceList_History.sql MasterCompanyDB/05_Triggers/dbo.trgUpdInVoiceDetails_History.sql MasterCompanyDB/05_Triggers/dbo.trgUpdInvoiceList_History.sql MasterCompanyDB/01_DDL/566_ WT-9588 _WTB_Report_NewTable_InVoiceDetails_History.sql MasterCompanyDB/01_DDL/567_ WT-9588 _WTB_Report_NewTable_InvoiceList_History.sql App/BusinessLogic/InvoiceManagement/InvoiceDetails.cs App/BusinessLogic/InvoiceManagement/InvoiceManagement.dll.config Shared Library/ValueObjects/ValueObjects/AddInvoiceDetails.cs BenAdmin/Areas/Report/Models/InvoiceManagement/CreateInvoiceModel.cs BenAdmin/Areas/Report/Models/InvoiceManagement/SelectInvoiceModel.cs Tested Scenarios :- User acces policy 1) User with role greater or equal to creator role should be able to edit,delete and generate invoice. 2) User with role smaller than creator role should not be able to edit,delete and generate invoice. Note :- 1) If a user has created template and generated invoice then anyone cannot delete or modify template as per feature of system. 2) Consider, CA has created a template and SA has generated respective invoice. Though the invoice is generated by SA, all the users(Partner/Broker/CA) who have access to it can update / delete the generated invoice. Triggers 1) History should be tracked when Invoice template is created / updated / deleted. 2) History should be tracked when Invoice is created / finalized / due date is updated / deleted. Note :- For now we are tracking changes made by user only on two tables InvoiceDetails and InvoiceList by maintaining history table For detailed tracking of users we need to maintain history tables of below tables :- InvoiceEmployeeStatus InvoiceDetails_LocalizeFields InvoiceBenefitwiseBilling InvoiceHeaderFields InvoiceMappingFields InvoiceDocumentList InvoicePlandesign InvoiceProvider InvoiceBenefits InvoiceDetailClass1 InvoiceDetailClass2 InvoiceDetailClass3 InvoiceDetailClass4 These will be covered in ticket WT-7762
            Hide
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment -

            Hi Jyoti Agrawal,

            Above fix has been verified on LB on Caiso company. Following are the scenarios tested:-
            1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
            2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
            3) Verified this for Partner,Broker,CA,and SA log in

            Working fine as expected. This is ready for Stage

            Prasanna Karlekar,Sachin Hingole

            Thanks,
            Venkatesh

            Show
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment - Hi Jyoti Agrawal , Above fix has been verified on LB on Caiso company. Following are the scenarios tested:- 1) User with role greater or equal to creator role should be able to edit,delete and generate invoice. 2) User with role smaller than creator role should not be able to edit,delete and generate invoice. 3) Verified this for Partner,Broker,CA,and SA log in Working fine as expected. This is ready for Stage Prasanna Karlekar , Sachin Hingole Thanks, Venkatesh
            Hide
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment -

            Hi Jyoti Agrawal,

            Above fix has been verified on Stage on AFI For Hspl company. Following are the scenarios tested:-

            1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
            2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
            3) Verified this for Partner,Broker,CA,and SA log in

            Working fine as expected. This is ready for Production

            Prasanna Karlekar,Sachin Hingole

            Thanks,
            Venkatesh

            Show
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment - Hi Jyoti Agrawal, Above fix has been verified on Stage on AFI For Hspl company. Following are the scenarios tested:- 1) User with role greater or equal to creator role should be able to edit,delete and generate invoice. 2) User with role smaller than creator role should not be able to edit,delete and generate invoice. 3) Verified this for Partner,Broker,CA,and SA log in Working fine as expected. This is ready for Production Prasanna Karlekar , Sachin Hingole Thanks, Venkatesh
            Hide
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment -

            Hi Debbie Kulling,

            The fix has been deployed and also tested on Stage site. Please could you verify at your end and let us know if you any queries on this.

            Prasanna Karlekar

            Thanks,
            Venkatesh

            Show
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment - Hi Debbie Kulling , The fix has been deployed and also tested on Stage site. Please could you verify at your end and let us know if you any queries on this. Prasanna Karlekar Thanks, Venkatesh
            Hide
            prasanna Prasanna Karlekar (Inactive) added a comment -

            Hi Debbie Kulling,

            As mentioned by Venkatesh Pujari in above comment, this fix is deployed in Stage environment.
            Please note, that due to this fix, template and generated invoices will be accessible to all users, who have access to BCC companies and have same / higher level rights as that of user who created invoice templates.
            So, it will be helpful if this is reviewed at your and client's end once and then go ahead is given to deploy this in Production environment.

            Waiting for your reply on Production deployment.

            Thank you!

            cc: Satya, Venkatesh Pujari, Jyoti Agrawal

            Show
            prasanna Prasanna Karlekar (Inactive) added a comment - Hi Debbie Kulling , As mentioned by Venkatesh Pujari in above comment, this fix is deployed in Stage environment. Please note, that due to this fix, template and generated invoices will be accessible to all users, who have access to BCC companies and have same / higher level rights as that of user who created invoice templates. So, it will be helpful if this is reviewed at your and client's end once and then go ahead is given to deploy this in Production environment. Waiting for your reply on Production deployment. Thank you! cc: Satya , Venkatesh Pujari , Jyoti Agrawal
            Hide
            dkulling Debbie Kulling added a comment -

            I am looking at this on stage. I can access the template but I still cannot make changes. Please advise

            Show
            dkulling Debbie Kulling added a comment - I am looking at this on stage. I can access the template but I still cannot make changes. Please advise
            Hide
            prasanna Prasanna Karlekar (Inactive) added a comment -

            Invoices must be generated against the template. As per current implementation, user is not allowed to edit template if invoice is generated against it.
            This fix was done, so that other users apart from user who created invoice template could generate monthly invoices.
            We have not yet started analyzing/working on functionality related to edit template in WT-7519.

            Let us know, of you face any more issue.

            Thank you!

            Show
            prasanna Prasanna Karlekar (Inactive) added a comment - Invoices must be generated against the template. As per current implementation, user is not allowed to edit template if invoice is generated against it. This fix was done, so that other users apart from user who created invoice template could generate monthly invoices. We have not yet started analyzing/working on functionality related to edit template in WT-7519 . Let us know, of you face any more issue. Thank you!
            Hide
            prasanna Prasanna Karlekar (Inactive) added a comment -

            Hi Debbie Kulling,

            Could you please also update this JIRA for approval.

            Thank you!

            cc: Jyoti Agrawal, Venkatesh Pujari, Lalit Kumar

            Show
            prasanna Prasanna Karlekar (Inactive) added a comment - Hi Debbie Kulling , Could you please also update this JIRA for approval. Thank you! cc: Jyoti Agrawal , Venkatesh Pujari , Lalit Kumar
            Hide
            prasanna Prasanna Karlekar (Inactive) added a comment -

            Hi Debbie Kulling,

            Gentle Reminder!
            Waiting for your approval over JIRA.

            Thank you!

            cc: Jyoti Agrawal, Venkatesh Pujari, Lalit Kumar, Satya

            Show
            prasanna Prasanna Karlekar (Inactive) added a comment - Hi Debbie Kulling , Gentle Reminder! Waiting for your approval over JIRA. Thank you! cc: Jyoti Agrawal , Venkatesh Pujari , Lalit Kumar , Satya
            Hide
            dkulling Debbie Kulling added a comment -

            Sorry about the delay. Yes please proceed with the move to production. The client has tested stage and approves

            Show
            dkulling Debbie Kulling added a comment - Sorry about the delay. Yes please proceed with the move to production. The client has tested stage and approves
            Hide
            prasanna Prasanna Karlekar (Inactive) added a comment -

            Debbie Kulling -

            Thank you for the approval. This will get deployed on Production tomorrow i.e. 20-Jun-2017.

            cc: Jyoti Agrawal, Venkatesh Pujari

            Show
            prasanna Prasanna Karlekar (Inactive) added a comment - Debbie Kulling - Thank you for the approval. This will get deployed on Production tomorrow i.e. 20-Jun-2017. cc: Jyoti Agrawal , Venkatesh Pujari
            Hide
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment - - edited

            Hi Jyoti Agrawal,

            Above fix has been verified on Production on AFI For Hspl company. Following are the scenarios tested:-

            1) User with role greater or equal to creator role should be able to edit,delete and generate invoice.
            2) User with role smaller than creator role should not be able to edit,delete and generate invoice.
            3) Verified this for Partner,Broker,CA,and SA log in

            Working fine as expected.

            Prasanna Karlekar,Sachin Hingole

            Thanks,
            Venkatesh

            Show
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment - - edited Hi Jyoti Agrawal , Above fix has been verified on Production on AFI For Hspl company. Following are the scenarios tested:- 1) User with role greater or equal to creator role should be able to edit,delete and generate invoice. 2) User with role smaller than creator role should not be able to edit,delete and generate invoice. 3) Verified this for Partner,Broker,CA,and SA log in Working fine as expected. Prasanna Karlekar,Sachin Hingole Thanks, Venkatesh
            Hide
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment - - edited

            Hi Debbie Kulling,

            The fix has been deployed and also tested on Production site. Please could you verify at your end and close this ticket.

            Prasanna Karlekar

            Thanks,
            Venkatesh

            Show
            venkatesh.pujari Venkatesh Pujari (Inactive) added a comment - - edited Hi Debbie Kulling , The fix has been deployed and also tested on Production site. Please could you verify at your end and close this ticket. Prasanna Karlekar Thanks, Venkatesh

              People

              Assignee:
              dkulling Debbie Kulling
              Reporter:
              jyoti.agrawal Jyoti Agrawal (Inactive)
              Account Executive:
              Debbie Kulling
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Dev Due Date:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0h
                  0h
                  Remaining:
                  Time Spent - 52.75h Remaining Estimate - 5h
                  5h
                  Logged:
                  Time Spent - 52.75h Remaining Estimate - 5h
                  52.75h