Document Management SystemProject Type: software

Document Management System

Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1368

SMB : Offer letter CR changes(Date : 8th May 2019)

    Details

    • Type: New Feature
    • Status: Done
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: Enhancements - Fall
    • Labels:
      None

      Description

       

      Hi All,

      Can you please update DMS API to address recent UI changes we got?

      1) Create Offer Letter and Offer Letter Preview API - add new field

      "timeOffCompensation": "string",

      2) Offer letter template - render "timeOffCompensation" field instead of current normalized implementation.

       

      Line below should be replaced with timeOffCompensation field

       

      Time off compensation after 10 days, you will be eligible for 20 days of Paid Time Off (PTO) which must be approved by your manager

        

       

        Attachments

        1. AffectedFiles_DMS-1368.txt
          0.7 kB
        2. DEV-1368.xls
          17 kB
        3. Preview-OfferLetter_SMB.pdf
          203 kB
        4. SMBOffer Letter.jpg
          SMBOffer Letter.jpg
          225 kB
        5. TimeOfCompesation.jpg
          TimeOfCompesation.jpg
          219 kB

          Activity

          Ascending order - Click to sort in descending order
          swapnil.pandhare Swapnil Pandhare (Inactive) created issue -
          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Field Original Value New Value
          Epic Link DMS-508 [ 76001 ]
          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Remaining Estimate 12h [ 43200 ]
          Original Estimate 12h [ 43200 ]
          samir Samir made changes -
          Sprint DMS - Fall Sprint 3 [ 162 ]
          samir Samir made changes -
          Assignee Samir [ samir ] Swapnil Pandhare [ swapnil.pandhare ]
          samir Samir made changes -
          Sprint DMS - Fall Sprint 5 [ 164 ]
          swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
          Assignee Swapnil Pandhare [ swapnil.pandhare ] Samir [ samir ]
          Hide
          Permalink
          samir Samir added a comment -

          Ramya Tantry

          Show
          samir Samir added a comment - Ramya Tantry
          samir Samir made changes -
          Assignee Samir [ samir ] Sonali Farakate [ sonali.farakate ]
          Permalink
          sonali.farakate Sonali Farakate (Inactive) logged work - 16/Jun/19 08:35 PM
          • Time Spent:
            1.5h
             
            • Initial discussion with Ramya regarding changes
            • Started task identification
          Hide
          Permalink
          ramya.tantry Ramya Tantry (Inactive) added a comment - - edited

          Hi Samir,

          For the above mentioned changes, we need to change the SMB offer letter PDF to remove the Time off compensation line and replace with text-area for free flow text.

          Please allocate Namrata's time or Priya's time for change as this has to be done with Adobe Reader.

          CC: Rohan J Khandave

          Show
          ramya.tantry Ramya Tantry (Inactive) added a comment - - edited Hi Samir , For the above mentioned changes, we need to change the SMB offer letter PDF to remove the Time off compensation line and replace with text-area for free flow text. Please allocate Namrata's time or Priya's time for change as this has to be done with Adobe Reader. CC: Rohan J Khandave
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Status To Do [ 10000 ] In Progress [ 3 ]
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Remaining Estimate 12h [ 43200 ] 10.5h [ 37800 ]
          Time Spent 1.5h [ 5400 ]
          Worklog Id 183584 [ 183584 ]
          Permalink
          sonali.farakate Sonali Farakate (Inactive) logged work - 17/Jun/19 08:59 PM - edited
          • Time Spent:
            4.5h
             
            • Task identification
            • Debugging for understanding functions and flow - POST method,Create method
            • Understanding 'Assignment' table structure from database
          Permalink
          sonali.farakate Sonali Farakate (Inactive) logged work - 17/Jun/19 09:00 PM
          • Time Spent:
            1h
             

            Script writing for database table changes

          Hide
          Permalink
          sonali.farakate Sonali Farakate (Inactive) added a comment - - edited

          Tasks:
          1. Analysis(5h)

          • Task identification
          • Debugging for understanding functions and flow - POST method,Create method
          • Understanding 'Assignment' table structure from database

          2. Database changes (4h)

          •  Update column name and type of column (CompensationDays) from table Assignment
          •  Delete column EligiblePTODays from table Assignment

          3.Code changes(4h)

          • Changes in function "UpsertAssignmentData"
          • Changes in Class OfferLetterPayload

          4.Testing(6h)

          • Test case writing
          • Unit Testing

          CC :Ramya Tantry, Samir

          Show
          sonali.farakate Sonali Farakate (Inactive) added a comment - - edited Tasks: 1. Analysis(5h) Task identification Debugging for understanding functions and flow - POST method,Create method Understanding 'Assignment' table structure from database 2. Database changes (4h)  Update column name and type of column (CompensationDays) from table Assignment  Delete column EligiblePTODays from table Assignment 3.Code changes(4h) Changes in function "UpsertAssignmentData" Changes in Class OfferLetterPayload 4.Testing(6h) Test case writing Unit Testing CC : Ramya Tantry , Samir
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Remaining Estimate 10.5h [ 37800 ] 20.5h [ 73800 ]
          Original Estimate 12h [ 43200 ] 22h [ 79200 ]
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Remaining Estimate 20.5h [ 73800 ] 15.5h [ 55800 ]
          Time Spent 1.5h [ 5400 ] 6.5h [ 23400 ]
          Worklog Id 183819 [ 183819 ]
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Remaining Estimate 15.5h [ 55800 ] 14.5h [ 52200 ]
          Time Spent 6.5h [ 23400 ] 7.5h [ 27000 ]
          Worklog Id 183820 [ 183820 ]
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Remaining Estimate 14.5h [ 52200 ] 15h [ 54000 ]
          Time Spent 7.5h [ 27000 ] 7h [ 25200 ]
          Worklog Id 183819 [ 183819 ]
          Permalink
          sonali.farakate Sonali Farakate (Inactive) logged work - 18/Jun/19 09:07 PM
          • Time Spent:
            7h
             
            •  Update column name and type of column (CompensationDays) from table Assignment
            •  Delete column EligiblePTODays from table Assignment
            • Changes in function "UpsertAssignmentData"
            • Changes in Class OfferLetterPayload
            • Discussion with ramya and rohan regarding token invalid issue
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Remaining Estimate 15h [ 54000 ] 8h [ 28800 ]
          Time Spent 7h [ 25200 ] 14h [ 50400 ]
          Worklog Id 184062 [ 184062 ]
          Permalink
          sonali.farakate Sonali Farakate (Inactive) logged work - 19/Jun/19 08:51 PM
          • Time Spent:
            7h
             
            • Debugging
            • script changes
            • Code changes
            • Test case Writing
            • Unit testing
            • Discussion with Ramya
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Remaining Estimate 8h [ 28800 ] 1h [ 3600 ]
          Time Spent 14h [ 50400 ] 21h [ 75600 ]
          Worklog Id 184298 [ 184298 ]
          Permalink
          sonali.farakate Sonali Farakate (Inactive) logged work - 20/Jun/19 09:09 PM
          • Time Spent:
            0.5h
             
            • PR generation
            • Code changes suggested by harshveer
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Status In Progress [ 3 ] Code Review [ 11801 ]
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Assignee Sonali Farakate [ sonali.farakate ] Samir [ samir ]
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Attachment AffectedFiles_DMS-1368.txt [ 110997 ]
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Attachment Preview-OfferLetter_SMB.pdf [ 111040 ]
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Remaining Estimate 1h [ 3600 ] 0.5h [ 1800 ]
          Time Spent 21h [ 75600 ] 21.5h [ 77400 ]
          Worklog Id 184579 [ 184579 ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 5 [ 164 ] DMS - Fall Sprint 5, DMS - Fall Sprint 6 [ 164, 165 ]
          Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
          Status Code Review [ 11801 ] In QA Testing [ 11901 ]
          Permalink
          ramya.tantry Ramya Tantry (Inactive) logged work - 27/Jun/19 05:49 AM
          • Time Spent:
            0.5h
             

            Template changes on Preprod

          ramya.tantry Ramya Tantry (Inactive) made changes -
          Remaining Estimate 0.5h [ 1800 ] 0h [ 0 ]
          Time Spent 21.5h [ 77400 ] 22h [ 79200 ]
          Worklog Id 185556 [ 185556 ]
          Permalink
          sonali.farakate Sonali Farakate (Inactive) logged work - 27/Jun/19 08:54 PM
          • Time Spent:
            0.75h
             

            Discussion with QA and issue verification

          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Samir [ samir ] Jayshree Nagpure [ jayshree.nagpure ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Attachment SMBOffer Letter.jpg [ 111504 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Attachment TimeOfCompesation.jpg [ 111505 ]
          Hide
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited

          Hi Sonali Farakate,

          we have verified this fix for attached SMB offer letter.
          This fix is verified through UI and API .
          Environment : Preproduction
          Login : Admin

          • Time OFF compensation issue related to document and field populating in system field is resolved.

          Refer below issue for UI :
          1.Review and Sign > on click of signature > Signature component is not populating
          PFA :

          Verified through API :
          PFA :
          Link : https://dmsstage.workterra.net/viewer?Token=9a30b7ef5c564bc59c47ecba5c03e9ae&key=05d80bf14f1432ac1720d8ddad02eeb5ef02fd9b943f872e5d99c80c60025dc1

          Can you please look into signature this issue

          Thanks,
          Jayshree

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya Samir

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited Hi Sonali Farakate , we have verified this fix for attached SMB offer letter. This fix is verified through UI and API . Environment : Preproduction Login : Admin Time OFF compensation issue related to document and field populating in system field is resolved. Refer below issue for UI : 1.Review and Sign > on click of signature > Signature component is not populating PFA : Verified through API : PFA : Link : https://dmsstage.workterra.net/viewer?Token=9a30b7ef5c564bc59c47ecba5c03e9ae&key=05d80bf14f1432ac1720d8ddad02eeb5ef02fd9b943f872e5d99c80c60025dc1 Can you please look into signature this issue Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande Satya Samir
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 28/Jun/19 03:56 AM
          • Time Spent:
            1h
             

            Testing on Preproduction

          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Status In QA Testing [ 11901 ] In Progress [ 3 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Sonali Farakate [ sonali.farakate ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Time Spent 22h [ 79200 ] 23h [ 82800 ]
          Worklog Id 185781 [ 185781 ]
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Time Spent 23h [ 82800 ] 23.75h [ 85500 ]
          Worklog Id 185800 [ 185800 ]
          samir Samir made changes -
          Assignee Sonali Farakate [ sonali.farakate ] Narendra Kumar [ narendra.kumar ]
          narendra.kumar Narendra Kumar made changes -
          Status In Progress [ 3 ] To Do [ 10000 ]
          Permalink
          sonali.farakate Sonali Farakate (Inactive) logged work - 01/Jul/19 09:45 PM
          • Time Spent:
            0.5h
             

            Template mapping on production

          Hide
          Permalink
          sonali.farakate Sonali Farakate (Inactive) added a comment -

          Hi Priya Dhamande,

          FYI,
          We have done the pdf mapping related changes on production and templateid is 400.

          Thanks,
          Sonali Farakate

          CC : Ramya Tantry

          Show
          sonali.farakate Sonali Farakate (Inactive) added a comment - Hi Priya Dhamande , FYI, We have done the pdf mapping related changes on production and templateid is 400. Thanks, Sonali Farakate CC : Ramya Tantry
          sonali.farakate Sonali Farakate (Inactive) made changes -
          Time Spent 23.75h [ 85500 ] 24.25h [ 87300 ]
          Worklog Id 186275 [ 186275 ]
          samir Samir made changes -
          Assignee Narendra Kumar [ narendra.kumar ] Priya Dhamande [ priya.dhamande ]
          samir Samir made changes -
          Status To Do [ 10000 ] In QA Testing [ 11901 ]
          priya.dhamande Priya Dhamande (Inactive) made changes -
          Assignee Priya Dhamande [ priya.dhamande ] Jayshree Nagpure [ jayshree.nagpure ]
          shashikant.mishra ShashiKant Mishra (Inactive) made changes -
          Sprint DMS - Fall Sprint 5, DMS - Fall Sprint 6 [ 164, 165 ] DMS - Fall Sprint 5, DMS - Fall Sprint 6, DMS - Fall Sprint 7 [ 164, 165, 166 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Attachment DEV-1368.xls [ 111945 ]
          Hide
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Verified on Preproduction.
          Verified through UI-> Admin login and API

          Verified attached testcases.
          PFA - DEV-1368.xls

          All the testcases are passed.

          So closing this ticket

          Thanks,
          Jayshree

          Priya Dhamande Sachin Hingole Hrishikesh Deshpande

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Verified on Preproduction. Verified through UI-> Admin login and API Verified attached testcases. PFA - DEV-1368.xls All the testcases are passed. So closing this ticket Thanks, Jayshree Priya Dhamande Sachin Hingole Hrishikesh Deshpande
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Status In QA Testing [ 11901 ] Code Review [ 11801 ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Code Review [ 11801 ] Done [ 10001 ]
          Permalink
          jayshree.nagpure Jayshree Nagpure (Inactive) logged work - 08/Jul/19 03:01 AM
          • Time Spent:
            1.5h
             

            testcase writing and execution

          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Assignee Jayshree Nagpure [ jayshree.nagpure ] Rohan J Khandave [ rohan.khandave ]
          jayshree.nagpure Jayshree Nagpure (Inactive) made changes -
          Time Spent 24.25h [ 87300 ] 25.75h [ 92700 ]
          Worklog Id 186892 [ 186892 ]
          Transition Time In Source Status Execution Times
          Sonali Farakate (Inactive) made transition -
          To Do In Progress
          		40d 7h 21m 1
          Sonali Farakate (Inactive) made transition -
          In Progress Code Review
          		3d 17h 25m 1
          Raj Hawaldar (Inactive) made transition -
          Code Review In QA Testing
          		5d 6h 19m 1
          Jayshree Nagpure (Inactive) made transition -
          In QA Testing In Progress
          		1d 23h 22m 1
          Narendra Kumar made transition -
          In Progress To Do
          		2d 23h 15m 1
          Samir made transition -
          To Do In QA Testing
          		1d 18h 29m 1
          Jayshree Nagpure (Inactive) made transition -
          In QA Testing Code Review
          		5d 5h 18m 1
          Jayshree Nagpure (Inactive) made transition -
          Code Review Done
          		3s 1

            People

            Assignee:
            rohan.khandave Rohan J Khandave (Inactive)
            Reporter:
            swapnil.pandhare Swapnil Pandhare (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 23.5h Original Estimate - 23.5h
                23.5h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 27.75h
                27.75h