Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1379

Submit Without signing - should show error

    Details

    • Company:
      All Clients/Multiple Clients

      Description

      Documents can be submitted without being signed. There was a test W4 that I did not sign but hit submit. Shouldn’t there be some error or something prompting the user to sign first. Could we have a contingency on signature?

      cc Shamooka Mohapatra / Swapnil Pandhare

        Attachments

          Issue Links

            Activity

            Monika.Demla Monika Demla (Inactive) created issue -
            Monika.Demla Monika Demla (Inactive) made changes -
            Field Original Value New Value
            Link This issue clones DMS-1378 [ DMS-1378 ]
            Monika.Demla Monika Demla (Inactive) made changes -
            Description Subject line of the email to candidate says “Reminder:” – seems to be missing some more info in the email subject line. It should be like:

            "Reminder: Please Review and Sign Document"

             

            cc [~Shamooka.Mohapatra] / [~swapnil.pandhare]
            Documents can be submitted without being signed. There was a test W4 that I did not sign but hit submit. Shouldn’t there be some error or something prompting the user to sign first. Could we have a contingency on signature?

            cc [~Shamooka.Mohapatra] / [~swapnil.pandhare]
            Monika.Demla Monika Demla (Inactive) made changes -
            Link This issue is cloned by DMS-1380 [ DMS-1380 ]
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Assignee Samir [ samir ] Ramya Tantry [ ramya.tantry ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Sprint DMS - Fall Sprint 2 [ 161 ]
            samir Samir made changes -
            Fix Version/s CBAT Offer Letter - Fall [ 10607 ]
            samir Samir made changes -
            Labels BETA_SP19
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Labels BETA_SP19 be
            rohan.khandave Rohan J Khandave (Inactive) made changes -
            Labels be
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Status To Do [ 10000 ] In Progress [ 3 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 6h [ 21600 ]
            Original Estimate 6h [ 21600 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 6h [ 21600 ] 8h [ 28800 ]
            Original Estimate 6h [ 21600 ] 8h [ 28800 ]
            ramya.tantry Ramya Tantry (Inactive) logged work - 10/May/19 06:06 AM - edited
            • Time Spent:
              6h
               

              Code changes
              Discussion with Swapnil

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 8h [ 28800 ] 3h [ 10800 ]
            Time Spent 5h [ 18000 ]
            Worklog Id 177385 [ 177385 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 3h [ 10800 ] 2.25h [ 8100 ]
            Time Spent 5h [ 18000 ] 5.75h [ 20700 ]
            Worklog Id 177385 [ 177385 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 2.25h [ 8100 ] 2h [ 7200 ]
            Time Spent 5.75h [ 20700 ] 6h [ 21600 ]
            Worklog Id 177385 [ 177385 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Status In Progress [ 3 ] Code Review [ 11801 ]
            ramya.tantry Ramya Tantry (Inactive) made changes -
            Assignee Ramya Tantry [ ramya.tantry ] Swapnil Pandhare [ swapnil.pandhare ]
            Hide
            ramya.tantry Ramya Tantry (Inactive) added a comment -

            Document can be submitted without sign if permission set on the field is Editable, View only and No rights. If the permission is set to Required, then it is mandatory to sign the document. A popup will show up with signature required message.

            As per current implementation, when signature is not mapped, we can still see the signature control on review and sign. If the candidate signs it, data will not be saved as signature field was not mapped.
            New approach : When signature is not mapped, signature control will not be seen. Instead, a text-box will be available for sign field and its data will be saved in JSON of non mapped field.

            Changes have been made to both preview and review and sign for both HTML and PDF.
            Note: While preview, if sign is mapped, green text box will be shown else normal text box will be available.

            Files changed :

            1. DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Forms/preview-form/preview-form.component.ts
            2. DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Person/editable-pdf/editable-pdf.component.ts
               
            Show
            ramya.tantry Ramya Tantry (Inactive) added a comment - Document can be submitted without sign if permission set on the field is Editable, View only and No rights. If the permission is set to Required, then it is mandatory to sign the document. A popup will show up with signature required message. As per current implementation , when signature is not mapped, we can still see the signature control on review and sign. If the candidate signs it, data will not be saved as signature field was not mapped. New approach : When signature is not mapped, signature control will not be seen. Instead, a text-box will be available for sign field and its data will be saved in JSON of non mapped field. Changes have been made to both preview and review and sign for both HTML and PDF. Note : While preview, if sign is mapped, green text box will be shown else normal text box will be available. Files changed : DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Forms/preview-form/preview-form.component.ts DMS/DMS.Web/src/DMS_WebApp/ClientApp/src/app/Person/editable-pdf/editable-pdf.component.ts  
            ramya.tantry Ramya Tantry (Inactive) logged work - 12/May/19 11:28 PM
            • Time Spent:
              2h
               

              code changes

              unit testing for HTML and PDF

            ramya.tantry Ramya Tantry (Inactive) made changes -
            Remaining Estimate 2h [ 7200 ] 0h [ 0 ]
            Time Spent 6h [ 21600 ] 8h [ 28800 ]
            Worklog Id 177639 [ 177639 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Status Code Review [ 11801 ] In QA Testing [ 11901 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Assignee Swapnil Pandhare [ swapnil.pandhare ] Priya Dhamande [ priya.dhamande ]
            mohd.belal Mohd Belal (Inactive) made changes -
            Sprint DMS - Fall Sprint 2 [ 161 ] DMS - Fall Sprint 2, DMS - Fall Sprint 3 [ 161, 162 ]
            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Environment: PreProd

            Scenarios:
            1. Permissions > Editable, No rights and View Only > End User can submit without validation
            2. Permissions > Required > End User gets validation
            3. No Signature mapped > Text field > End User > Signature optional

            All scenarios worked as expected. So, marking this done. refer screen capture.

            Rohan J Khandave Swapnil Pandhare Ganesh Sadawarte

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: PreProd Scenarios: 1. Permissions > Editable, No rights and View Only > End User can submit without validation 2. Permissions > Required > End User gets validation 3. No Signature mapped > Text field > End User > Signature optional All scenarios worked as expected. So, marking this done. refer screen capture. Rohan J Khandave Swapnil Pandhare Ganesh Sadawarte
            priya.dhamande Priya Dhamande (Inactive) logged work - 13/May/19 05:37 AM
            • Time Spent:
              0.5h
               

              Preprod testing

            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Screenshot (1798).png [ 107414 ]
            Attachment Screenshot (1797).png [ 107415 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status In QA Testing [ 11901 ] Done [ 10001 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Assignee Priya Dhamande [ priya.dhamande ] Monika Demla [ monika.demla ]
            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -
            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Hi Monika Demla , can you please confirm the same. Swapnil Pandhare Samir Rohan J Khandave Ganesh Sadawarte
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Time Spent 8h [ 28800 ] 8.5h [ 30600 ]
            Worklog Id 177710 [ 177710 ]
            Hide
            Monika.Demla Monika Demla (Inactive) added a comment - - edited

            Hi Priya Dhamande

            How do I confirm this on Pre-prod? could you please provide credentials? 

            I can only verify this card at CbinternalBeta. Let me know if there is any other instance I need to access which is consider as "Pre-prod"

            Show
            Monika.Demla Monika Demla (Inactive) added a comment - - edited Hi Priya Dhamande How do I confirm this on Pre-prod? could you please provide credentials?  I can only verify this card at CbinternalBeta. Let me know if there is any other instance I need to access which is consider as "Pre-prod"
            priya.dhamande Priya Dhamande (Inactive) logged work - 13/May/19 11:53 PM - edited
            • Time Spent:
              0.5h
               

              Preprod testing

            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Environment: PreProd

            URL: https://dmsstage.workterra.net/login
            Username: CBATAdmin
            Password: CBraCB

            You can verify on Preprod with above credentials.
            Also, will update you Production build date, so that you can verify the same on Production as well.

            Swapnil Pandhare Rohan J Khandave Ganesh Sadawarte

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: PreProd URL: https://dmsstage.workterra.net/login Username: CBATAdmin Password: CBraCB You can verify on Preprod with above credentials. Also, will update you Production build date, so that you can verify the same on Production as well. Swapnil Pandhare Rohan J Khandave Ganesh Sadawarte
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Time Spent 8.5h [ 30600 ] 8.75h [ 31500 ]
            Worklog Id 177890 [ 177890 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Labels BETA_SP19
            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Hi Monika Demla

            With today's build there is some issue on Preprod permissions. Jira for the same is created with ID: DMS-1434.

            Will update you once this issue is deployed.
            Request you to please verify current jira after deployment.

            Samir Swapnil Pandhare Rohan J Khandave Ganesh Sadawarte

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Hi Monika Demla With today's build there is some issue on Preprod permissions. Jira for the same is created with ID: DMS-1434 . Will update you once this issue is deployed. Request you to please verify current jira after deployment. Samir Swapnil Pandhare Rohan J Khandave Ganesh Sadawarte
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Time Spent 8.75h [ 31500 ] 9h [ 32400 ]
            Worklog Id 177890 [ 177890 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Assignee Monika Demla [ monika.demla ] Robert Malony [ robert.malony ]
            Transition Time In Source Status Execution Times
            Ramya Tantry (Inactive) made transition -
            To Do In Progress
            1d 6h 5m 1
            Ramya Tantry (Inactive) made transition -
            In Progress Code Review
            3d 11m 1
            Raj Hawaldar (Inactive) made transition -
            Code Review In QA Testing
            5h 40m 1
            Priya Dhamande (Inactive) made transition -
            In QA Testing Done
            2h 29m 1

              People

              Assignee:
              Robert.Malony Robert Malony (Inactive)
              Reporter:
              Monika.Demla Monika Demla (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 8h Original Estimate - 8h
                  8h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 9h
                  9h