Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1556

CBAT: api endpoint for deleting a DMS account

    Details

      Description

      api endpoint for deleting a DMS account

        Attachments

        1. DMS-1556_1.png
          DMS-1556_1.png
          189 kB
        2. DMS-1556_2.png
          DMS-1556_2.png
          189 kB
        3. DMS-1556_APIChangeScenarios.xls
          14 kB
        4. Screenshot (3575).png
          Screenshot (3575).png
          155 kB
        5. Screenshot (3581).png
          Screenshot (3581).png
          174 kB
        6. Screenshot (3597).png
          Screenshot (3597).png
          174 kB
        7. Screenshot (3598).png
          Screenshot (3598).png
          189 kB
        8. Screenshot (3599).png
          Screenshot (3599).png
          194 kB
        9. Screenshot (3600).png
          Screenshot (3600).png
          194 kB
        10. Screenshot (3601).png
          Screenshot (3601).png
          191 kB
        11. Testcases -DMS-1556.xls
          13 kB

          Issue Links

            Activity

            Hide
            samir Samir added a comment -
            Show
            samir Samir added a comment - DMS-561
            Hide
            samir Samir added a comment -

            Hi Shamooka Mohapatra,

            Can you or Robert Malony please add the detail requirement in this ticket? Also please mention the corresponding CBAT ticket number

            Regards,

            Samir

            Robert Malony, Ravi Banda Rohan J Khandave Harshveer Singh

            Show
            samir Samir added a comment - Hi Shamooka Mohapatra , Can you or Robert Malony please add the detail requirement in this ticket? Also please mention the corresponding CBAT ticket number Regards, Samir Robert Malony , Ravi Banda Rohan J Khandave Harshveer Singh
            Hide
            Shamooka.Mohapatra Shamooka Mohapatra (Inactive) added a comment -
            Show
            Shamooka.Mohapatra Shamooka Mohapatra (Inactive) added a comment - Corresponding card :  https://careerbuilder.atlassian.net/browse/AT-1822  
            Hide
            sonali.farakate Sonali Farakate (Inactive) added a comment - - edited

            Tasks:
            Database change :
            1. Add column 'IsActive' to Company Table with default value = 1

            • IsActive = 1, For active Company
            • IsActive = 0, For inactive Company

            2. Changes in SP 'DMS_SP_GetUserDetails'

            • Add check to SP to return only active companies.

            API changes:
            1. Add company(POST : /api/company)

            • If new company get added then Isactive = 1 by default ->change in AddCompany() function.

            2. Update company(PUT : /api/company)

            • If Company is deactivated then company should not be able to update

            3.Post /api/authorizetoken/{TokenToValidate}

            • If new company get added then Isactive = 1 by default ->change in AddCompany() function.

            4. Deactivate Company (PUT : /api/DeactivateCompany)

            • Add new API to deactivate company
            • Input : AccountDID
            • Output : return companyID

            UI changes :
            Inactive Company should not be visible in drop down.

            Testing :

            • Unit Testing
            • Test case writing

            Queries:
            1. If admin is associated with only 1 company and that company get deactivated then how the login process will be for that admin?
            2. If a company with name 'XYZ' is alredy present and in deactivated state. and now a new company is getting added with same name 'XYZ' then is it Ok to add new company with name 'XYZ'?

            CC : Samir Rohan J Khandave 

            Show
            sonali.farakate Sonali Farakate (Inactive) added a comment - - edited Tasks: Database change : 1. Add column 'IsActive' to Company Table with default value = 1 IsActive = 1, For active Company IsActive = 0, For inactive Company 2. Changes in SP 'DMS_SP_GetUserDetails' Add check to SP to return only active companies. API changes: 1. Add company(POST : /api/company) If new company get added then Isactive = 1 by default ->change in AddCompany() function. 2. Update company(PUT : /api/company) If Company is deactivated then company should not be able to update 3.Post /api/authorizetoken/{TokenToValidate} If new company get added then Isactive = 1 by default ->change in AddCompany() function. 4. Deactivate Company (PUT : /api/DeactivateCompany) Add new API to deactivate company Input : AccountDID Output : return companyID UI changes : Inactive Company should not be visible in drop down. Testing : Unit Testing Test case writing Queries: 1. If admin is associated with only 1 company and that company get deactivated then how the login process will be for that admin? 2. If a company with name 'XYZ' is alredy present and in deactivated state. and now a new company is getting added with same name 'XYZ' then is it Ok to add new company with name 'XYZ'? CC : Samir Rohan J Khandave  
            Hide
            sonali.farakate Sonali Farakate (Inactive) added a comment - - edited

            Hi Samir,

            Following tasks are completed under this jira,

            Database change : 
            1. Add column 'IsActive' to Company Table with default value = 1

            • IsActive = 1, For active Company
            • IsActive = 0, For inactive Company

            2. Changes in SP 'DMS_SP_GetUserDetails'

            • Add check to SP to return only active companies.

            API changes:
            1. Add company(POST : /api/company)

            • If new company get added then Isactive = 1 by default ->change in AddCompany() function.

            2. Update company(PUT : /api/company)

            • If Company is deactivated then company should not be able to update

            3.Post /api/authorizetoken/{TokenToValidate}

            • If new company get added then Isactive = 1 by default ->change in AddCompany() function.

            4. Deactivate Company (PUT : /api/DeactivateCompany)

            • Add new API to deactivate company
            • Input : AccountDID
            • Output : return companyID

            UI changes :
            Inactive Company should not be visible in drop down.

            The scenarios mentioned in sheet DMS-1556_APIChangeScenarios.xls are also covered under this.

            I have created separate ticket DMS-1694 for remaning changes. Please refer DMS-1694 for remaning changes.

            Thanks,
            Sonali Farakate.

            CC : Rohan J Khandave

             

            Show
            sonali.farakate Sonali Farakate (Inactive) added a comment - - edited Hi Samir , Following tasks are completed under this jira, Database change :   1. Add column 'IsActive' to Company Table with default value = 1 IsActive = 1, For active Company IsActive = 0, For inactive Company 2. Changes in SP 'DMS_SP_GetUserDetails' Add check to SP to return only active companies. API changes: 1. Add company(POST : /api/company) If new company get added then Isactive = 1 by default ->change in AddCompany() function. 2. Update company(PUT : /api/company) If Company is deactivated then company should not be able to update 3.Post /api/authorizetoken/{TokenToValidate} If new company get added then Isactive = 1 by default ->change in AddCompany() function. 4. Deactivate Company (PUT : /api/DeactivateCompany) Add new API to deactivate company Input : AccountDID Output : return companyID UI changes : Inactive Company should not be visible in drop down. The scenarios mentioned in sheet  DMS-1556_APIChangeScenarios.xls  are also covered under this. I have created separate ticket DMS-1694  for remaning changes. Please refer  DMS-1694  for remaning changes. Thanks, Sonali Farakate. CC : Rohan J Khandave  
            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Environment: Preprod - OneIM
            API: api/CompanyStatus

            Test cases attached.

            Scenarios tested:
            1. Company added with UI
            2. User added for new company
            3. Company Is Active after adding
            4. api/CompanyStatus > isActive=true > Pass
            5. api/CompanyStatus > isActive=false > Pass
            6. User did added for different company > Validation displayed > Pass

            Refer screen capture. Verified on preprod against Test cases along with mentioned points.

            Samir Sachin Hingole Hrishikesh Deshpande Rohan J Khandave

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Preprod - OneIM API: api/CompanyStatus Test cases attached. Scenarios tested: 1. Company added with UI 2. User added for new company 3. Company Is Active after adding 4. api/CompanyStatus > isActive=true > Pass 5. api/CompanyStatus > isActive=false > Pass 6. User did added for different company > Validation displayed > Pass Refer screen capture. Verified on preprod against Test cases along with mentioned points. Samir Sachin Hingole Hrishikesh Deshpande Rohan J Khandave

              People

              Assignee:
              sonali.farakate Sonali Farakate (Inactive)
              Reporter:
              samir Samir
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 40h
                  40h
                  Remaining:
                  Time Spent - 20.75h Remaining Estimate - 17.25h
                  17.25h
                  Logged:
                  Time Spent - 20.75h Remaining Estimate - 17.25h Time Not Required
                  20.75h