[DMS-1556] CBAT: api endpoint for deleting a DMS account - Workterra Jira

Details

Type: New Feature
Status: Done
Priority: High
Resolution: Done
Affects Version/s: None
Fix Version/s: CBAT Offer Letter - Fall
Labels:
- Integration-CBAT

Company:
All Clients/Multiple Clients
Epic Link:
Integration with CBAT

Description

api endpoint for deleting a DMS account

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

DMS-1556_1.png
30/Jul/19 06:25 AM
189 kB
Sonali Farakate
DMS-1556_2.png
30/Jul/19 06:25 AM
189 kB
Sonali Farakate
DMS-1556_APIChangeScenarios.xls
24/Jul/19 06:43 AM
14 kB
Sonali Farakate
Screenshot (3575).png
02/Aug/19 04:18 AM
155 kB
Priya Dhamande
Screenshot (3581).png
02/Aug/19 04:17 AM
174 kB
Priya Dhamande
Screenshot (3597).png
02/Aug/19 04:17 AM
174 kB
Priya Dhamande
Screenshot (3598).png
02/Aug/19 04:17 AM
189 kB
Priya Dhamande
Screenshot (3599).png
02/Aug/19 04:17 AM
194 kB
Priya Dhamande
Screenshot (3600).png
02/Aug/19 04:17 AM
194 kB
Priya Dhamande
Screenshot (3601).png
02/Aug/19 04:17 AM
191 kB
Priya Dhamande
Testcases -DMS-1556.xls
02/Aug/19 04:20 AM
13 kB
Priya Dhamande

Issue Links

relates to

DMS-1694 CBAT: api endpoint for deleting a DMS account : UI changes and Test case writing

Done

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Samir added a comment - 24/Jun/19 03:54 AM

~~DMS-561~~

Show

Samir added a comment - 24/Jun/19 03:54 AM DMS-561

Hide

Permalink

Samir added a comment - 15/Jul/19 05:14 AM

Hi Shamooka Mohapatra,

Can you or Robert Malony please add the detail requirement in this ticket? Also please mention the corresponding CBAT ticket number

Regards,

Samir

Robert Malony, Ravi Banda Rohan J Khandave Harshveer Singh

Show

Samir added a comment - 15/Jul/19 05:14 AM Hi Shamooka Mohapatra , Can you or Robert Malony please add the detail requirement in this ticket? Also please mention the corresponding CBAT ticket number Regards, Samir Robert Malony , Ravi Banda Rohan J Khandave Harshveer Singh

Hide

Permalink

Shamooka Mohapatra (Inactive) added a comment - 15/Jul/19 11:00 AM

Corresponding card : https://careerbuilder.atlassian.net/browse/AT-1822

Show

Shamooka Mohapatra (Inactive) added a comment - 15/Jul/19 11:00 AM Corresponding card : https://careerbuilder.atlassian.net/browse/AT-1822

Hide

Permalink

Sonali Farakate (Inactive) added a comment - 23/Jul/19 06:47 AM - edited

Tasks:
Database change :
1. Add column 'IsActive' to Company Table with default value = 1

IsActive = 1, For active Company
IsActive = 0, For inactive Company

2. Changes in SP 'DMS_SP_GetUserDetails'

Add check to SP to return only active companies.

API changes:
1. Add company(POST : /api/company)

If new company get added then Isactive = 1 by default ->change in AddCompany() function.

2. Update company(PUT : /api/company)

If Company is deactivated then company should not be able to update

3.Post /api/authorizetoken/{TokenToValidate}

If new company get added then Isactive = 1 by default ->change in AddCompany() function.

4. Deactivate Company (PUT : /api/DeactivateCompany)

Add new API to deactivate company
Input : AccountDID
Output : return companyID

UI changes :
Inactive Company should not be visible in drop down.

Testing :

Unit Testing
Test case writing

Queries:
1. If admin is associated with only 1 company and that company get deactivated then how the login process will be for that admin?
2. If a company with name 'XYZ' is alredy present and in deactivated state. and now a new company is getting added with same name 'XYZ' then is it Ok to add new company with name 'XYZ'?

CC : Samir Rohan J Khandave

Show

Sonali Farakate (Inactive) added a comment - 23/Jul/19 06:47 AM - edited Tasks: Database change : 1. Add column 'IsActive' to Company Table with default value = 1 IsActive = 1, For active Company IsActive = 0, For inactive Company 2. Changes in SP 'DMS_SP_GetUserDetails' Add check to SP to return only active companies. API changes: 1. Add company(POST : /api/company) If new company get added then Isactive = 1 by default ->change in AddCompany() function. 2. Update company(PUT : /api/company) If Company is deactivated then company should not be able to update 3.Post /api/authorizetoken/{TokenToValidate} If new company get added then Isactive = 1 by default ->change in AddCompany() function. 4. Deactivate Company (PUT : /api/DeactivateCompany) Add new API to deactivate company Input : AccountDID Output : return companyID UI changes : Inactive Company should not be visible in drop down. Testing : Unit Testing Test case writing Queries: 1. If admin is associated with only 1 company and that company get deactivated then how the login process will be for that admin? 2. If a company with name 'XYZ' is alredy present and in deactivated state. and now a new company is getting added with same name 'XYZ' then is it Ok to add new company with name 'XYZ'? CC : Samir Rohan J Khandave

Hide

Permalink

Sonali Farakate (Inactive) added a comment - 29/Jul/19 03:48 AM - edited

Hi Samir,

Following tasks are completed under this jira,

Database change :
1. Add column 'IsActive' to Company Table with default value = 1

IsActive = 1, For active Company
IsActive = 0, For inactive Company

2. Changes in SP 'DMS_SP_GetUserDetails'

Add check to SP to return only active companies.

API changes:
1. Add company(POST : /api/company)

If new company get added then Isactive = 1 by default ->change in AddCompany() function.

2. Update company(PUT : /api/company)

If Company is deactivated then company should not be able to update

3.Post /api/authorizetoken/{TokenToValidate}

If new company get added then Isactive = 1 by default ->change in AddCompany() function.

4. Deactivate Company (PUT : /api/DeactivateCompany)

Add new API to deactivate company
Input : AccountDID
Output : return companyID

UI changes :
Inactive Company should not be visible in drop down.

The scenarios mentioned in sheet DMS-1556_APIChangeScenarios.xls are also covered under this.

I have created separate ticket ~~DMS-1694~~ for remaning changes. Please refer ~~DMS-1694~~ for remaning changes.

Thanks,
Sonali Farakate.

CC : Rohan J Khandave

Show

Sonali Farakate (Inactive) added a comment - 29/Jul/19 03:48 AM - edited Hi Samir , Following tasks are completed under this jira, Database change : 1. Add column 'IsActive' to Company Table with default value = 1 IsActive = 1, For active Company IsActive = 0, For inactive Company 2. Changes in SP 'DMS_SP_GetUserDetails' Add check to SP to return only active companies. API changes: 1. Add company(POST : /api/company) If new company get added then Isactive = 1 by default ->change in AddCompany() function. 2. Update company(PUT : /api/company) If Company is deactivated then company should not be able to update 3.Post /api/authorizetoken/{TokenToValidate} If new company get added then Isactive = 1 by default ->change in AddCompany() function. 4. Deactivate Company (PUT : /api/DeactivateCompany) Add new API to deactivate company Input : AccountDID Output : return companyID UI changes : Inactive Company should not be visible in drop down. The scenarios mentioned in sheet DMS-1556_APIChangeScenarios.xls are also covered under this. I have created separate ticket DMS-1694 for remaning changes. Please refer DMS-1694 for remaning changes. Thanks, Sonali Farakate. CC : Rohan J Khandave

Hide

Permalink

Priya Dhamande (Inactive) added a comment - 02/Aug/19 04:19 AM

Environment: Preprod - OneIM
API: api/CompanyStatus

Test cases attached.

Scenarios tested:
1. Company added with UI
2. User added for new company
3. Company Is Active after adding
4. api/CompanyStatus > isActive=true > Pass
5. api/CompanyStatus > isActive=false > Pass
6. User did added for different company > Validation displayed > Pass

Refer screen capture. Verified on preprod against Test cases along with mentioned points.

Samir Sachin Hingole Hrishikesh Deshpande Rohan J Khandave

Show

Priya Dhamande (Inactive) added a comment - 02/Aug/19 04:19 AM Environment: Preprod - OneIM API: api/CompanyStatus Test cases attached. Scenarios tested: 1. Company added with UI 2. User added for new company 3. Company Is Active after adding 4. api/CompanyStatus > isActive=true > Pass 5. api/CompanyStatus > isActive=false > Pass 6. User did added for different company > Validation displayed > Pass Refer screen capture. Verified on preprod against Test cases along with mentioned points. Samir Sachin Hingole Hrishikesh Deshpande Rohan J Khandave

Document Management System

CBAT: api endpoint for deleting a DMS account

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking