Samir
added a comment - Hi Shamooka Mohapatra ,
Can you or Robert Malony please add the detail requirement in this ticket? Also please mention the corresponding CBAT ticket number
Regards,
Samir
Robert Malony , Ravi Banda Rohan J Khandave Harshveer Singh
Tasks: Database change :
1. Add column 'IsActive' to Company Table with default value = 1
IsActive = 1, For active Company
IsActive = 0, For inactive Company
2. Changes in SP 'DMS_SP_GetUserDetails'
Add check to SP to return only active companies.
API changes:
1. Add company(POST : /api/company)
If new company get added then Isactive = 1 by default ->change in AddCompany() function.
2. Update company(PUT : /api/company)
If Company is deactivated then company should not be able to update
3.Post /api/authorizetoken/{TokenToValidate}
If new company get added then Isactive = 1 by default ->change in AddCompany() function.
4. Deactivate Company (PUT : /api/DeactivateCompany)
Add new API to deactivate company
Input : AccountDID
Output : return companyID
UI changes :
Inactive Company should not be visible in drop down.
Testing :
Unit Testing
Test case writing
Queries:
1. If admin is associated with only 1 company and that company get deactivated then how the login process will be for that admin?
2. If a company with name 'XYZ' is alredy present and in deactivated state. and now a new company is getting added with same name 'XYZ' then is it Ok to add new company with name 'XYZ'?
Sonali Farakate (Inactive)
added a comment - - edited Tasks:
Database change :
1. Add column 'IsActive' to Company Table with default value = 1
IsActive = 1, For active Company
IsActive = 0, For inactive Company
2. Changes in SP 'DMS_SP_GetUserDetails'
Add check to SP to return only active companies.
API changes:
1. Add company(POST : /api/company)
If new company get added then Isactive = 1 by default ->change in AddCompany() function.
2. Update company(PUT : /api/company)
If Company is deactivated then company should not be able to update
3.Post /api/authorizetoken/{TokenToValidate}
If new company get added then Isactive = 1 by default ->change in AddCompany() function.
4. Deactivate Company (PUT : /api/DeactivateCompany)
Add new API to deactivate company
Input : AccountDID
Output : return companyID
UI changes :
Inactive Company should not be visible in drop down.
Testing :
Unit Testing
Test case writing
Queries:
1. If admin is associated with only 1 company and that company get deactivated then how the login process will be for that admin?
2. If a company with name 'XYZ' is alredy present and in deactivated state. and now a new company is getting added with same name 'XYZ' then is it Ok to add new company with name 'XYZ'?
CC : Samir Rohan J Khandave
Sonali Farakate (Inactive)
added a comment - - edited Hi Samir ,
Following tasks are completed under this jira,
Database change :
1. Add column 'IsActive' to Company Table with default value = 1
IsActive = 1, For active Company
IsActive = 0, For inactive Company
2. Changes in SP 'DMS_SP_GetUserDetails'
Add check to SP to return only active companies.
API changes:
1. Add company(POST : /api/company)
If new company get added then Isactive = 1 by default ->change in AddCompany() function.
2. Update company(PUT : /api/company)
If Company is deactivated then company should not be able to update
3.Post /api/authorizetoken/{TokenToValidate}
If new company get added then Isactive = 1 by default ->change in AddCompany() function.
4. Deactivate Company (PUT : /api/DeactivateCompany)
Add new API to deactivate company
Input : AccountDID
Output : return companyID
UI changes :
Inactive Company should not be visible in drop down.
The scenarios mentioned in sheet DMS-1556_APIChangeScenarios.xls are also covered under this.
I have created separate ticket DMS-1694 for remaning changes. Please refer DMS-1694 for remaning changes.
Thanks,
Sonali Farakate.
CC : Rohan J Khandave
Scenarios tested:
1. Company added with UI
2. User added for new company
3. Company Is Active after adding
4. api/CompanyStatus > isActive=true > Pass
5. api/CompanyStatus > isActive=false > Pass
6. User did added for different company > Validation displayed > Pass
Refer screen capture. Verified on preprod against Test cases along with mentioned points.
Priya Dhamande (Inactive)
added a comment - Environment: Preprod - OneIM
API: api/CompanyStatus
Test cases attached.
Scenarios tested:
1. Company added with UI
2. User added for new company
3. Company Is Active after adding
4. api/CompanyStatus > isActive=true > Pass
5. api/CompanyStatus > isActive=false > Pass
6. User did added for different company > Validation displayed > Pass
Refer screen capture. Verified on preprod against Test cases along with mentioned points.
Samir Sachin Hingole Hrishikesh Deshpande Rohan J Khandave
DMS-561