Uploaded image for project: 'Document Management System'
  1. Document Management System
  2. DMS-1556

CBAT: api endpoint for deleting a DMS account

    Details

      Description

      api endpoint for deleting a DMS account

        Attachments

        1. DMS-1556_1.png
          DMS-1556_1.png
          189 kB
        2. DMS-1556_2.png
          DMS-1556_2.png
          189 kB
        3. DMS-1556_APIChangeScenarios.xls
          14 kB
        4. Screenshot (3575).png
          Screenshot (3575).png
          155 kB
        5. Screenshot (3581).png
          Screenshot (3581).png
          174 kB
        6. Screenshot (3597).png
          Screenshot (3597).png
          174 kB
        7. Screenshot (3598).png
          Screenshot (3598).png
          189 kB
        8. Screenshot (3599).png
          Screenshot (3599).png
          194 kB
        9. Screenshot (3600).png
          Screenshot (3600).png
          194 kB
        10. Screenshot (3601).png
          Screenshot (3601).png
          191 kB
        11. Testcases -DMS-1556.xls
          13 kB

          Issue Links

            Activity

            samir Samir created issue -
            Hide
            samir Samir added a comment -
            Show
            samir Samir added a comment - DMS-561
            samir Samir made changes -
            Field Original Value New Value
            Fix Version/s CBAT Offer Letter - Fall [ 10607 ]
            samir Samir made changes -
            Epic Link DMS-473 [ 75966 ]
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Labels Integration-CBES
            shashikant.mishra ShashiKant Mishra (Inactive) made changes -
            Labels Integration-CBES Integration-CBAT
            samir Samir made changes -
            Sprint DMS - Fall Sprint 7 [ 166 ]
            Remaining Estimate 16h [ 57600 ]
            Original Estimate 16h [ 57600 ]
            samir Samir made changes -
            Assignee Samir [ samir ] Rohan J Khandave [ rohan.khandave ]
            samir Samir made changes -
            Assignee Rohan J Khandave [ rohan.khandave ] Sonali Farakate [ sonali.farakate ]
            Hide
            samir Samir added a comment -

            Hi Shamooka Mohapatra,

            Can you or Robert Malony please add the detail requirement in this ticket? Also please mention the corresponding CBAT ticket number

            Regards,

            Samir

            Robert Malony, Ravi Banda Rohan J Khandave Harshveer Singh

            Show
            samir Samir added a comment - Hi Shamooka Mohapatra , Can you or Robert Malony please add the detail requirement in this ticket? Also please mention the corresponding CBAT ticket number Regards, Samir Robert Malony , Ravi Banda Rohan J Khandave Harshveer Singh
            Hide
            Shamooka.Mohapatra Shamooka Mohapatra (Inactive) added a comment -
            Show
            Shamooka.Mohapatra Shamooka Mohapatra (Inactive) added a comment - Corresponding card :  https://careerbuilder.atlassian.net/browse/AT-1822  
            samir Samir made changes -
            Sprint DMS - Fall Sprint 7 [ 166 ] DMS - Fall Sprint 8 [ 167 ]
            sonali.farakate Sonali Farakate (Inactive) logged work - 22/Jul/19 09:48 PM
            • Time Spent:
              4.5h
               
              • Task identification
              • Discussion with rohan
              • Code debug
              • Analysis for Add company,Update company API
            sonali.farakate Sonali Farakate (Inactive) made changes -
            Status To Do [ 10000 ] In Progress [ 3 ]
            Hide
            sonali.farakate Sonali Farakate (Inactive) added a comment - - edited

            Tasks:
            Database change :
            1. Add column 'IsActive' to Company Table with default value = 1

            • IsActive = 1, For active Company
            • IsActive = 0, For inactive Company

            2. Changes in SP 'DMS_SP_GetUserDetails'

            • Add check to SP to return only active companies.

            API changes:
            1. Add company(POST : /api/company)

            • If new company get added then Isactive = 1 by default ->change in AddCompany() function.

            2. Update company(PUT : /api/company)

            • If Company is deactivated then company should not be able to update

            3.Post /api/authorizetoken/{TokenToValidate}

            • If new company get added then Isactive = 1 by default ->change in AddCompany() function.

            4. Deactivate Company (PUT : /api/DeactivateCompany)

            • Add new API to deactivate company
            • Input : AccountDID
            • Output : return companyID

            UI changes :
            Inactive Company should not be visible in drop down.

            Testing :

            • Unit Testing
            • Test case writing

            Queries:
            1. If admin is associated with only 1 company and that company get deactivated then how the login process will be for that admin?
            2. If a company with name 'XYZ' is alredy present and in deactivated state. and now a new company is getting added with same name 'XYZ' then is it Ok to add new company with name 'XYZ'?

            CC : Samir Rohan J Khandave 

            Show
            sonali.farakate Sonali Farakate (Inactive) added a comment - - edited Tasks: Database change : 1. Add column 'IsActive' to Company Table with default value = 1 IsActive = 1, For active Company IsActive = 0, For inactive Company 2. Changes in SP 'DMS_SP_GetUserDetails' Add check to SP to return only active companies. API changes: 1. Add company(POST : /api/company) If new company get added then Isactive = 1 by default ->change in AddCompany() function. 2. Update company(PUT : /api/company) If Company is deactivated then company should not be able to update 3.Post /api/authorizetoken/{TokenToValidate} If new company get added then Isactive = 1 by default ->change in AddCompany() function. 4. Deactivate Company (PUT : /api/DeactivateCompany) Add new API to deactivate company Input : AccountDID Output : return companyID UI changes : Inactive Company should not be visible in drop down. Testing : Unit Testing Test case writing Queries: 1. If admin is associated with only 1 company and that company get deactivated then how the login process will be for that admin? 2. If a company with name 'XYZ' is alredy present and in deactivated state. and now a new company is getting added with same name 'XYZ' then is it Ok to add new company with name 'XYZ'? CC : Samir Rohan J Khandave  
            sonali.farakate Sonali Farakate (Inactive) made changes -
            Remaining Estimate 16h [ 57600 ] 11.5h [ 41400 ]
            Time Spent 4.5h [ 16200 ]
            Worklog Id 190765 [ 190765 ]
            sonali.farakate Sonali Farakate (Inactive) made changes -
            Attachment DMS-1556_APIChangeScenarios.xls [ 114334 ]
            sonali.farakate Sonali Farakate (Inactive) logged work - 24/Jul/19 06:46 AM
            • Time Spent:
              7.5h
               

              Database change :
              1. Add column 'IsActive' to Company Table with default value = 1
              2. Changes in SP 'DMS_SP_GetUserDetails'

              API changes:
              1. Done changes in Add company(POST : /api/company)
              2. Done change Update company(PUT : /api/company

            sonali.farakate Sonali Farakate (Inactive) made changes -
            Remaining Estimate 11.5h [ 41400 ] 4h [ 14400 ]
            Time Spent 4.5h [ 16200 ] 12h [ 43200 ]
            Worklog Id 191025 [ 191025 ]
            sonali.farakate Sonali Farakate (Inactive) made changes -
            Remaining Estimate 4h [ 14400 ] 26h [ 93600 ]
            Original Estimate 16h [ 57600 ] 40h [ 144000 ]
            sonali.farakate Sonali Farakate (Inactive) logged work - 24/Jul/19 09:07 PM
            • Time Spent:
              1h
               

              Changes for hiding inactive company from drop down

            sonali.farakate Sonali Farakate (Inactive) made changes -
            Status In Progress [ 3 ] In Progress [ 3 ]
            sonali.farakate Sonali Farakate (Inactive) made changes -
            Remaining Estimate 26h [ 93600 ] 25h [ 90000 ]
            Time Spent 12h [ 43200 ] 13h [ 46800 ]
            Worklog Id 191592 [ 191592 ]
            sonali.farakate Sonali Farakate (Inactive) logged work - 28/Jul/19 09:38 PM
            • Time Spent:
              5h
               
              <No comment>
            sonali.farakate Sonali Farakate (Inactive) made changes -
            Link This issue relates to DMS-1694 [ DMS-1694 ]
            Hide
            sonali.farakate Sonali Farakate (Inactive) added a comment - - edited

            Hi Samir,

            Following tasks are completed under this jira,

            Database change : 
            1. Add column 'IsActive' to Company Table with default value = 1

            • IsActive = 1, For active Company
            • IsActive = 0, For inactive Company

            2. Changes in SP 'DMS_SP_GetUserDetails'

            • Add check to SP to return only active companies.

            API changes:
            1. Add company(POST : /api/company)

            • If new company get added then Isactive = 1 by default ->change in AddCompany() function.

            2. Update company(PUT : /api/company)

            • If Company is deactivated then company should not be able to update

            3.Post /api/authorizetoken/{TokenToValidate}

            • If new company get added then Isactive = 1 by default ->change in AddCompany() function.

            4. Deactivate Company (PUT : /api/DeactivateCompany)

            • Add new API to deactivate company
            • Input : AccountDID
            • Output : return companyID

            UI changes :
            Inactive Company should not be visible in drop down.

            The scenarios mentioned in sheet DMS-1556_APIChangeScenarios.xls are also covered under this.

            I have created separate ticket DMS-1694 for remaning changes. Please refer DMS-1694 for remaning changes.

            Thanks,
            Sonali Farakate.

            CC : Rohan J Khandave

             

            Show
            sonali.farakate Sonali Farakate (Inactive) added a comment - - edited Hi Samir , Following tasks are completed under this jira, Database change :   1. Add column 'IsActive' to Company Table with default value = 1 IsActive = 1, For active Company IsActive = 0, For inactive Company 2. Changes in SP 'DMS_SP_GetUserDetails' Add check to SP to return only active companies. API changes: 1. Add company(POST : /api/company) If new company get added then Isactive = 1 by default ->change in AddCompany() function. 2. Update company(PUT : /api/company) If Company is deactivated then company should not be able to update 3.Post /api/authorizetoken/{TokenToValidate} If new company get added then Isactive = 1 by default ->change in AddCompany() function. 4. Deactivate Company (PUT : /api/DeactivateCompany) Add new API to deactivate company Input : AccountDID Output : return companyID UI changes : Inactive Company should not be visible in drop down. The scenarios mentioned in sheet  DMS-1556_APIChangeScenarios.xls  are also covered under this. I have created separate ticket DMS-1694  for remaning changes. Please refer  DMS-1694  for remaning changes. Thanks, Sonali Farakate. CC : Rohan J Khandave  
            sonali.farakate Sonali Farakate (Inactive) made changes -
            Status In Progress [ 3 ] Code Review [ 11801 ]
            sonali.farakate Sonali Farakate (Inactive) made changes -
            Assignee Sonali Farakate [ sonali.farakate ] Samir [ samir ]
            sonali.farakate Sonali Farakate (Inactive) made changes -
            Remaining Estimate 25h [ 90000 ] 20h [ 72000 ]
            Time Spent 13h [ 46800 ] 18h [ 64800 ]
            Worklog Id 191936 [ 191936 ]
            sonali.farakate Sonali Farakate (Inactive) logged work - 29/Jul/19 06:22 PM
            • Time Spent:
              2h
               

              worked on code suggestions given by harshveer

            sonali.farakate Sonali Farakate (Inactive) made changes -
            Remaining Estimate 20h [ 72000 ] 18h [ 64800 ]
            Time Spent 18h [ 64800 ] 20h [ 72000 ]
            Worklog Id 192182 [ 192182 ]
            sonali.farakate Sonali Farakate (Inactive) made changes -
            Attachment DMS-1556_1.png [ 114878 ]
            Attachment DMS-1556_2.png [ 114879 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Screenshot (3600).png [ 115278 ]
            Attachment Screenshot (3599).png [ 115279 ]
            Attachment Screenshot (3598).png [ 115280 ]
            Attachment Screenshot (3597).png [ 115281 ]
            Attachment Screenshot (3601).png [ 115282 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Screenshot (3581).png [ 115283 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Screenshot (3575).png [ 115284 ]
            priya.dhamande Priya Dhamande (Inactive) logged work - 02/Aug/19 04:19 AM
            • Time Spent:
              0.75h
               

              Preprod testing

            Hide
            priya.dhamande Priya Dhamande (Inactive) added a comment -

            Environment: Preprod - OneIM
            API: api/CompanyStatus

            Test cases attached.

            Scenarios tested:
            1. Company added with UI
            2. User added for new company
            3. Company Is Active after adding
            4. api/CompanyStatus > isActive=true > Pass
            5. api/CompanyStatus > isActive=false > Pass
            6. User did added for different company > Validation displayed > Pass

            Refer screen capture. Verified on preprod against Test cases along with mentioned points.

            Samir Sachin Hingole Hrishikesh Deshpande Rohan J Khandave

            Show
            priya.dhamande Priya Dhamande (Inactive) added a comment - Environment: Preprod - OneIM API: api/CompanyStatus Test cases attached. Scenarios tested: 1. Company added with UI 2. User added for new company 3. Company Is Active after adding 4. api/CompanyStatus > isActive=true > Pass 5. api/CompanyStatus > isActive=false > Pass 6. User did added for different company > Validation displayed > Pass Refer screen capture. Verified on preprod against Test cases along with mentioned points. Samir Sachin Hingole Hrishikesh Deshpande Rohan J Khandave
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Code Review [ 11801 ] Done [ 10001 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Remaining Estimate 18h [ 64800 ] 17.25h [ 62100 ]
            Time Spent 20h [ 72000 ] 20.75h [ 74700 ]
            Worklog Id 192979 [ 192979 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Attachment Testcases -DMS-1556.xls [ 115285 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Status Done [ 10001 ] In QA Testing [ 11901 ]
            Raj.Hawaldar Raj Hawaldar (Inactive) made changes -
            Assignee Samir [ samir ] Priya Dhamande [ priya.dhamande ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Status In QA Testing [ 11901 ] Done [ 10001 ]
            priya.dhamande Priya Dhamande (Inactive) made changes -
            Assignee Priya Dhamande [ priya.dhamande ] Sonali Farakate [ sonali.farakate ]
            Transition Time In Source Status Execution Times
            Sonali Farakate (Inactive) made transition -
            To Do In Progress
            28d 20h 9m 1
            Sonali Farakate (Inactive) made transition -
            In Progress In Progress
            3d 6h 2m 1
            Sonali Farakate (Inactive) made transition -
            In Progress Code Review
            2d 21h 43m 1
            Priya Dhamande (Inactive) made transition -
            Code Review Done
            4d 31m 1
            Raj Hawaldar (Inactive) made transition -
            Done In QA Testing
            25d 18h 58m 1
            Priya Dhamande (Inactive) made transition -
            In QA Testing Done
            22d 6h 41m 1

              People

              Assignee:
              sonali.farakate Sonali Farakate (Inactive)
              Reporter:
              samir Samir
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 40h
                  40h
                  Remaining:
                  Time Spent - 20.75h Remaining Estimate - 17.25h
                  17.25h
                  Logged:
                  Time Spent - 20.75h Remaining Estimate - 17.25h Time Not Required
                  20.75h