Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-53

UK Benefits:Implement Phone Number like Zip/Postal code based on Country selection on Import

    Details

    • Type: Enhancement
    • Status: Reopen in Production
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Module:
      UK Benefits
    • Reported by:
      Harbinger
    • Item State:
      Stage QA - Production Deployment on Hold
    • Sprint:
      NF Sprint 3

      Description

      Currently Zip Code/Postal Code is on country selection. We will implement same for phone number. These two fields need not to consider in rule creation combination.
      Validations required:
      1.Regx update
      2.Import Validation
      3.EDS Validation

        Attachments

          Issue Links

            Activity

            Hide
            suraj.sokasane Suraj Sokasane (Inactive) added a comment -

            During the analysis and development of the task, we found multiple scenarios.
            Such as:

            1. Should Import Considered for Phone Number validation
            2. Bug in Postal Code validation. (If country not given, it was validating according to default country as USA). It was corrected.
            3. Spouse Employer Work Phone extension was also considered in 10 digit validation.
            4. Decision about exactly which fields to be considered for validation. (Includes Employer level phone number fields)
            5. Multiple Phone Number fields for Beneficiary.
            6. Decision about uniqueness for Employee_Beneficiary and Employee_Emergency.

            All above points and daily tasks caused delay in the issue. Also, the issue has many scenarios for unit testing.

            CC_ Jaideep Vinchurkar

            Show
            suraj.sokasane Suraj Sokasane (Inactive) added a comment - During the analysis and development of the task, we found multiple scenarios. Such as: Should Import Considered for Phone Number validation Bug in Postal Code validation. (If country not given, it was validating according to default country as USA). It was corrected. Spouse Employer Work Phone extension was also considered in 10 digit validation. Decision about exactly which fields to be considered for validation. (Includes Employer level phone number fields) Multiple Phone Number fields for Beneficiary. Decision about uniqueness for Employee_Beneficiary and Employee_Emergency. All above points and daily tasks caused delay in the issue. Also, the issue has many scenarios for unit testing. CC_ Jaideep Vinchurkar
            Hide
            suraj.sokasane Suraj Sokasane (Inactive) added a comment -

            Hi Jayshree Nagpure

            For testing purpose, I've updated the Regex for two coutries on CAISO on LB.

            Country Home Phone Regex
            Afghanistan ^(\d {5}

            )$

            Albania ^(\d {7}

            )$

            Show
            suraj.sokasane Suraj Sokasane (Inactive) added a comment - Hi Jayshree Nagpure For testing purpose, I've updated the Regex for two coutries on CAISO on LB. Country Home Phone Regex Afghanistan ^(\d {5} )$ Albania ^(\d {7} )$
            Hide
            rashmita.dudhe Rashmita Dudhe (Inactive) added a comment -

            Jayshree Nagpure,

            CC:Hrishikesh Deshpande,Prasad Pise

            For above enhancement consider below pages in Testing
            1]Demographics data Import
            2]Spouse Information Import
            3]Child Information Import
            4]Beneficiary Import
            5]Emergency contact Information Import.

            Validate Phone No with Country.

            Thanks,
            Rashmita

            Show
            rashmita.dudhe Rashmita Dudhe (Inactive) added a comment - Jayshree Nagpure , CC: Hrishikesh Deshpande , Prasad Pise For above enhancement consider below pages in Testing 1]Demographics data Import 2]Spouse Information Import 3]Child Information Import 4]Beneficiary Import 5]Emergency contact Information Import. Validate Phone No with Country. Thanks, Rashmita
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Suraj Sokasane

            Company: caiso
            We have verified for below scenario:
            Demographics import
            Spouse import
            child import
            Beneficiary import
            emergency contact information import

            Successful import:
            demographics import
            child import
            Verified for positive and negative scenario.
            Working fine

            Import getting fail for below scenario:
            Spouse import
            Emergency contact information import

            And for beneficiary import: File went to bad with "Plan design does not exists"
            Even though Old plan design identifier name is entered correctly.

            Please refer linked jira WT-8447
            Thus updating item state as on hold on LB

            Thanks,
            Jayshree

            CC: Rashmita Dudhe Prasad Pise Rakesh Roy Jaideep Vinchurkar

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Suraj Sokasane Company: caiso We have verified for below scenario: Demographics import Spouse import child import Beneficiary import emergency contact information import Successful import: demographics import child import Verified for positive and negative scenario. Working fine Import getting fail for below scenario: Spouse import Emergency contact information import And for beneficiary import: File went to bad with "Plan design does not exists" Even though Old plan design identifier name is entered correctly. Please refer linked jira WT-8447 Thus updating item state as on hold on LB Thanks, Jayshree CC: Rashmita Dudhe Prasad Pise Rakesh Roy Jaideep Vinchurkar
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Suraj Sokasane,

            Verification is done for below scenario on Caiso:
            demographics import
            Spouse import and child import
            beneficiary and emergency contact import.
            Working as expected
            Updating item state as Ready for Stage.

            CC; Jaideep Vinchurkar Prasad Pise Rakesh Roy

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Suraj Sokasane , Verification is done for below scenario on Caiso: demographics import Spouse import and child import beneficiary and emergency contact import. Working as expected Updating item state as Ready for Stage. CC; Jaideep Vinchurkar Prasad Pise Rakesh Roy
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Suraj Sokasane,

            Tested Below scenario on Caiso for HSPL on Stage:
            1)Demographics import
            2)Spouse import
            3)Child import
            4)Beneficiary import
            Working as expected.
            5)For Emergency contact verified on Austin for Hspl, As on caiso for hspl mapping fields emergency information for primary and secondary were not present.
            Mapped country and phone number.
            Working as expected.
            Thus Updating item State as Ready for Production.

            Thanks,
            Jayshree

            CC: Prasad Pise Rakesh Roy Jaideep Vinchurkar

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Suraj Sokasane , Tested Below scenario on Caiso for HSPL on Stage: 1)Demographics import 2)Spouse import 3)Child import 4)Beneficiary import Working as expected. 5)For Emergency contact verified on Austin for Hspl, As on caiso for hspl mapping fields emergency information for primary and secondary were not present. Mapped country and phone number. Working as expected. Thus Updating item State as Ready for Production. Thanks, Jayshree CC: Prasad Pise Rakesh Roy Jaideep Vinchurkar
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Suraj Sokasane,

            Tested on Production on Caiso for Hspl.
            Verified all above scenario.
            Working as expected.
            Thus updating item state as production complete.

            Thanks,
            Jayshree

            CC ;Jaideep Vinchurkar Prasad Pise Rakesh Roy

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Suraj Sokasane , Tested on Production on Caiso for Hspl. Verified all above scenario. Working as expected. Thus updating item state as production complete. Thanks, Jayshree CC ; Jaideep Vinchurkar Prasad Pise Rakesh Roy
            Hide
            shyam.sharma shyam sharma (Inactive) added a comment - - edited

            Suraj Sokasane Jayshree Nagpure Rakesh Roy : Can you please look in to this on high priority ? and also can you please update JIRA ticket why it is not working
            and how this is tested and verified on Production. please provide complete history and detail why this is reopened.

            Abhay Patil : I understand your concern and we will take appropriate action on this.
            Basically the issue is: In the current workflow if because of any reason after testing it gets failed then there is no option to change status as Re-open. We will soon modify our workflow to address ticket status issue. But anyhow I do agree with you that Dev & QA should update ticket with proper comments , as now it is giving impression that this issue is production complete but in actual it is not.

            Show
            shyam.sharma shyam sharma (Inactive) added a comment - - edited Suraj Sokasane Jayshree Nagpure Rakesh Roy : Can you please look in to this on high priority ? and also can you please update JIRA ticket why it is not working and how this is tested and verified on Production. please provide complete history and detail why this is reopened. Abhay Patil : I understand your concern and we will take appropriate action on this. Basically the issue is: In the current workflow if because of any reason after testing it gets failed then there is no option to change status as Re-open. We will soon modify our workflow to address ticket status issue. But anyhow I do agree with you that Dev & QA should update ticket with proper comments , as now it is giving impression that this issue is production complete but in actual it is not.
            Hide
            shyam.sharma shyam sharma (Inactive) added a comment -

            Added one more step in workflow ReOpen on Production : Changed status of this ticket as ReOpen on Production

            Show
            shyam.sharma shyam sharma (Inactive) added a comment - Added one more step in workflow ReOpen on Production : Changed status of this ticket as ReOpen on Production
            Hide
            suraj.sokasane Suraj Sokasane (Inactive) added a comment -

            Hi All,

            Here are the details:

            What is the Enhancement:
            We took this Enhancement under UK benefits. Previously, phone number was validated as 10 digit only. But the enhancement implements country wise phone number validation. For example, now if country is UK, 11 digit phone number will be allowed.

            Why it failed :
            This is being implemented from UI as well as Import. Chaitali Acharya was doing UI part and I was doing Import part. The code is different but script is same. When Import ticket was marked as completed, I checked in the code but UK benefits team has kept all tickets on stage and hence the script wasn't gone to production and so it wasn't working on prod.

            Why Testing failed:
            Generally QA's follow process of testing the ticket on LB and Stage with full efforts. When it's on prod, not much efforts are wasted as if something is working on stage, only environment or check in related issues occur. Plus, if country is not given, we validate the phone number as per US format. Currently all countries allow 10 digit phone number. So, Jayshree Nagpure did not find the issue.

            As per shyam sharma,s comment the workflow does not allow to change status from production complete. But a informational comment could have been posted by us.

            Show
            suraj.sokasane Suraj Sokasane (Inactive) added a comment - Hi All, Here are the details: What is the Enhancement: We took this Enhancement under UK benefits. Previously, phone number was validated as 10 digit only. But the enhancement implements country wise phone number validation. For example, now if country is UK, 11 digit phone number will be allowed. Why it failed : This is being implemented from UI as well as Import. Chaitali Acharya was doing UI part and I was doing Import part. The code is different but script is same. When Import ticket was marked as completed, I checked in the code but UK benefits team has kept all tickets on stage and hence the script wasn't gone to production and so it wasn't working on prod. Why Testing failed: Generally QA's follow process of testing the ticket on LB and Stage with full efforts. When it's on prod, not much efforts are wasted as if something is working on stage, only environment or check in related issues occur. Plus, if country is not given, we validate the phone number as per US format. Currently all countries allow 10 digit phone number. So, Jayshree Nagpure did not find the issue. As per shyam sharma ,s comment the workflow does not allow to change status from production complete. But a informational comment could have been posted by us.

              People

              Assignee:
              jayshree.nagpure Jayshree Nagpure (Inactive)
              Reporter:
              chaitali.acharya Chaitali Acharya (Inactive)
              Developer:
              Suraj Sokasane (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 32h Original Estimate - 32h
                  32h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 58.25h
                  58.25h