Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-5323

Pre-Prod : employee management page showing validation message for grey out fileds

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Bug Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: UI Refresh
    • Labels:
      None
    • Environment:
      Pre Production
    • Bug Severity:
      Low
    • Level:
      Employee
    • Module:
      BenAdmin - EDS
    • Reported by:
      Harbinger
    • Company:
      City of Coalinga
    • Item State:
      Stage QA - Production Deployment on Hold

      Description

      Company name :City of Coalinga
      Employee management page.
      all filed are gray out when clicking on add button it showing the validation message.
      When click on save and continue button: it showing blank button and not navigating on next company.

        Attachments

          Issue Links

            Activity

            rashmita.dudhe Rashmita Dudhe (Inactive) created issue -
            rashmita.dudhe Rashmita Dudhe (Inactive) made changes -
            Field Original Value New Value
            Link This issue relates to NF-5195 [ NF-5195 ]
            Hide
            rashmita.dudhe Rashmita Dudhe (Inactive) added a comment -
            Show
            rashmita.dudhe Rashmita Dudhe (Inactive) added a comment - CC: Sachin Hingole , Nidhi Kaul
            rashmita.dudhe Rashmita Dudhe (Inactive) made changes -
            Assignee Nidhi Kaul [ nidhi.kaul ] Vijayendra Shinde [ ID10506 ]
            Show
            vijayendra Vijayendra Shinde (Inactive) added a comment - CC: Swapnil Pandhare , Nidhi Kaul
            vijayendra Vijayendra Shinde (Inactive) made changes -
            Assignee Vijayendra Shinde [ ID10506 ] Amit Kumawat [ amit.kumawat ]
            amit.kumawat Amit Kumawat (Inactive) made changes -
            Dev Due Date 27/Dec/2017
            Developer Amit Kumawat [ amit.kumawat ]
            rashmita.dudhe Rashmita Dudhe (Inactive) made changes -
            Component/s UI Refresh [ 10902 ]
            Module Parent values: UI Refresh(14304) Parent values: BenAdmin(10100)Level 1 values: EDS(10108)
            rashmita.dudhe Rashmita Dudhe (Inactive) made changes -
            Environment Others [ 18445 ] Pre Production [ 18470 ]
            amit.kumawat Amit Kumawat (Inactive) made changes -
            Status Open [ 1 ] In Development [ 10007 ]
            amit.kumawat Amit Kumawat (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204)
            amit.kumawat Amit Kumawat (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204) Parent values: Development(10200)Level 1 values: On Hold(10207)
            amit.kumawat Amit Kumawat (Inactive) logged work - 01/Dec/17 01:24 PM
            • Time Spent:
              1.75h
               

              Analysis try to repro issue

            amit.kumawat Amit Kumawat (Inactive) made changes -
            Remaining Estimate 0h [ 0 ]
            Time Spent 1.75h [ 6300 ]
            Worklog Id 94395 [ 94395 ]
            amit.kumawat Amit Kumawat (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: On Hold(10207) Parent values: Development(10200)Level 1 values: In Analysis(10204)
            amit.kumawat Amit Kumawat (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Analysis(10204) Parent values: Development(10200)Level 1 values: In Progress(10206)
            amit.kumawat Amit Kumawat (Inactive) logged work - 03/Dec/17 05:30 AM
            • Time Spent:
              2h
               

              Analysis on issue
              discussion with Swapnil

            amit.kumawat Amit Kumawat (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: In Progress(10206)
            Hide
            amit.kumawat Amit Kumawat (Inactive) added a comment - - edited

            Hello Rashmita Dudhe,

            As per discussion with Vijayendra Shinde & Swapnil Pandhare, this form (Employment Management) shouldn't be added in Employee Workflow. If needed please create a change request. Hence rejecting this JIRA ticket.

            CC: Sheetal Bodhale, Swapnil Pandhare, Satya

            Thanks & Regards,
            Amit Kumawat

            Show
            amit.kumawat Amit Kumawat (Inactive) added a comment - - edited Hello Rashmita Dudhe , As per discussion with Vijayendra Shinde & Swapnil Pandhare , this form (Employment Management) shouldn't be added in Employee Workflow. If needed please create a change request. Hence rejecting this JIRA ticket. CC: Sheetal Bodhale , Swapnil Pandhare , Satya Thanks & Regards, Amit Kumawat
            amit.kumawat Amit Kumawat (Inactive) made changes -
            Assignee Amit Kumawat [ amit.kumawat ] Rashmita Dudhe [ rashmita.dudhe ]
            Resolution System Behaviour [ 10100 ]
            Status In Development [ 10007 ] Rejected [ 10004 ]
            rashmita.dudhe Rashmita Dudhe (Inactive) made changes -
            Bug Severity Medium [ 16702 ] Low [ 16703 ]
            Priority High [ 2 ] Low [ 4 ]
            Original Estimate 0h [ 0 ]
            rashmita.dudhe Rashmita Dudhe (Inactive) made changes -
            Resolution System Behaviour [ 10100 ] Unresolved [ 10200 ]
            Status Rejected [ 10004 ] Reopen [ 4 ]
            rashmita.dudhe Rashmita Dudhe (Inactive) made changes -
            Assignee Rashmita Dudhe [ rashmita.dudhe ] Swapnil Pandhare [ swapnil.pandhare ]
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Level Employee [ 15801 ]
            Hide
            nidhi.kaul Nidhi Kaul (Inactive) added a comment -

            Swapnil PandhareAmit Kumawat

            This has been re-opened. Any update?

            Thanks,
            Nidhi.

            Show
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - Swapnil Pandhare Amit Kumawat This has been re-opened. Any update? Thanks, Nidhi.
            Hide
            swapnil.pandhare Swapnil Pandhare (Inactive) added a comment -

            Hi Nidhi Kaul ,

            There was no patch given for this issue, It is reopened with discussion over employment management page functionality and marking the priority as low as no production company uses the same in employee workflow.

            Thanks,
            Swapnil P.

            Show
            swapnil.pandhare Swapnil Pandhare (Inactive) added a comment - Hi Nidhi Kaul , There was no patch given for this issue, It is reopened with discussion over employment management page functionality and marking the priority as low as no production company uses the same in employee workflow. Thanks, Swapnil P.
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Status Reopen [ 4 ] In Development [ 10007 ]
            amit.kumawat Amit Kumawat (Inactive) logged work - 04/Dec/17 05:43 PM
            • Time Spent:
              0.5h
               

              Discussion with Swapnil
              Analysis

            amit.kumawat Amit Kumawat (Inactive) made changes -
            Time Spent 1.75h [ 6300 ] 3.75h [ 13500 ]
            Worklog Id 94652 [ 94652 ]
            amit.kumawat Amit Kumawat (Inactive) made changes -
            Time Spent 3.75h [ 13500 ] 4.25h [ 15300 ]
            Worklog Id 94659 [ 94659 ]
            swapnil.pandhare Swapnil Pandhare (Inactive) made changes -
            Assignee Swapnil Pandhare [ swapnil.pandhare ] Niteen Surwase [ niteen.surwase ]
            niteen.surwase Niteen Surwase (Inactive) logged work - 05/Dec/17 05:00 PM
            • Time Spent:
              5.5h
               

              Analysis and Reproducing issue.
              Discussion with Swapnil and Amit
              Coding for the issue.
              Unit Testing

            niteen.surwase Niteen Surwase (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208)
            Hide
            nidhi.kaul Nidhi Kaul (Inactive) added a comment -

            Swapnil PandhareNiteen Surwase

            With more companies using this form in workflow, this needs to go in next codemap build.

            Vijayendra Shinde
            Thanks,
            Nidhi.

            Show
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - Swapnil Pandhare Niteen Surwase With more companies using this form in workflow, this needs to go in next codemap build. Vijayendra Shinde Thanks, Nidhi.
            nidhi.kaul Nidhi Kaul (Inactive) made changes -
            Priority Low [ 4 ] High [ 2 ]
            niteen.surwase Niteen Surwase (Inactive) logged work - 07/Dec/17 05:00 PM
            • Time Spent:
              2.5h
               

              Coding to Change Error Message and Unit Testing

            niteen.surwase Niteen Surwase (Inactive) made changes -
            Time Spent 4.25h [ 15300 ] 6.75h [ 24300 ]
            Worklog Id 95434 [ 95434 ]
            niteen.surwase Niteen Surwase (Inactive) made changes -
            Time Spent 6.75h [ 24300 ] 12.25h [ 44100 ]
            Worklog Id 95438 [ 95438 ]
            niteen.surwase Niteen Surwase (Inactive) made changes -
            Code Reviewed By Swapnil Pandhare [ 11900 ]
            Developer Amit Kumawat [ amit.kumawat ] Niteen Surwase [ niteen.surwase ]
            Root Cause Scenario/Requirement Missed [ 18432 ]
            Hide
            niteen.surwase Niteen Surwase (Inactive) added a comment - - edited

            Affected Files :
            WORKTERRA\Scripts\EmployeeProfile.js

            3Cs
            Concern : Validation show for disabled fields (Review Date and Review Manager)
            Cause: Validation not handled for mandatory fields which were disabled.
            Correction: Validation handled for disabled fields and we have shown respective alert for mandatory fields

            Cc; Swapnil Pandhare

            Show
            niteen.surwase Niteen Surwase (Inactive) added a comment - - edited Affected Files : WORKTERRA\Scripts\EmployeeProfile.js 3Cs Concern : Validation show for disabled fields (Review Date and Review Manager) Cause : Validation not handled for mandatory fields which were disabled. Correction : Validation handled for disabled fields and we have shown respective alert for mandatory fields Cc; Swapnil Pandhare
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: Development(10200)Level 1 values: Ready for Review(10208) Parent values: LB QA(10201)Level 1 values: LB Deployed(11600)
            niteen.surwase Niteen Surwase (Inactive) logged work - 19/Dec/17 05:00 PM
            • Time Spent:
              1.25h
               

              Review Issue with Swapnil.
              Changes and Check-ins

            Hide
            niteen.surwase Niteen Surwase (Inactive) added a comment -

            Hi Rashmita Dudhe

            This fix has been deployed on LB. Please verify this fix.

            Cc: Swapnil Pandhare Satya

            Show
            niteen.surwase Niteen Surwase (Inactive) added a comment - Hi Rashmita Dudhe This fix has been deployed on LB. Please verify this fix. Cc: Swapnil Pandhare Satya
            niteen.surwase Niteen Surwase (Inactive) made changes -
            Assignee Niteen Surwase [ niteen.surwase ] Rashmita Dudhe [ rashmita.dudhe ]
            swapnil.eksambekar Swapnil Eksambekar (Inactive) made changes -
            Assignee Rashmita Dudhe [ rashmita.dudhe ] Kunal Kedari [ kunal.kedari ]
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Status In Development [ 10007 ] Local Testing [ 10200 ]
            sachin.hingole Sachin Hingole (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: LB Deployed(11600) Parent values: LB QA(10201)Level 1 values: In Testing(10210)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Attachment Pass_Codemap_ValidationMessage.jpg [ 70556 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            We have verified this fix on codemap, as "City of Coalinga" company is not present on codemap, we checked if on "For QA-JE Dunn-Azure".
            The fix is working as expected. We can deploy fix to next environment.

            Verified following things:
            1] Proper validation message is displaying for "Review Date" and "Review Manager" fields.
            2] Now fields on the "Employee Management" form are not grayed out on page load.
            3] Employee can fill up the details on "Employee Management" form.
            4] Employee can proceed to next step in the workflow by saving "Employee Management" form.
            5] Details fill up by employee on "Employee Management" form are getting saved properly.

            Refer attached screenshots for more details.

            Cc: Rashmita Dudhe, Sachin Hingole, Prasad Pise, Niteen Surwase, Swapnil Pandhare,Rashmita Dudhe, Swapnil Eksambekar

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - We have verified this fix on codemap, as "City of Coalinga" company is not present on codemap, we checked if on "For QA-JE Dunn-Azure". The fix is working as expected. We can deploy fix to next environment. Verified following things: 1] Proper validation message is displaying for "Review Date" and "Review Manager" fields. 2] Now fields on the "Employee Management" form are not grayed out on page load. 3] Employee can fill up the details on "Employee Management" form. 4] Employee can proceed to next step in the workflow by saving "Employee Management" form. 5] Details fill up by employee on "Employee Management" form are getting saved properly. Refer attached screenshots for more details. Cc: Rashmita Dudhe , Sachin Hingole , Prasad Pise , Niteen Surwase , Swapnil Pandhare , Rashmita Dudhe , Swapnil Eksambekar
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: In Testing(10210) Parent values: LB QA(10201)Level 1 values: On Hold(10211)
            kunal.kedari Kunal Kedari (Inactive) logged work - 21/Dec/17 06:00 PM
            • Time Spent:
              1h
               

              Fix verification on codemap

            niteen.surwase Niteen Surwase (Inactive) made changes -
            Time Spent 12.25h [ 44100 ] 13.5h [ 48600 ]
            Worklog Id 97448 [ 97448 ]
            khandu.kshirsagar Khandu Kshirsagar (Inactive) made changes -
            Item State Parent values: LB QA(10201)Level 1 values: On Hold(10211) Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: Stage Deployed(11602) Parent values: Stage QA(10202)Level 1 values: In Testing(10214)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Local Testing [ 10200 ] Stage Testing [ 10201 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Item State Parent values: Stage QA(10202)Level 1 values: In Testing(10214) Parent values: Stage QA(10202)Level 1 values: Production Deployment on Hold(10224)
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Time Spent 13.5h [ 48600 ] 14.5h [ 52200 ]
            Worklog Id 98697 [ 98697 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Attachment ReviewNotes.jpg [ 74679 ]
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Hi Niteen Surwase,

            We have verified mentioned fix on Production using "City of Coalinga For HSPL" . Can you please let us know your inputs on below point:

            Review notes cannot be get added, as "Review Date" , "Review Manager" and "Next Review Date" fields are disabled. Can you please let us know whether these fields are always disabled for employee, if so employee can never able to add review notes:

            Please note employee is able to proceed through flow without adding review notes as well.

            Cc: Prasad Pise, Hrishikesh Deshpande, Sachin Hingole, Vijayendra Shinde

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Hi Niteen Surwase , We have verified mentioned fix on Production using "City of Coalinga For HSPL" . Can you please let us know your inputs on below point: Review notes cannot be get added, as "Review Date" , "Review Manager" and "Next Review Date" fields are disabled. Can you please let us know whether these fields are always disabled for employee, if so employee can never able to add review notes: Please note employee is able to proceed through flow without adding review notes as well. Cc: Prasad Pise , Hrishikesh Deshpande , Sachin Hingole , Vijayendra Shinde
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Stage Testing [ 10201 ] Production Testing [ 10202 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Assignee Kunal Kedari [ kunal.kedari ] Niteen Surwase [ niteen.surwase ]
            Hide
            niteen.surwase Niteen Surwase (Inactive) added a comment -

            Hi Kunal Kedari

             

            Review Notes Field is not necessary to save if it is disabled. But, above fields are required to Editable/Required only to add in grid.

             

            Thanks,

            Niteen S.

             

            CC: Swapnil Pandhare Satya

            Show
            niteen.surwase Niteen Surwase (Inactive) added a comment - Hi Kunal Kedari   Review Notes Field is not necessary to save if it is disabled. But, above fields are required to Editable/Required only to add in grid.   Thanks, Niteen S.   CC: Swapnil Pandhare Satya
            niteen.surwase Niteen Surwase (Inactive) made changes -
            Assignee Niteen Surwase [ niteen.surwase ] Kunal Kedari [ kunal.kedari ]
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Closing the issue.

             

             

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Closing the issue.    
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Resolution Unresolved [ 10200 ] Bug Fixed [ 10402 ]
            Status Production Testing [ 10202 ] Production Complete [ 10028 ]
            kunal.kedari Kunal Kedari (Inactive) made changes -
            Status Production Complete [ 10028 ] Closed [ 6 ]
            Transition Time In Source Status Execution Times
            Amit Kumawat (Inactive) made transition -
            Open In Development
            3h 47m 1
            Amit Kumawat (Inactive) made transition -
            In Development Rejected
            2d 17h 29m 1
            Rashmita Dudhe (Inactive) made transition -
            Rejected Reopen
            18m 23s 1
            Swapnil Pandhare (Inactive) made transition -
            Reopen In Development
            4h 40m 1
            Sachin Hingole (Inactive) made transition -
            In Development In LB Testing
            16d 20h 1m 1
            Kunal Kedari (Inactive) made transition -
            In LB Testing Stage Testing
            7d 3h 4m 1
            Kunal Kedari (Inactive) made transition -
            Stage Testing In Production Testing
            76d 21h 53m 1
            Kunal Kedari (Inactive) made transition -
            In Production Testing Production Complete
            10d 19h 20m 1
            Kunal Kedari (Inactive) made transition -
            Production Complete Closed
            4s 1

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              rashmita.dudhe Rashmita Dudhe (Inactive)
              Developer:
              Niteen Surwase (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Dev Due Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0h
                  0h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 14.5h
                  14.5h