Uploaded image for project: 'New Features 2017'
  1. New Features 2017
  2. NF-5323

Pre-Prod : employee management page showing validation message for grey out fileds

    Details

    • Type: Bug
    • Status: Closed
    • Priority: High
    • Resolution: Bug Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: UI Refresh
    • Labels:
      None
    • Environment:
      Pre Production
    • Bug Severity:
      Low
    • Level:
      Employee
    • Module:
      BenAdmin - EDS
    • Reported by:
      Harbinger
    • Company:
      City of Coalinga
    • Item State:
      Stage QA - Production Deployment on Hold

      Description

      Company name :City of Coalinga
      Employee management page.
      all filed are gray out when clicking on add button it showing the validation message.
      When click on save and continue button: it showing blank button and not navigating on next company.

        Attachments

          Issue Links

            Activity

            Hide
            rashmita.dudhe Rashmita Dudhe (Inactive) added a comment -
            Show
            rashmita.dudhe Rashmita Dudhe (Inactive) added a comment - CC: Sachin Hingole , Nidhi Kaul
            Show
            vijayendra Vijayendra Shinde (Inactive) added a comment - CC: Swapnil Pandhare , Nidhi Kaul
            Hide
            amit.kumawat Amit Kumawat (Inactive) added a comment - - edited

            Hello Rashmita Dudhe,

            As per discussion with Vijayendra Shinde & Swapnil Pandhare, this form (Employment Management) shouldn't be added in Employee Workflow. If needed please create a change request. Hence rejecting this JIRA ticket.

            CC: Sheetal Bodhale, Swapnil Pandhare, Satya

            Thanks & Regards,
            Amit Kumawat

            Show
            amit.kumawat Amit Kumawat (Inactive) added a comment - - edited Hello Rashmita Dudhe , As per discussion with Vijayendra Shinde & Swapnil Pandhare , this form (Employment Management) shouldn't be added in Employee Workflow. If needed please create a change request. Hence rejecting this JIRA ticket. CC: Sheetal Bodhale , Swapnil Pandhare , Satya Thanks & Regards, Amit Kumawat
            Hide
            nidhi.kaul Nidhi Kaul (Inactive) added a comment -

            Swapnil PandhareAmit Kumawat

            This has been re-opened. Any update?

            Thanks,
            Nidhi.

            Show
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - Swapnil Pandhare Amit Kumawat This has been re-opened. Any update? Thanks, Nidhi.
            Hide
            swapnil.pandhare Swapnil Pandhare (Inactive) added a comment -

            Hi Nidhi Kaul ,

            There was no patch given for this issue, It is reopened with discussion over employment management page functionality and marking the priority as low as no production company uses the same in employee workflow.

            Thanks,
            Swapnil P.

            Show
            swapnil.pandhare Swapnil Pandhare (Inactive) added a comment - Hi Nidhi Kaul , There was no patch given for this issue, It is reopened with discussion over employment management page functionality and marking the priority as low as no production company uses the same in employee workflow. Thanks, Swapnil P.
            Hide
            nidhi.kaul Nidhi Kaul (Inactive) added a comment -

            Swapnil PandhareNiteen Surwase

            With more companies using this form in workflow, this needs to go in next codemap build.

            Vijayendra Shinde
            Thanks,
            Nidhi.

            Show
            nidhi.kaul Nidhi Kaul (Inactive) added a comment - Swapnil Pandhare Niteen Surwase With more companies using this form in workflow, this needs to go in next codemap build. Vijayendra Shinde Thanks, Nidhi.
            Hide
            niteen.surwase Niteen Surwase (Inactive) added a comment - - edited

            Affected Files :
            WORKTERRA\Scripts\EmployeeProfile.js

            3Cs
            Concern : Validation show for disabled fields (Review Date and Review Manager)
            Cause: Validation not handled for mandatory fields which were disabled.
            Correction: Validation handled for disabled fields and we have shown respective alert for mandatory fields

            Cc; Swapnil Pandhare

            Show
            niteen.surwase Niteen Surwase (Inactive) added a comment - - edited Affected Files : WORKTERRA\Scripts\EmployeeProfile.js 3Cs Concern : Validation show for disabled fields (Review Date and Review Manager) Cause : Validation not handled for mandatory fields which were disabled. Correction : Validation handled for disabled fields and we have shown respective alert for mandatory fields Cc; Swapnil Pandhare
            Hide
            niteen.surwase Niteen Surwase (Inactive) added a comment -

            Hi Rashmita Dudhe

            This fix has been deployed on LB. Please verify this fix.

            Cc: Swapnil Pandhare Satya

            Show
            niteen.surwase Niteen Surwase (Inactive) added a comment - Hi Rashmita Dudhe This fix has been deployed on LB. Please verify this fix. Cc: Swapnil Pandhare Satya
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            We have verified this fix on codemap, as "City of Coalinga" company is not present on codemap, we checked if on "For QA-JE Dunn-Azure".
            The fix is working as expected. We can deploy fix to next environment.

            Verified following things:
            1] Proper validation message is displaying for "Review Date" and "Review Manager" fields.
            2] Now fields on the "Employee Management" form are not grayed out on page load.
            3] Employee can fill up the details on "Employee Management" form.
            4] Employee can proceed to next step in the workflow by saving "Employee Management" form.
            5] Details fill up by employee on "Employee Management" form are getting saved properly.

            Refer attached screenshots for more details.

            Cc: Rashmita Dudhe, Sachin Hingole, Prasad Pise, Niteen Surwase, Swapnil Pandhare,Rashmita Dudhe, Swapnil Eksambekar

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - We have verified this fix on codemap, as "City of Coalinga" company is not present on codemap, we checked if on "For QA-JE Dunn-Azure". The fix is working as expected. We can deploy fix to next environment. Verified following things: 1] Proper validation message is displaying for "Review Date" and "Review Manager" fields. 2] Now fields on the "Employee Management" form are not grayed out on page load. 3] Employee can fill up the details on "Employee Management" form. 4] Employee can proceed to next step in the workflow by saving "Employee Management" form. 5] Details fill up by employee on "Employee Management" form are getting saved properly. Refer attached screenshots for more details. Cc: Rashmita Dudhe , Sachin Hingole , Prasad Pise , Niteen Surwase , Swapnil Pandhare , Rashmita Dudhe , Swapnil Eksambekar
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Hi Niteen Surwase,

            We have verified mentioned fix on Production using "City of Coalinga For HSPL" . Can you please let us know your inputs on below point:

            Review notes cannot be get added, as "Review Date" , "Review Manager" and "Next Review Date" fields are disabled. Can you please let us know whether these fields are always disabled for employee, if so employee can never able to add review notes:

            Please note employee is able to proceed through flow without adding review notes as well.

            Cc: Prasad Pise, Hrishikesh Deshpande, Sachin Hingole, Vijayendra Shinde

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Hi Niteen Surwase , We have verified mentioned fix on Production using "City of Coalinga For HSPL" . Can you please let us know your inputs on below point: Review notes cannot be get added, as "Review Date" , "Review Manager" and "Next Review Date" fields are disabled. Can you please let us know whether these fields are always disabled for employee, if so employee can never able to add review notes: Please note employee is able to proceed through flow without adding review notes as well. Cc: Prasad Pise , Hrishikesh Deshpande , Sachin Hingole , Vijayendra Shinde
            Hide
            niteen.surwase Niteen Surwase (Inactive) added a comment -

            Hi Kunal Kedari

             

            Review Notes Field is not necessary to save if it is disabled. But, above fields are required to Editable/Required only to add in grid.

             

            Thanks,

            Niteen S.

             

            CC: Swapnil Pandhare Satya

            Show
            niteen.surwase Niteen Surwase (Inactive) added a comment - Hi Kunal Kedari   Review Notes Field is not necessary to save if it is disabled. But, above fields are required to Editable/Required only to add in grid.   Thanks, Niteen S.   CC: Swapnil Pandhare Satya
            Hide
            kunal.kedari Kunal Kedari (Inactive) added a comment -

            Closing the issue.

             

             

            Show
            kunal.kedari Kunal Kedari (Inactive) added a comment - Closing the issue.    

              People

              Assignee:
              kunal.kedari Kunal Kedari (Inactive)
              Reporter:
              rashmita.dudhe Rashmita Dudhe (Inactive)
              Developer:
              Niteen Surwase (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Dev Due Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0h
                  0h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 14.5h
                  14.5h