Uploaded image for project: 'WORKTERRA'
  1. WORKTERRA
  2. WT-8853

Import - Template Settings - Changes for "Multiple Rows?"

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Low
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: BenAdmin
    • Labels:
    • Environment:
      Production
    • Bug Severity:
      Medium
    • Module:
      BenAdmin - Import
    • Reported by:
      Support
    • Item State:
      Production Complete - Closed

      Description

      Change help text : The current help text : "No all data in a single row; Yes 1 row per enrollment/demographic information" does not give clear information about what should be the value for which template.

      If it is set to No for normal template, Import is failed. We need to change the text.

      Restriction on changing the flag : The flag is allowed to change only if the Import type is Paycheck.

        Attachments

          Activity

          Hide
          abhay.patil Abhay Patil (Inactive) added a comment - - edited

          Thanks Suraj Sokasane for raising this ticket. Reading the description I get a feeling that not just the help text, but also name of the field needs to be improved. I mean, name of the field should use the vocabulary of the business - and not of the database.

          Consider this suggestion - more as a representative idea. Please discuss this and improve it if necessary.
          *Name of the field: Regular template OR Normal template
          Options: Yes (default) / No
          Help text: Set to "no" only for column wise imports (e.g. payroll) where data is one row. Otherwise use default value "yes" that allows multiple rows.*

          CC Bharti Satpute Nathaniel Cornejo-Walker Cindy Wibbing Amit Thorve

          Show
          abhay.patil Abhay Patil (Inactive) added a comment - - edited Thanks Suraj Sokasane for raising this ticket. Reading the description I get a feeling that not just the help text, but also name of the field needs to be improved. I mean, name of the field should use the vocabulary of the business - and not of the database. Consider this suggestion - more as a representative idea. Please discuss this and improve it if necessary. *Name of the field: Regular template OR Normal template Options: Yes (default) / No Help text: Set to "no" only for column wise imports (e.g. payroll) where data is one row. Otherwise use default value "yes" that allows multiple rows.* CC Bharti Satpute Nathaniel Cornejo-Walker Cindy Wibbing Amit Thorve
          Hide
          suraj.sokasane Suraj Sokasane (Inactive) added a comment -

          Hi Abhay Patil,

          We have made the changes at local environment. Following are the details of our approach:

          1. Disable "Multiple Rows?" for all imports except paychek.

            Both the row wise and column wise features are currently only used for paycheck. So we have hidden it for other imports.

          2. Help text changed:

            The help text was changed to "No - all data in a single row; Yes - 1 row per lineitem information" which will be only visible for Paycheck data import templates

          3. Field label not changed:

            The field name says Multiple Rows? which sounds correct as if Multiple rows is yes, one employee will have multiple rows for their paycheck data. One row for each paycjheck line item. So we have not changed it.

          Please let us know if we can go ahead with this.

          CC: Jaideep Vinchurkar

          Show
          suraj.sokasane Suraj Sokasane (Inactive) added a comment - Hi Abhay Patil , We have made the changes at local environment. Following are the details of our approach: Disable "Multiple Rows?" for all imports except paychek. Both the row wise and column wise features are currently only used for paycheck. So we have hidden it for other imports. Help text changed: The help text was changed to "No - all data in a single row; Yes - 1 row per lineitem information" which will be only visible for Paycheck data import templates Field label not changed: The field name says Multiple Rows? which sounds correct as if Multiple rows is yes, one employee will have multiple rows for their paycheck data. One row for each paycjheck line item. So we have not changed it. Please let us know if we can go ahead with this. CC: Jaideep Vinchurkar
          Hide
          suraj.sokasane Suraj Sokasane (Inactive) added a comment - - edited

          Hi Abhay Patil,

          A gentle reminder for the comment above. Please tell us if we can go ahead.

          CC: Jaideep Vinchurkar, Satya, Vijay Siddha, Rakesh Roy

          Show
          suraj.sokasane Suraj Sokasane (Inactive) added a comment - - edited Hi Abhay Patil , A gentle reminder for the comment above. Please tell us if we can go ahead. CC: Jaideep Vinchurkar , Satya , Vijay Siddha , Rakesh Roy
          Hide
          abhay.patil Abhay Patil (Inactive) added a comment -

          Sorry for the delay. Please go ahead Suraj Sokasane.

          Show
          abhay.patil Abhay Patil (Inactive) added a comment - Sorry for the delay. Please go ahead Suraj Sokasane .
          Hide
          suraj.sokasane Suraj Sokasane (Inactive) added a comment - - edited

          Affected Files:
          /branches/LB/Web/Web Projects/WORKTERRA/Areas/Customization/Models/EDI/TemplateSettingsModel.cs
          /branches/LB/Web/Web Projects/WORKTERRA/Areas/Customization/Views/Customization/EDI/TemplateSettings.cshtml
          /branches/LB/App/BusinessLogic/ImportExportDTS/ExecuteImportDTS.vb

          /branches/LB/Shared Library/WORKTERRALocalization/WORKTERRAResource.Designer.cs
          /branches/LB/Shared Library/WORKTERRALocalization/WORKTERRAResource.en-GB.resx
          /branches/LB/Shared Library/WORKTERRALocalization/WORKTERRAResource.es-mx.resx
          /branches/LB/Shared Library/WORKTERRALocalization/WORKTERRAResource.fr-CA.resx
          /branches/LB/Shared Library/WORKTERRALocalization/WORKTERRAResource.resx

          Impacted areas :

          • Template Management -> Template Settings page
          • Manual / Automated Import import
          • Paycheck Import - Row wise/ Column wise

          Unit Testing Done:

          • Template settings Page
          • paycheck import with flag yes and no
          • Manual import with default flag
          Show
          suraj.sokasane Suraj Sokasane (Inactive) added a comment - - edited Affected Files: /branches/LB/Web/Web Projects/WORKTERRA/Areas/Customization/Models/EDI/TemplateSettingsModel.cs /branches/LB/Web/Web Projects/WORKTERRA/Areas/Customization/Views/Customization/EDI/TemplateSettings.cshtml /branches/LB/App/BusinessLogic/ImportExportDTS/ExecuteImportDTS.vb /branches/LB/Shared Library/WORKTERRALocalization/WORKTERRAResource.Designer.cs /branches/LB/Shared Library/WORKTERRALocalization/WORKTERRAResource.en-GB.resx /branches/LB/Shared Library/WORKTERRALocalization/WORKTERRAResource.es-mx.resx /branches/LB/Shared Library/WORKTERRALocalization/WORKTERRAResource.fr-CA.resx /branches/LB/Shared Library/WORKTERRALocalization/WORKTERRAResource.resx Impacted areas : Template Management -> Template Settings page Manual / Automated Import import Paycheck Import - Row wise/ Column wise Unit Testing Done: Template settings Page paycheck import with flag yes and no Manual import with default flag
          Hide
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Hi Suraj Sokasane,

          Verified this issue on Bellevue on LB.
          Verified for the below scenario:
          1)Template Management -> Template Settings page
          2)Paycheck Import - > Row wise / Column wise
          3)For demographics -> Removed multiple rows flag : By default its yes - > Import done successfully
          Working fine as expected.

          In addition while checking on UI We have observed that there are no validations for Item-line fields value.
          Eg : For amount its accepting Alphanumeric, for date its accepting any characters, numbers and so on.
          Discussed with Dev team, through Import validation is not yet implemented.

          Updating item state as Ready for Stage.

          Thanks,
          Jayshree

          CC: Rakesh Roy Prasad Pise

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Suraj Sokasane , Verified this issue on Bellevue on LB. Verified for the below scenario: 1)Template Management -> Template Settings page 2)Paycheck Import - > Row wise / Column wise 3)For demographics -> Removed multiple rows flag : By default its yes - > Import done successfully Working fine as expected. In addition while checking on UI We have observed that there are no validations for Item-line fields value. Eg : For amount its accepting Alphanumeric, for date its accepting any characters, numbers and so on. Discussed with Dev team, through Import validation is not yet implemented. Updating item state as Ready for Stage. Thanks, Jayshree CC: Rakesh Roy Prasad Pise
          Hide
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Hi Suraj Sokasane,

          Verified on Stage
          Company - ASML for hspl
          Verified all above scenario's
          Working as expected
          Updating item state as Ready for Production

          Thanks,
          Jayshree

          CC: Rakesh Roy Prasad Pise

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Suraj Sokasane , Verified on Stage Company - ASML for hspl Verified all above scenario's Working as expected Updating item state as Ready for Production Thanks, Jayshree CC: Rakesh Roy Prasad Pise
          Hide
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

          Hi Suraj Sokasane,

          Verified on Production
          company - Je dunn for hspl
          Login - Partner
          Verified for the below scenario:
          1)Template Management -> Template Settings page
          2)Paycheck Import - > Row wise
          3)For demographics -> Removed multiple rows flag : By default its yes - > Import done successfully

          For Column wise pay check import, its main jira WT-7632 is not deployed on production
          So column wise paycheck import is not currently working
          We will verify it on production once its main jira will deploy

          So for now , keeping this jira on hold.

          Thanks,
          Jayshree

          CC: Rakesh Roy Prasad Pise

          Show
          jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Suraj Sokasane , Verified on Production company - Je dunn for hspl Login - Partner Verified for the below scenario: 1)Template Management -> Template Settings page 2)Paycheck Import - > Row wise 3)For demographics -> Removed multiple rows flag : By default its yes - > Import done successfully For Column wise pay check import, its main jira WT-7632 is not deployed on production So column wise paycheck import is not currently working We will verify it on production once its main jira will deploy So for now , keeping this jira on hold. Thanks, Jayshree CC: Rakesh Roy Prasad Pise
          Hide
          hrishikesh.deshpande Hrishikesh Deshpande (Inactive) added a comment -

          Closing this JIRA as Column wise pay check import will cover under WT-7632.

          Show
          hrishikesh.deshpande Hrishikesh Deshpande (Inactive) added a comment - Closing this JIRA as Column wise pay check import will cover under WT-7632 .

            People

            Assignee:
            jayshree.nagpure Jayshree Nagpure (Inactive)
            Reporter:
            suraj.sokasane Suraj Sokasane (Inactive)
            Developer:
            Suraj Sokasane (Inactive)
            QA:
            Jayshree Nagpure (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Pre-Prod Due Date:
              Production Due Date:

                Time Tracking

                Estimated:
                Original Estimate - 3h Original Estimate - 3h
                3h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 22.75h
                22.75h