Uploaded image for project: 'WORKTERRA'
  1. WORKTERRA
  2. WT-12252

Effective Date format issue for Employee Import

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: BenAdmin
    • Labels:
    • Environment:
      Others
    • Bug Type:
      Functional
    • Bug Severity:
      Medium
    • Module:
      BenAdmin - Import
    • Reported by:
      Others
    • Company:
      All Clients/Multiple Clients
    • Item State:
      Production Complete - Closed
    • Sprint:
      WT Sprint 41

      Description

      *Scenario - *
      1) On Template Settings set date format as 'YYYYMMDD'.
      2) Add Employee's effective date field in sub template and map it to 'Employee Effective Date'.
      3) Manual or Scheduled import gets failed.

      Cause -
      When system tries to convert date value string to date format, it throws an exception. Ex. ''20100101' string can not convert to Date'. Since, string value don't have any separator, CType function can not convert it to appropriate date format.

      Correction -
      Code change is needed

        Attachments

        1. ElectioneffectiveDate.txt
          0.4 kB
        2. EmpEffectiveDate.txt
          0.7 kB
        3. FinalUpdatedTestcases.xls
          28 kB
        4. FW 1211 Sprint - Development Approval.msg
          51 kB
        5. FW Hot Fix and Development Approval Request.msg
          60 kB
        6. RE Approvals.msg
          34 kB
        7. Testcases.xls
          26 kB
        8. UpdatedTestcases.xls
          28 kB
        9. WaiveDate.jpg
          WaiveDate.jpg
          195 kB
        10. WaiveDate.txt
          0.5 kB
        11. WT-12252 Data.xls
          19 kB

          Issue Links

            Activity

            Hide
            abhay.patil Abhay Patil (Inactive) added a comment -

            This is quite basic bug that needs to be fixed ASAP.

            Show
            abhay.patil Abhay Patil (Inactive) added a comment - This is quite basic bug that needs to be fixed ASAP.
            Hide
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) added a comment -

            Concern: Import is getting failed for 'YYYYMMDD' data format

            Cause: Import do support 'YYYYMMDD' date format. While working on generic solution to create users, we have added a new function in system, that stores newly added employees in a table in format of key-value pair. Here employee id is considered as key and effective date is considered as value. This data is getting used later for further enrollment data processing. Though, in file we allow different types of date formats, internally we use MM/DD/YYYY format for calulation. So, while storing data in table we convert all types of dates in MM/DD/YYYY format. For this conversion, we use default .net function. However, this function requires 10 characters length for date. Since, YYYYMMDD has only 8 characters it is throwing exception.

            Correction: We have to change the code to format data in correction format.

            Please note: We understand that this very basic bug. However, this will require a code change and we will have to go through entire deployment process, we would need development and deployment approval for this. Could you please take this up with Jennifer Reed and Nagini Indugula, so that we can plan the resolution as soon as possible.

            Show
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) added a comment - Concern: Import is getting failed for 'YYYYMMDD' data format Cause: Import do support 'YYYYMMDD' date format. While working on generic solution to create users, we have added a new function in system, that stores newly added employees in a table in format of key-value pair. Here employee id is considered as key and effective date is considered as value. This data is getting used later for further enrollment data processing. Though, in file we allow different types of date formats, internally we use MM/DD/YYYY format for calulation. So, while storing data in table we convert all types of dates in MM/DD/YYYY format. For this conversion, we use default .net function. However, this function requires 10 characters length for date. Since, YYYYMMDD has only 8 characters it is throwing exception. Correction: We have to change the code to format data in correction format. Please note: We understand that this very basic bug. However, this will require a code change and we will have to go through entire deployment process, we would need development and deployment approval for this. Could you please take this up with Jennifer Reed and Nagini Indugula , so that we can plan the resolution as soon as possible.
            Hide
            gaurav.sodani Gaurav Sodani (Inactive) added a comment -

            Hi All,

            Attaching the development approval email for your reference

            Regards
            Gaurav

            Show
            gaurav.sodani Gaurav Sodani (Inactive) added a comment - Hi All, Attaching the development approval email for your reference Regards Gaurav
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Attached test cases Testcases.xls

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Attached test cases Testcases.xls
            Hide
            snehal.katkar Snehal Katkar (Inactive) added a comment - - edited

            File Changed:
            1) D:\WT\branches\UiRefresh\App\BusinessLogic\ImportExportDTS\ImportValidation.vb

            Show
            snehal.katkar Snehal Katkar (Inactive) added a comment - - edited File Changed: 1) D:\WT\branches\UiRefresh\App\BusinessLogic\ImportExportDTS\ImportValidation.vb
            Hide
            abhay.patil Abhay Patil (Inactive) added a comment -

            We need it on Prod ASAP as the client is waiting for it.

            Show
            abhay.patil Abhay Patil (Inactive) added a comment - We need it on Prod ASAP as the client is waiting for it.
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited

            Hi Snehal Katkar,

            Verified on LB
            Company - ASML

            Verified scenarios are attached in test cases
            For below scenarios import is getting fail when date format in setting is YYYYMMDD :
            1) Not mapping employee effective date. EmpEffectiveDate.txt
            2) Mapping employee effective date but passing value as blank or ~
            3) For enrollment effective date ElectioneffectiveDate.txt
            4) For Waive effective date WaiveDate.txt
            5) For Paycheck effective date
            Other scenarios its working fine

            Hence re-opening this jira.

            Thanks,
            Jayshree

            cc : Rakesh Roy Prasad Pise Hrishikesh Deshpande Jaideep Vinchurkar

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited Hi Snehal Katkar , Verified on LB Company - ASML Verified scenarios are attached in test cases For below scenarios import is getting fail when date format in setting is YYYYMMDD : 1) Not mapping employee effective date. EmpEffectiveDate.txt 2) Mapping employee effective date but passing value as blank or ~ 3) For enrollment effective date ElectioneffectiveDate.txt 4) For Waive effective date WaiveDate.txt 5) For Paycheck effective date Other scenarios its working fine Hence re-opening this jira. Thanks, Jayshree cc : Rakesh Roy Prasad Pise Hrishikesh Deshpande Jaideep Vinchurkar
            Hide
            snehal.katkar Snehal Katkar (Inactive) added a comment -

            Hi Jayshree Nagpure,

            I have changed the code for ElectionImport and WaiveImport. It's working fine now. Please take it ahead for testing.
            However, issue of paycheck import is not related to effective date format. Hence, did not consider it under this ticket.

            cc: Rakesh Roy, Jaideep Vinchurkar

            Show
            snehal.katkar Snehal Katkar (Inactive) added a comment - Hi Jayshree Nagpure , I have changed the code for ElectionImport and WaiveImport. It's working fine now. Please take it ahead for testing. However, issue of paycheck import is not related to effective date format. Hence, did not consider it under this ticket. cc: Rakesh Roy , Jaideep Vinchurkar
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited

            Hi Snehal Katkar,

            Employee import is getting fail for "YYYYMMDD" when initial load is YES
            Also election and waive scenario which are mentioned in updated test cases are not working .
            Error log is same as attached in jira

            Re-opening this jira

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited Hi Snehal Katkar , Employee import is getting fail for "YYYYMMDD" when initial load is YES Also election and waive scenario which are mentioned in updated test cases are not working . Error log is same as attached in jira Re-opening this jira
            Hide
            snehal.katkar Snehal Katkar (Inactive) added a comment -

            Hi Jayshree Nagpure,

            1) Considering scope of this issue, I have tested all the scenarios mentioned in the document related to 'Demographics Import' and they working as expected.
            File changed - ImportValidation.vb

            2) The scenario which got failed for 'Election Import' is an existing issue and not because of this code change. Please open a separate ticket for it.

            3) Mentioned test cases for 'Waive Import' are working fine. No code change required.

            Show
            snehal.katkar Snehal Katkar (Inactive) added a comment - Hi Jayshree Nagpure , 1) Considering scope of this issue, I have tested all the scenarios mentioned in the document related to 'Demographics Import' and they working as expected. File changed - ImportValidation.vb 2) The scenario which got failed for 'Election Import' is an existing issue and not because of this code change. Please open a separate ticket for it. 3) Mentioned test cases for 'Waive Import' are working fine. No code change required.
            Hide
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) added a comment -

            Jayshree Nagpure, we will not be opening separate ticket for election import. We will fix in this ticket

            Show
            jaideep.vinchurkar Jaideep Vinchurkar (Inactive) added a comment - Jayshree Nagpure , we will not be opening separate ticket for election import. We will fix in this ticket
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited

            Verified for employee Import
            Company - QA ASML
            Employee import "YYYYMMDD" when initial load is YES - scenario Working fine

            After today's build will verify election import scenario, and will regress for all types of import.

            Thanks,
            Jayshree

            cc : Prasad Pise Sachin Hingole Rakesh Roy Hrishikesh Deshpande

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - - edited Verified for employee Import Company - QA ASML Employee import "YYYYMMDD" when initial load is YES - scenario Working fine After today's build will verify election import scenario, and will regress for all types of import. Thanks, Jayshree cc : Prasad Pise Sachin Hingole Rakesh Roy Hrishikesh Deshpande
            Hide
            suraj.sokasane Suraj Sokasane (Inactive) added a comment -

            As per our analysis this is not an issue on Stage and Prod for now. We'll confirm this tomorrow.

            Show
            suraj.sokasane Suraj Sokasane (Inactive) added a comment - As per our analysis this is not an issue on Stage and Prod for now. We'll confirm this tomorrow.
            Hide
            suraj.sokasane Suraj Sokasane (Inactive) added a comment -

            We analyzed the issue from election import point of view, it is failing for very specific scenario, where effective date given in file is less than hire date of employee and date format of template is YYYYMMDD. We can fix this right now, but will need more time for unit testing. So as of now, we should go ahead with demographic import fix as many clients are waiting for it. And for election import, we can consider this issue in import restructuring where EDI team expecting date format rationalization (WT-8876).
            Also, We found this is less likely scenario to happen. We scanned all companies on production using YYYYMMDD date format for election import and found a very few are using it currently.

            So assigning this back to QA

            Show
            suraj.sokasane Suraj Sokasane (Inactive) added a comment - We analyzed the issue from election import point of view, it is failing for very specific scenario, where effective date given in file is less than hire date of employee and date format of template is YYYYMMDD. We can fix this right now, but will need more time for unit testing. So as of now, we should go ahead with demographic import fix as many clients are waiting for it. And for election import, we can consider this issue in import restructuring where EDI team expecting date format rationalization ( WT-8876 ). Also, We found this is less likely scenario to happen. We scanned all companies on production using YYYYMMDD date format for election import and found a very few are using it currently. So assigning this back to QA
            Hide
            gaurav.sodani Gaurav Sodani (Inactive) added a comment -

            Hi All,

            Attaching the stage and production deployment approval email for reference: Unable to embed resource: FW Hot Fix and Development Approval Request.msg of type application/octet-stream

            Also, i have attached the email which states that we will be deploying only the Demographics import issue for now and will be taking up election import as part of Import module restructuring initiative

            Regards
            Gaurav

            Jayshree NagpureSuraj SokasaneJaideep VinchurkarSatyaSamirRakesh RoyJennifer ReedNagini IndugulaAbhay Patil

            Show
            gaurav.sodani Gaurav Sodani (Inactive) added a comment - Hi All, Attaching the stage and production deployment approval email for reference: Unable to embed resource: FW Hot Fix and Development Approval Request.msg of type application/octet-stream Also, i have attached the email which states that we will be deploying only the Demographics import issue for now and will be taking up election import as part of Import module restructuring initiative Regards Gaurav Jayshree Nagpure Suraj Sokasane Jaideep Vinchurkar Satya Samir Rakesh Roy Jennifer Reed Nagini Indugula Abhay Patil
            Hide
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment -

            Hi Suraj Sokasane,

            Verified on stage
            Company - ASML for hspl

            Verified only for demographics import
            PFA : FinalUpdatedTestcases.xls
            Verified for syn and async mode
            Verified with Initial load Yes/No
            Not considered any other import type.

            Working fine, Marking item state as Ready for production.

            Thanks,
            Jayshree

            cc : Rakesh Roy Prasad Pise Hrishikesh Deshpande Snehal Katkar

            Show
            jayshree.nagpure Jayshree Nagpure (Inactive) added a comment - Hi Suraj Sokasane , Verified on stage Company - ASML for hspl Verified only for demographics import PFA : FinalUpdatedTestcases.xls Verified for syn and async mode Verified with Initial load Yes/No Not considered any other import type. Working fine, Marking item state as Ready for production. Thanks, Jayshree cc : Rakesh Roy Prasad Pise Hrishikesh Deshpande Snehal Katkar
            Hide
            abhay.patil Abhay Patil (Inactive) added a comment -

            Question regarding comment by Suraj Sokasane - You have said the following.
            _... from election import point of view, it is failing for very specific scenario, where effective date given in file is less than hire date of employee and date format of template is YYYYMMDD.
            ... . We scanned all companies on production using YYYYMMDD date format for election import and found a very few are using it currently._

            I want to understand the following.

            • Will YYYYMMDD format always fail for election imports - or will it fail only under the specific scenario you mentioned?
            • When you say you found "a few companies using YYYYMMDD format for election import" - do you mean that those imports will fail? How many companies did you find?
              CC Cindy Wibbing Gaurav Sodani Jayshree Nagpure Jennifer Reed
            Show
            abhay.patil Abhay Patil (Inactive) added a comment - Question regarding comment by Suraj Sokasane - You have said the following. _... from election import point of view, it is failing for very specific scenario, where effective date given in file is less than hire date of employee and date format of template is YYYYMMDD. ... . We scanned all companies on production using YYYYMMDD date format for election import and found a very few are using it currently._ I want to understand the following. Will YYYYMMDD format always fail for election imports - or will it fail only under the specific scenario you mentioned? When you say you found "a few companies using YYYYMMDD format for election import" - do you mean that those imports will fail? How many companies did you find? CC Cindy Wibbing Gaurav Sodani Jayshree Nagpure Jennifer Reed
            Hide
            suraj.sokasane Suraj Sokasane (Inactive) added a comment - - edited

            Hi Abhay Patil,

            Below are the answers:

            • Will YYYYMMDD format always fail for election imports: No, election import won't fail always. It'll fail only in the specific scenario mentioned above.
            • When you say you found "a few companies using YYYYMMDD format for election import" - do you mean that those imports will fail? : Yes, but as per the first answer above, only for the specific scenario and not always.
            • How many companies did you find? : I'm attaching an excel sheet which contains data - Company name, Template name and number of imports on that template in 2017 till now. Here it is : WT-12252 Data.xls

            Hope this successfully answers your queries. Please let us know if you know more details on same.

            Show
            suraj.sokasane Suraj Sokasane (Inactive) added a comment - - edited Hi Abhay Patil , Below are the answers: Will YYYYMMDD format always fail for election imports : No, election import won't fail always. It'll fail only in the specific scenario mentioned above. When you say you found "a few companies using YYYYMMDD format for election import" - do you mean that those imports will fail? : Yes, but as per the first answer above, only for the specific scenario and not always. How many companies did you find? : I'm attaching an excel sheet which contains data - Company name, Template name and number of imports on that template in 2017 till now. Here it is : WT-12252 Data.xls Hope this successfully answers your queries. Please let us know if you know more details on same.
            Hide
            hrishikesh.deshpande Hrishikesh Deshpande (Inactive) added a comment -

            Hi All,

            This Fix is Deployed and Tested on Production. This is working as expected for all date formats.
            Closing this JIRA.

            Thanks,
            Hrishikesh.

            Show
            hrishikesh.deshpande Hrishikesh Deshpande (Inactive) added a comment - Hi All, This Fix is Deployed and Tested on Production. This is working as expected for all date formats. Closing this JIRA. Thanks, Hrishikesh.

              People

              Assignee:
              hrishikesh.deshpande Hrishikesh Deshpande (Inactive)
              Reporter:
              snehal.katkar Snehal Katkar (Inactive)
              Developer:
              Snehal Katkar (Inactive)
              QA:
              Jayshree Nagpure (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Dev Due Date:
                Pre-Prod Due Date:
                Production Due Date:
                Code Review Date:

                  Time Tracking

                  Estimated:
                  Original Estimate - 22h Original Estimate - 22h
                  22h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 60h
                  60h